From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#45818: 28.0.50; Test solar-sunrise-sunset fails Date: Tue, 12 Jan 2021 20:06:30 +0000 Message-ID: <87ft35j4xl.fsf@tcd.ie> References: <871reqp1ax.fsf@tcd.ie> <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17205"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45818@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 12 21:07:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzPwm-0004JN-7F for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 21:07:20 +0100 Original-Received: from localhost ([::1]:43846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzPwl-0001mM-9C for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 Jan 2021 15:07:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzPwW-0001mD-Nh for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 15:07:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49934) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kzPwT-0004nu-UG for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 15:07:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kzPwT-0005p8-Ot for bug-gnu-emacs@gnu.org; Tue, 12 Jan 2021 15:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jan 2021 20:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45818 X-GNU-PR-Package: emacs Original-Received: via spool by 45818-submit@debbugs.gnu.org id=B45818.161048200122357 (code B ref 45818); Tue, 12 Jan 2021 20:07:01 +0000 Original-Received: (at 45818) by debbugs.gnu.org; 12 Jan 2021 20:06:41 +0000 Original-Received: from localhost ([127.0.0.1]:33247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzPw8-0005oX-PG for submit@debbugs.gnu.org; Tue, 12 Jan 2021 15:06:41 -0500 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:37255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kzPw6-0005oG-ND for 45818@debbugs.gnu.org; Tue, 12 Jan 2021 15:06:39 -0500 Original-Received: by mail-wr1-f44.google.com with SMTP id i9so3802995wrc.4 for <45818@debbugs.gnu.org>; Tue, 12 Jan 2021 12:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0T8ZVaU4niv8o6QZXy4H9CmwN+tIZjpjyqLvxDvEyXU=; b=cw6S12KHP/SZyHCz6NCNm5WovK4GbJAp+UJZ8xzcoyKohDh9JSxAG1/uojLG/4UFVT 87kQxXL6gNhYRYPljLfDQzVQxd9kCtxkCaw1YS+0700+dvw7UI81XWx67zxueGq8gVgw xixxWtKHyZ74XHqxMA559QbqO7rhECeASq74ZrrTuVpbhTC93cSHil17NEFleXgDMmhI k0TCvjSCIdabDzyENlmB2suLZy8/SVYHhbg2AkoHYzoXT/EcZ4plblQ4RpOzln2kRwJU toEBl6r83MI20e4/kza7okmNLwN1LUgGH7cnqHOrObUDqxqoh2B0wxGLVEdb84IsOWGq F6AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=0T8ZVaU4niv8o6QZXy4H9CmwN+tIZjpjyqLvxDvEyXU=; b=HGGfOWxMsH3YM5dOLvK2HACuqMhGWY4qd7Gki32eMyIhjiuqiUEnaZ/Xp7292HX5SR xcN4TY+lsu+x9AFxrDvKKihfb8sCeQHMbBpkrBfnUVeNJMc8ZS9TQyNzUxuv8Veqlrok QqbSQnqF0G4mfC4cl0AFx2OX/lmp4kiFbzAmSdodaNbWcJfc9hRrFfBi4q8KDwgbmYXZ YY5HnfZGXOu56Vydwzl5+QETglTFAsSSSKDYIcZzoW/5jwqbl7JkDwglwxa0UETrxgca yqBlMkVHlLhByyHBmUwerWINmbq2PFYvhctds81JzKVFr7++nMdEdDx1WUnLwM6E40zg zMQQ== X-Gm-Message-State: AOAM531YANtHgx32aMpUcEXnOQJ4ms5Nj7HCJMJczUnnG1n1xT4SrU+V Bov5Nm+lS4cgKyZ0l2CheuCIiw== X-Google-Smtp-Source: ABdhPJwaVVkKd201kg+oRsnV7VJ4mScDOY/2CcAKhsu8YAANbpCPM45PXc7e8fQgWMO4tMuqFt87qQ== X-Received: by 2002:a5d:54cc:: with SMTP id x12mr534757wrv.132.1610481992721; Tue, 12 Jan 2021 12:06:32 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id r1sm6732329wrl.95.2021.01.12.12.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 12:06:31 -0800 (PST) In-Reply-To: <28AECF36-B916-427E-A0EC-633AED7CB9BF@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Tue, 12 Jan 2021 19:50:33 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197844 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mattias Engdeg=C3=A5rd writes: > Could you try tracking down the origin of those numbers? Here is a trace = of some > of the relevant functions on my machines: > > 1 -> (solar-sunrise-sunset (12 30 2020)) > | 2 -> (solar-exact-local-noon (12 30 2020)) > | | 3 -> (solar-julian-ut-centuries (12 30 2020)) > | | 3 <- solar-julian-ut-centuries: 0.2099520876112252 > | 2 <- solar-exact-local-noon: ((12 30 2020) 6.9905251059993585) > | 2 -> (solar-julian-ut-centuries (12 30 2020)) > | 2 <- solar-julian-ut-centuries: 0.2099520876112252 > | 2 -> (solar-sidereal-time 0.2099520876112252) > | 2 <- solar-sidereal-time: 6.592887211896198 > | 2 -> (solar-sunrise-and-sunset (0.2099520876112252 6.9905251059993585) = 1.0 75.8 0) > | 2 <- solar-sunrise-and-sunset: (6.5198219809993585 18.46122823099936 11= .941406250000002) > | 2 -> (solar-sunrise-and-sunset (0.2099520876112252 6.9905251059993585) = 26.9 75.8 -0.61) > | 2 <- solar-sunrise-and-sunset: (7.2698219809993585 17.71122823099936 10= .441406250000002) > | 2 -> (dst-adjust-time (12 30 2020) 7.2698219809993585) > | 2 <- dst-adjust-time: ((12 30 2020) 7.2666666666045785 "IST") > | 2 -> (dst-adjust-time (12 30 2020) 17.71122823099936) > | 2 <- dst-adjust-time: ((12 30 2020) 17.716666666790843 "IST") > | 2 -> (calendar-date-equal (12 30 2020) (12 30 2020)) > | 2 <- calendar-date-equal: t > | 2 -> (calendar-date-equal (12 30 2020) (12 30 2020)) > | 2 <- calendar-date-equal: t > 1 <- solar-sunrise-sunset: ((7.2666666666045785 #1=3D"IST") (17.716666666= 790843 #1#) "10:26") Here's my version of this trace: 1 -> (solar-sunrise-sunset (12 30 2020)) | 2 -> (solar-exact-local-noon (12 30 2020)) | | 3 -> (solar-julian-ut-centuries (12 30 2020)) | | 3 <- solar-julian-ut-centuries: 0.2099520876112252 | 2 <- solar-exact-local-noon: ((12 30 2020) 6.9905251059993585) | 2 -> (solar-julian-ut-centuries (12 30 2020)) | 2 <- solar-julian-ut-centuries: 0.2099520876112252 | 2 -> (solar-sidereal-time 0.2099520876112252) | 2 <- solar-sidereal-time: 6.592887211896198 | 2 -> (solar-sunrise-and-sunset (0.2099520876112252 6.9905251059993585) 1.= 0 75.8 0) | 2 <- solar-sunrise-and-sunset: (6.5198219809993585 18.46122823099936 11.9= 41406250000002) | 2 -> (solar-sunrise-and-sunset (0.2099520876112252 6.9905251059993585) 26= .9 75.8 -0.61) | 2 <- solar-sunrise-and-sunset: (7.2698219809993585 17.71122823099936 10.4= 41406250000002) | 2 -> (dst-adjust-time (12 30 2020) 7.2698219809993585) | 2 <- dst-adjust-time: ((12 30 2020) 6.266666667535901 "IST") | 2 -> (dst-adjust-time (12 30 2020) 17.71122823099936) | 2 <- dst-adjust-time: ((12 30 2020) 16.716666667722166 "IST") | 2 -> (calendar-date-equal (12 30 2020) (12 30 2020)) | 2 <- calendar-date-equal: t | 2 -> (calendar-date-equal (12 30 2020) (12 30 2020)) | 2 <- calendar-date-equal: t 1 <- solar-sunrise-sunset: ((6.266666667535901 #1=3D"IST") (16.716666667722= 166 #1#) "10:26") So I'm guessing dst-adjust-time adjusts for DST in my locale (based on some cache), but not yours? The following change lets the test succeed for me: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=dst.diff diff --git a/test/lisp/calendar/solar-tests.el b/test/lisp/calendar/solar-tests.el index 7a37f8db55..dff64635e5 100644 --- a/test/lisp/calendar/solar-tests.el +++ b/test/lisp/calendar/solar-tests.el @@ -26,7 +26,7 @@ solar-sunrise-sunset (calendar-longitude 75.8) (calendar-time-zone +330) (calendar-standard-time-zone-name "IST") - (calendar-daylight-time-zone-name "IST") + (calendar-daylight-savings-starts nil) (epsilon (/ 60.0))) ; Minute accuracy is good enough. (let* ((sunrise-sunset (solar-sunrise-sunset '(12 30 2020))) (sunrise (car (nth 0 sunrise-sunset))) --=-=-= Content-Type: text/plain Does it look like TRT? Thanks, -- Basil --=-=-=--