all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Nicholas Drozd <nicholasdrozd@gmail.com>
Cc: 43302@debbugs.gnu.org
Subject: bug#43302: password shows up in shell buffer (27.1)
Date: Wed, 27 Jan 2021 07:20:39 +0100	[thread overview]
Message-ID: <87ft2maojs.fsf@gnus.org> (raw)
In-Reply-To: <CABAiW0pgpCWOVtGTVXtZX6NjnUQmfq0UPqEPxxihDzrWKmyrhg@mail.gmail.com> (Nicholas Drozd's message of "Wed, 9 Sep 2020 19:40:04 -0500")

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

Nicholas Drozd <nicholasdrozd@gmail.com> writes:

> In 27, it looks like this:
>
> #+begin_src
> $ bash password.sh
> Password:
> asdf
> $
> #+end_src
>
> The password (=asdf=) gets input directly into the shell buffer, unstarred.

I'm able to reproduce the behaviour in Emacs 27 and 28.  However, if you
say this:

echo -n "Password:"
read -sr password

Then Emacs will *** the password in the minibuffer, so comint only
triggers the password-reading behaviour if there's no newline there.

Now, Emacs 26 did handle this...  somewhat:


[-- Attachment #2: Type: image/png, Size: 8929 bytes --]

[-- Attachment #3: Type: text/plain, Size: 366 bytes --]


That is, it would include the newline in the prompt.

So...  I think basically this works as intended currently: comint only
triggers the password-reading behaviour if the prompt is on the current
line (i.e., without a newline), so I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

  parent reply	other threads:[~2021-01-27  6:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  0:40 bug#43302: password shows up in shell buffer (27.1) Nicholas Drozd
2020-09-10 12:26 ` Robert Pluim
2021-01-27  6:20 ` Lars Ingebrigtsen [this message]
2021-02-12 20:50   ` Nicholas Drozd
2021-02-13  7:23     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ft2maojs.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=43302@debbugs.gnu.org \
    --cc=nicholasdrozd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.