From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#46257: 28.0.50; use flat-button in modus-operandi theme Date: Thu, 04 Feb 2021 14:09:56 +0200 Message-ID: <87ft2cniej.fsf@protesilaos.com> References: <87czxi8ux3.fsf@tcd.ie> <87y2g62tpp.fsf@protesilaos.com> <87v9b8fcph.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32222"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , Protesilaos Stavrou , 46257@debbugs.gnu.org, Pedro Andres Aranda Gutierrez To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 04 13:11:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7dTh-0008Go-1G for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Feb 2021 13:11:17 +0100 Original-Received: from localhost ([::1]:35560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7dTf-0002Fv-W7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Feb 2021 07:11:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7dTS-0002Fn-NK for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 07:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7dTS-0001cT-G0 for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 07:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l7dTS-0001hS-9L for bug-gnu-emacs@gnu.org; Thu, 04 Feb 2021 07:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Feb 2021 12:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46257 X-GNU-PR-Package: emacs Original-Received: via spool by 46257-submit@debbugs.gnu.org id=B46257.16124406096461 (code B ref 46257); Thu, 04 Feb 2021 12:11:02 +0000 Original-Received: (at 46257) by debbugs.gnu.org; 4 Feb 2021 12:10:09 +0000 Original-Received: from localhost ([127.0.0.1]:40096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7dSb-0001g9-Bl for submit@debbugs.gnu.org; Thu, 04 Feb 2021 07:10:09 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:32773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7dSY-0001fX-TM for 46257@debbugs.gnu.org; Thu, 04 Feb 2021 07:10:08 -0500 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 8F9F8240011; Thu, 4 Feb 2021 12:09:57 +0000 (UTC) In-Reply-To: <87v9b8fcph.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 04 Feb 2021 09:40:10 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199293 Archived-At: On 2021-02-04, 09:40 +0100, Lars Ingebrigtsen wrote: > Protesilaos Stavrou writes: > >> That change looks good to me. Please apply it wherever it would be >> appropriate. And please do the same for the modus-vivendi theme. >> >> Now a question that is not pertinent to Emacs 28: does this flat-button >> degrade gracefully on older versions, say, 27? The reason I am asking >> is because I will need to mirror any patch on my upstream repo; and I >> know that there are users who run the themes on older versions of Emacs. > > It won't degrade gracefully, so will applying the patch to Emacs 28 > create problems for you? If so, applying it doesn't seem all that > vital, since the visual result is the same (I think?), and it's just a > simplification (in Emacs 28). In that case I would prefer not to introduce the patch, even though I understand it would otherwise align the themes with the latest state of emacs.git. That granted, the pattern of hiding the :box border by colourising it the same as the background is uncommon. So if you still wish to apply the flat-button, I will just maintain separate patches for whenever I submit a new version of the themes to emacs.git. -- Protesilaos Stavrou protesilaos.com