From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= Newsgroups: gmane.emacs.devel Subject: Re: Concern about new binding. Date: Thu, 04 Feb 2021 22:00:01 +0100 Message-ID: <87ft2bim5q.fsf@gmail.com> References: <87zh0mmr54.fsf@gmail.com> <87y2g5smya.fsf@gmail.com> <4FF55FBF-573D-4A70-B3FC-682CA25B7ECB@gnu.org> <83lfc53whk.fsf@gnu.org> <20210203180142.seu6o3i6u7jhkyrh@Ergus> <83eehx3to5.fsf@gnu.org> <20210203221628.xgvvxjvh56gyswba@Ergus> <20210204070033.pm4ido4hq7a6twif@Ergus> <83sg6brhyg.fsf@gnu.org> <87a6sjpyqs.fsf@gnus.org> <838s83ra3q.fsf@gnu.org> <87mtwjocn7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1066"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: emacs-devel@gnu.org Cancel-Lock: sha1:kIf5NJiw4tZE+HnSEnJ99PT+2ZI= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 04 22:01:21 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l7lkd-00009C-Ps for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Feb 2021 22:01:19 +0100 Original-Received: from localhost ([::1]:40326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7lkc-00058k-SK for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Feb 2021 16:01:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7ljX-0004VI-0e for emacs-devel@gnu.org; Thu, 04 Feb 2021 16:00:11 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:35572) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7ljU-00085a-5t for emacs-devel@gnu.org; Thu, 04 Feb 2021 16:00:09 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1l7ljS-0009F3-7B for emacs-devel@gnu.org; Thu, 04 Feb 2021 22:00:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263915 Archived-At: Lars Ingebrigtsen writes: > The one concern about the `C-x g' binding is that Magit already > recommends it, but it's unclear to me how many people actually use it, > and what it's bound to. Is it just a global binding for `M-x magit'? > > Presumably Magit users who've bound it to that will continue to do so... > and then they'll miss the new binding(s) under `C-x g', but I guess > that's up to each individual user. To clarify: - C-x g is bound to magit-status, which is Magit's main entry point, - Magit includes an autoloaded form that binds C-x g if - that key sequence is not bound to anything else, and - magit-status is not already bound, and - the user hasn't set an explicit "dont-do-that" variable. (Same goes for two other bindings: C-x M-g for magit-dispatch, and C-c M-g for magit-file-dispatch.) So adding a default binding for C-x g *will* change how Magit behaves in its default configuration. I struggle to form a solid stance about the change under discussion: - I wouldn't find it outlandish for Magit to do something similar to rg.el: provide a function (say magit-enable-default-bindings) that users can call in their init file to easily setup some bindings under a prefix (that would default to C-c g). - I wouldn't mind C-x g (or C-x g g, or C-x g r) being bound to revert-buffer. - I find C-x g somewhat awkward as a prefix for buffer commands. Not really mnemonic, at least.