From: Michael Albinus <michael.albinus@gmx.de>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: 46351@debbugs.gnu.org
Subject: bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining
Date: Mon, 08 Feb 2021 11:28:54 +0100 [thread overview]
Message-ID: <87ft26etuh.fsf@gmx.de> (raw)
In-Reply-To: <874kin1z2x.fsf@melete.silentflame.com> (Sean Whitton's message of "Sun, 07 Feb 2021 12:01:58 -0700")
Sean Whitton <spwhitton@spwhitton.name> writes:
Hi Sean,
>> Applying your patch, I get the compiler warning
>>
>> --8<---------------cut here---------------start------------->8---
>> ELC eshell/esh-mode.elc
>>
>> In end of data:
>> eshell/esh-mode.el:1114:1: Warning: the function ‘(setf buffer-substring)’ is
>> not known to be defined.
>> --8<---------------cut here---------------end--------------->8---
>
> Hrm, I can't reproduce this, but looking at the docs, I think that the
> problem is a missing (require 'cl-lib). Would you mind seeing whether
> that eliminates the warning at your end?
Yes, that helps.
>> And using it in eshell, there is
>>
>> --8<---------------cut here---------------start------------->8---
>> ~/src/emacs $ !! cat ~/.emacs | grep albinus
>> !!: command not found
>> --8<---------------cut here---------------end--------------->8---
>
> You need to add eshell-expand-to-eshell-shell-command to
> eshell-expand-input-functions and (optionally)
> eshell-restore-unexpanded-input to eshell-input-filter-functions. Or
> maybe (the first of) these should be added by default? What do you think?
>
> For testing you can type these forms into an Eshell buffer:
>
> (add-hook 'eshell-expand-input-functions #'eshell-expand-to-eshell-shell-command nil t)
> (add-hook 'eshell-input-filter-functions #'eshell-restore-unexpanded-input nil t)
That works. Maybe we could add it to the defaults. But at least I would
like to see it documented in the eshell manual, otherwise nobody will
know the effect of "!!".
And I have the impression, that the eshell history is not preserved any
longer, when I have applied these settings.
>> I wanted to see, whether this works also for remote directories. Have
>> you tested this?
>
> Yes, I have, and it works (I did cat largefile >file and confirmed it's
> much faster when prefixed with !!, of course because the data doesn't
> get copied to the local machine).
It doesn't work for me. The reason is a little bit subtle: you use
`shell-file-name' in order to call a remote shell. In my case, it is
"/usr/local/bin/tcsh", which doesn't exist on the remote machine I've
used for testing.
Maybe you can base your implementation on `shell-command'? This should
know, how to handle a connection-local `shell-file-name'.
Best regards, Michael.
next prev parent reply other threads:[~2021-02-08 10:28 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 20:06 bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining Sean Whitton
2021-02-07 9:17 ` Michael Albinus
2021-02-07 19:01 ` Sean Whitton
2021-02-08 10:28 ` Michael Albinus [this message]
2021-02-08 18:07 ` Sean Whitton
2021-02-10 11:33 ` Michael Albinus
2021-12-24 21:20 ` Sean Whitton
2021-12-25 13:51 ` Michael Albinus
2021-12-25 22:45 ` Sean Whitton
2021-12-27 14:42 ` Michael Albinus
2021-12-27 18:13 ` Sean Whitton
2021-12-27 18:22 ` Eli Zaretskii
2021-12-27 19:21 ` Sean Whitton
2021-12-27 19:35 ` Eli Zaretskii
2021-12-27 19:53 ` Sean Whitton
2021-12-27 19:37 ` Michael Albinus
2021-12-27 19:54 ` Sean Whitton
2021-12-28 8:58 ` Michael Albinus
2022-01-18 5:19 ` Sean Whitton
2022-01-18 9:49 ` Robert Pluim
2022-01-18 18:27 ` Sean Whitton
2022-01-18 14:45 ` Eli Zaretskii
2022-01-18 18:40 ` Sean Whitton
2022-01-18 19:38 ` Eli Zaretskii
2022-01-18 23:16 ` Sean Whitton
2022-01-19 7:34 ` Eli Zaretskii
2022-01-19 20:39 ` Sean Whitton
2022-01-20 6:53 ` Eli Zaretskii
2022-01-20 22:16 ` Sean Whitton
2022-01-21 6:54 ` Eli Zaretskii
2022-01-22 0:16 ` Sean Whitton
2022-01-18 18:42 ` Sean Whitton
2022-01-19 15:52 ` Michael Albinus
2022-01-19 20:54 ` Sean Whitton
2022-01-20 18:41 ` Michael Albinus
2022-01-20 22:17 ` Sean Whitton
2022-01-23 22:39 ` Sean Whitton
2022-01-24 9:55 ` Lars Ingebrigtsen
2022-01-24 14:18 ` Michael Albinus
2022-01-24 20:32 ` Sean Whitton
2022-01-24 20:44 ` Sean Whitton
2022-01-24 20:48 ` Lars Ingebrigtsen
2022-01-24 21:42 ` Sean Whitton
2022-01-24 21:51 ` Lars Ingebrigtsen
2022-01-24 22:48 ` Sean Whitton
2022-01-24 20:46 ` Lars Ingebrigtsen
2022-01-25 2:39 ` Jim Porter
2022-01-25 5:33 ` bug#53518: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols Sean Whitton
2022-01-25 8:50 ` Sean Whitton
2022-01-25 12:26 ` Lars Ingebrigtsen
2022-01-25 16:48 ` Sean Whitton
2022-01-26 5:38 ` Jim Porter
2022-01-26 13:13 ` Lars Ingebrigtsen
2022-01-25 18:14 ` Jim Porter
2022-01-25 20:01 ` Sean Whitton
2022-01-25 20:52 ` Jim Porter
2022-01-25 22:38 ` Sean Whitton
2022-01-25 8:54 ` bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining Michael Albinus
2022-01-25 18:22 ` Jim Porter
2021-12-27 18:26 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft26etuh.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=46351@debbugs.gnu.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.