From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46574: cperl-mode: Improve detection of entries for imenu [PATCH] Date: Wed, 17 Feb 2021 00:56:56 +0100 Message-ID: <87ft1vpnw7.fsf@gnus.org> References: <871rdffwtr.fsf@hajtower> <877dn7r4y7.fsf@gnus.org> <87tuqbefrb.fsf@hajtower> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34890"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46574@debbugs.gnu.org To: haj@posteo.de (Harald =?UTF-8?Q?J=C3=B6rg?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 17 00:58:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCAEZ-0008x4-HS for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Feb 2021 00:58:23 +0100 Original-Received: from localhost ([::1]:47070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCAEY-00059z-08 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Feb 2021 18:58:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCAEE-00058s-NE for bug-gnu-emacs@gnu.org; Tue, 16 Feb 2021 18:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCAEE-0004IK-GU for bug-gnu-emacs@gnu.org; Tue, 16 Feb 2021 18:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lCAEE-0006Xz-Ft for bug-gnu-emacs@gnu.org; Tue, 16 Feb 2021 18:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Feb 2021 23:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46574-submit@debbugs.gnu.org id=B46574.161351983225091 (code B ref 46574); Tue, 16 Feb 2021 23:58:02 +0000 Original-Received: (at 46574) by debbugs.gnu.org; 16 Feb 2021 23:57:12 +0000 Original-Received: from localhost ([127.0.0.1]:42019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCADQ-0006Wc-AL for submit@debbugs.gnu.org; Tue, 16 Feb 2021 18:57:12 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:58210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCADN-0006WK-JD for 46574@debbugs.gnu.org; Tue, 16 Feb 2021 18:57:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1sjGfF0zAHiyhCQnsf2r5NL9bMXTw/zLjXdHk6HrzBQ=; b=pVMZ9G53YI3EWyAMKMDSczIXKu wyuVkgLsEa8W2JuSv/92QRjSqewlmAlS8dp+wj1wA9hhvh9vASPxi8nK6lkiDCS2ZSyCjGMCJ5uZ3 l1A9ZTgrWbaAk48coBCDGweWzLKqNjgEepBo2qCmFh1rxyti81XaGUYKx83A8+TsYsho=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCADD-0001t6-2h; Wed, 17 Feb 2021 00:57:03 +0100 X-Now-Playing: Gang Gang Dance's _Revival of the Shittest_: "Untitled" In-Reply-To: <87tuqbefrb.fsf@hajtower> ("Harald =?UTF-8?Q?J=C3=B6rg?="'s message of "Wed, 17 Feb 2021 00:48:08 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200178 Archived-At: haj@posteo.de (Harald J=C3=B6rg) writes: > I've reviewed Stefan's changes now. There is definitely no conflict and > the patch can be applied regardless of the offset. The offset mainly > came with 24a98755 (Feb 13), where Stefan eliminated a length of > obsolete documentation. Thanks for checking; I've now applied your patch to Emacs 28. > BTW: Stefan's cleanup work is great here. Yup. > I've always wanted to start working on this but I am not confident > enough. I don't know enough about the histories of (X)Emacs and > CPerl-mode. I'm a bit vague about the history of the mode, too, but it's OK to rip out all XEmacs compat code (and compat code with Emacs < 26.1, I think). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no