From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#35166: 27.0.50; Buffer state inconsistent after vc-retrieve-tag Date: Wed, 23 Jun 2021 12:13:28 -0300 Message-ID: <87fsx8fwbr.fsf@tbb.theblackbeard.org> References: <87bl7xolie.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7412"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 35166@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 23 17:13:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lw4Z3-0001pE-9R for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Jun 2021 17:13:17 +0200 Original-Received: from localhost ([::1]:56078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lw4Z2-0000OT-Ar for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Jun 2021 11:13:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lw4Yo-0000M7-63 for bug-gnu-emacs@gnu.org; Wed, 23 Jun 2021 11:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58355) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lw4Yn-0002zv-UG for bug-gnu-emacs@gnu.org; Wed, 23 Jun 2021 11:13:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lw4Yn-00056c-PF for bug-gnu-emacs@gnu.org; Wed, 23 Jun 2021 11:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Jun 2021 15:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35166 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed moreinfo Original-Received: via spool by 35166-submit@debbugs.gnu.org id=B35166.162446113519568 (code B ref 35166); Wed, 23 Jun 2021 15:13:01 +0000 Original-Received: (at 35166) by debbugs.gnu.org; 23 Jun 2021 15:12:15 +0000 Original-Received: from localhost ([127.0.0.1]:41668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lw4Y3-00055X-9e for submit@debbugs.gnu.org; Wed, 23 Jun 2021 11:12:15 -0400 Original-Received: from mail-qt1-f172.google.com ([209.85.160.172]:40515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lw4Y2-00055L-13 for 35166@debbugs.gnu.org; Wed, 23 Jun 2021 11:12:14 -0400 Original-Received: by mail-qt1-f172.google.com with SMTP id t9so2312460qtw.7 for <35166@debbugs.gnu.org>; Wed, 23 Jun 2021 08:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EUoRUKoojbPd6bIsvAvvysSEa5Y0pwwsz72v0g0GKeU=; b=sUmN8wMOd75oXk0BRaJg11Hus0WwzBcxaJBCJXBFMfGHC/yetwpe8wHKVnfpSe3QPm zAfm4BeeYsosfaaW9OqZ6yMrVYCTG+XgumO7zPrFbE7qKXOvQ0J6XJcxSSVespjWyTom PRxVY5k0iPqsk+TJuubctgqWX3fERwkEYqieBVC+onhVmVo509ifyRGRGy//9L3onoXL cLZVkbyh9brxtkIUmczkFtbGvo3LgejCYmW5147xjo1lbTo9vshOb3KBGUTnHw1AGTk7 q83vI6bPDGOF/oHXHCNzGv2i33J977ROgBKUL+4XbyVNCLeZYb3SxkviBzkl1mlnPGek xUHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=EUoRUKoojbPd6bIsvAvvysSEa5Y0pwwsz72v0g0GKeU=; b=bJY707fJ9ErQdw/dAHZ1fEwsxp+z6vrTkS/gW43oKWFJxg/8IX2CpDGC1CxumFVs7v +w4mPFFOy8vJt7TskWHAfgnmh+jgJovYP1w5ofrXu/g65Fqkin+1aoNvDELXNyeJtVBT 0x+mKYYKQRySiehZA1N+cD4SdzG087pvYDyjqe7f/8D4utEo+XI08Q/O//QlJ4hkiCx8 T0WMsgdkNBYyCvoXWx6nrgGb1kdeDku2FSDmudND4RPUbrYlNvN2C+kZIwmOzJDmd4Ww C9SeiSbeJH/qICreQsoAuFwhpu9E31akSTbTuGqeq1ZJZ/5T+KIOkbdVY2oiQ2imu3G2 KETQ== X-Gm-Message-State: AOAM532rW+8IynyAd13q8ZmlafSw2eXFlYaMnJdphtAfFzHJDAr1HBiv C4S+hP5erSQ31/Sr6BI0qB+E1oue4NM= X-Google-Smtp-Source: ABdhPJyl3PfHCP8AOVXCR0NbeP5PeK+18YT1wRCTUX0OdXpLOlOhpNkLry+K4lW1Gv88rPgODT5j/A== X-Received: by 2002:a05:622a:11c3:: with SMTP id n3mr325035qtk.211.1624461127827; Wed, 23 Jun 2021 08:12:07 -0700 (PDT) Original-Received: from tbb.theblackbeard.org ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id l14sm150053qtj.26.2021.06.23.08.12.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 08:12:07 -0700 (PDT) In-Reply-To: <87bl7xolie.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 22 Jun 2021 19:30:01 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208904 Archived-At: Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> Please, consider either improving what 'vc-retrieve-tag' does, regarding the >> previous state of the buffer, or improving the documentation about this >> behavior. Or, if you think I'm plain wrong, please explain me the >> reasons, since I would like to understand more of it. > > I think it would make sense for `vc-retrieve-tag' to preserve the > readedness of the buffer. Anybody got any comments here? FWIW, I've been saving the readedness since I reported this bug by using before-revert-hook and after-revert-hook. I don't know if vc-retrieve-tag should save it, but I think leaving the buffer in this state (view-mode on and not read-only) should be avoided, if possible.