From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix hack-local-variables for find-file-literally with dos encoding Date: Mon, 16 Aug 2021 00:14:43 +0200 Message-ID: <87fsvagxt8.fsf@gnus.org> References: <87o89ygyu8.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22318"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Emacs developers To: Tom Gillespie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 16 00:15:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFOPp-0005ba-Lv for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 00:15:37 +0200 Original-Received: from localhost ([::1]:34108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFOPo-0005QK-8d for ged-emacs-devel@m.gmane-mx.org; Sun, 15 Aug 2021 18:15:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFOP6-0004fj-3L for emacs-devel@gnu.org; Sun, 15 Aug 2021 18:14:52 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:54262) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFOP4-0007hw-K6 for emacs-devel@gnu.org; Sun, 15 Aug 2021 18:14:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kxldJ/KG1zrVUbnDq4T0x+VNgSUw/CcHLhKQ9tzQLr8=; b=m6QG++ELvjM+3Ez7+m/sojk+gq 2jMfk1IHkHMgCmK9JYGHIzIRKMwFica2sqOdtVYmc6rvetH/s0jFDxEUDzW/2joy9pbauvvdPcFzK brZ7F2f5DaLOmMzKj3WcFhYSTUG32aVTIqVCpgqTZspzaH+NMKoEGSR9CScWgR2/SgdY=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFOOy-0005Qi-3X; Mon, 16 Aug 2021 00:14:48 +0200 In-Reply-To: <87o89ygyu8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 15 Aug 2021 23:52:31 +0200") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272414 Archived-At: Lars Ingebrigtsen writes: >> - (subst-char-in-region (point) (point-max) ?\^m ?\n) >> + (unless noconv >> + (subst-char-in-region (point) (point-max) ?\^m ?\n)) Looking at the existing code here, I think that `subst-char-in-region' is wrong in any case, but following the history of that function is pretty difficult. It might have originated here? commit e0b2a2d9afff14ce5babae84c50f24f1f0e89b02 Author: Richard M. Stallman AuthorDate: Mon Sep 20 16:12:57 2004 +0000 If the intention is to fix up DOS line endings, when it's the wrong thing -- it should transform \r\n to \n, not transform any \r anywhere in a line to \n... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no