From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#21612: 24.5; Configuration variable to delete auto-save file when intentionally killing buffer Date: Sun, 22 Aug 2021 23:55:05 +0200 Message-ID: <87fsv1w3eu.fsf@gnus.org> References: <87im05d0rr.fsf@gnus.org> <83fsv98roh.fsf@gnu.org> <878s11a44w.fsf@gnus.org> <838s118opm.fsf@gnu.org> <87k0kidiqm.fsf@gnus.org> <83sfz6512h.fsf@gnu.org> <874kbmdgak.fsf@gnus.org> <83o89u50fg.fsf@gnu.org> <87r1eqbz8q.fsf@gnus.org> <83h7fm4tpl.fsf@gnu.org> <87lf4yaenz.fsf@gnus.org> <83bl5u4s95.fsf@gnu.org> <87pmu98u01.fsf@gnus.org> <83h7fk1vob.fsf@gnu.org> <87eeao8cte.fsf@gnus.org> <83a6l9yghm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4550"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: mrok4a@gmail.com, 21612@debbugs.gnu.org, rms@gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 22 23:56:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHvRo-0000ww-Rg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Aug 2021 23:56:08 +0200 Original-Received: from localhost ([::1]:54216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHvRn-0002k2-Uo for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Aug 2021 17:56:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHvRh-0002jj-V0 for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 17:56:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56641) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mHvRh-0005h3-M7 for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 17:56:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mHvRh-0007kB-Jm for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 17:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Aug 2021 21:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21612 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 21612-submit@debbugs.gnu.org id=B21612.162966931929720 (code B ref 21612); Sun, 22 Aug 2021 21:56:01 +0000 Original-Received: (at 21612) by debbugs.gnu.org; 22 Aug 2021 21:55:19 +0000 Original-Received: from localhost ([127.0.0.1]:39954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHvR1-0007jI-KY for submit@debbugs.gnu.org; Sun, 22 Aug 2021 17:55:19 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:37350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHvR0-0007j4-4S for 21612@debbugs.gnu.org; Sun, 22 Aug 2021 17:55:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=etAiCkotTJbHlykT4ERhYZ7Kac9R0aGxJxpCez0/L2s=; b=K6/z5v9U/fEHZ6CwZ57G3I0QUq Zz3xMAN53GtLuFRygJ1XhpO1unySo+FnM20N7ywnxyyG0XYqhbb7X24L4YvFS7c+YI6xDhCx3zb1w FJ/zMBCJEtoyJZ5jAAhRBce9s2q8pNm6/wVG6jGesCA7jWcSm9hsORIJyMtzx9eVufDc=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHvQo-0003SY-DY; Sun, 22 Aug 2021 23:55:10 +0200 In-Reply-To: <83a6l9yghm.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 Aug 2021 12:29:41 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212444 Archived-At: Eli Zaretskii writes: > The condition I emphasized above should be reversed, because it means > the buffer _is_ modified, whereas according to the comment we need to > test that it _isn't_. Right? I... think so. > And second, I think the condition before it should be changed to say > > && BUF_SAVE_MODIFF (b) <= BUF_AUTOSAVE_MODIFF (b) > > I see no reason to reject the situation where the two are equal. Come > to think of this, I don't see why we need this last condition at all. Me neither. Since this code (in its current state) seems to mean that we never delete auto-save files when killing buffers, I think we should change the documented effect of `delete-auto-save-files' to be what it does now: ---- Non-nil means delete auto-save file when a buffer is saved. ---- Then delete the bit in `kill-buffer' that tries to act on that variable, and then introduce the new variable previously discussed in this bug report. The two things (deleting auto-save file when saving a file and killing a buffer) do not seem to be very related functionality, so having one variable for both things is just confusing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no