From: Yuchen Pei <hi@ypei.me>
To: 50195@debbugs.gnu.org
Subject: bug#50195: [PATCH] Adding diary-offset, a diary-sexp offsetting another diary-sexp.
Date: Wed, 25 Aug 2021 13:46:48 +1000 [thread overview]
Message-ID: <87fsuychjr.fsf@ypei.me> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 164 bytes --]
Hello,
See below my first patch to Emacs. The copyright assignment has
already been done BTW.
Let me know what you think. Would you like me to add some tests?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: the patch --]
[-- Type: text/x-patch, Size: 2827 bytes --]
From d385b1bc02f2922fbff4496f81d4574d0abcf082 Mon Sep 17 00:00:00 2001
From: Yuchen Pei <hi@ypei.me>
Date: Wed, 25 Aug 2021 13:37:20 +1000
Subject: [PATCH] Adding diary-offset, a diary-sexp offsetting another
diary-sexp.
A bit like diary-remind, as a diary-sexp rather than reminder, and
also support both positive and negative offsets.
This is useful when for example your organization has a committee
meeting two days after every monthly meeting which takes place on the
third Thursday, or if you would like to attend a virtual meeting
scheduled in a different timezone causing a difference in the date.
---
doc/emacs/calendar.texi | 14 ++++++++++++++
lisp/calendar/diary-lib.el | 11 +++++++++++
2 files changed, 25 insertions(+)
diff --git a/doc/emacs/calendar.texi b/doc/emacs/calendar.texi
index 3750e78e70..44766c92de 100644
--- a/doc/emacs/calendar.texi
+++ b/doc/emacs/calendar.texi
@@ -1363,6 +1363,20 @@ Special Diary Entries
Thursday of January, February, and March. If the month is @code{t}, the
entry applies to all months of the year.
+@findex diary-offset
+@example
+%%(diary-offset '(diary-float t 3 4) 2) Monthly post-event committee meeting
+@end example
+
+@noindent
+This entry applies to the Saturday after the third Thursday of each
+month. The 2 specifies number of days after when the sexp
+@samp{'(diary-float t 3 4)} would evaluate to @code{t}. This is
+useful when for example your organization has a committee meeting two
+days after every monthly meeting which takes place on the third
+Thursday, or if you would like to attend a virtual meeting scheduled
+in a different timezone causing a difference in the date.
+
Each of the standard sexp diary entries takes an optional parameter
specifying the name of a face or a single-character string to use when
marking the entry in the calendar. Most generally, sexp diary entries
diff --git a/lisp/calendar/diary-lib.el b/lisp/calendar/diary-lib.el
index f57fe26058..d83a60680f 100644
--- a/lisp/calendar/diary-lib.el
+++ b/lisp/calendar/diary-lib.el
@@ -2014,6 +2014,17 @@ diary-cyclic
(and (>= diff 0) (zerop (% diff n))
(cons mark (format entry cycle (diary-ordinal-suffix cycle))))))
+;; To be called from diary-sexp-entry, where DATE, ENTRY are bound.
+(defun diary-offset (sexp days)
+ "Offsetted diary entry.
+Entry applies if the date is DAYS days after another diary-sexp SEXP."
+ (with-no-warnings (defvar date) (defvar entry))
+ (integerp days)
+ (let ((date
+ (calendar-gregorian-from-absolute
+ (- (calendar-absolute-from-gregorian date) days))))
+ (eval sexp)))
+
(defun diary-day-of-year ()
"Day of year and number of days remaining in the year of date diary entry."
(with-no-warnings (defvar date))
--
2.33.0
[-- Attachment #1.3: Type: text/plain, Size: 131 bytes --]
--
Best,
Yuchen
PGP Key: 47F9 D050 1E11 8879 9040 4941 2126 7E93 EF86 DFD0
<https://ypei.me/assets/ypei-pubkey.txt>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 243 bytes --]
next reply other threads:[~2021-08-25 3:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 3:46 Yuchen Pei [this message]
2021-08-25 11:31 ` bug#50195: [PATCH] Adding diary-offset, a diary-sexp offsetting another diary-sexp Lars Ingebrigtsen
2021-08-25 11:52 ` Eli Zaretskii
2021-08-25 12:06 ` Lars Ingebrigtsen
2021-08-25 12:24 ` Eli Zaretskii
2021-08-25 12:38 ` Lars Ingebrigtsen
2021-08-25 15:22 ` Michael Heerdegen
2021-08-25 15:32 ` Michael Heerdegen
2021-08-25 16:07 ` Eli Zaretskii
2021-08-25 16:22 ` Michael Heerdegen
2021-08-26 6:52 ` Yuchen Pei
2021-08-26 9:26 ` Michael Heerdegen
2021-08-26 6:49 ` bug#50195: [PATCH] Adding diary-offset to diary-lib.el Yuchen Pei
2021-08-26 6:54 ` Yuchen Pei
2021-08-27 13:16 ` Yuchen Pei
2021-09-03 22:40 ` Yuchen Pei
2021-09-04 6:15 ` Eli Zaretskii
2021-09-04 6:29 ` Lars Ingebrigtsen
2021-09-04 7:21 ` Yuchen Pei
2021-08-26 10:26 ` bug#50195: [PATCH] Adding diary-offset, a diary-sexp offsetting another diary-sexp Michael Heerdegen
2021-08-27 13:11 ` Yuchen Pei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsuychjr.fsf@ypei.me \
--to=hi@ypei.me \
--cc=50195@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.