bug#50104: 28.0.50; 'M-o' is bound in diff-mode-map

bug#50104: 28.0.50; 'M-o' is bound in diff-mode-map

[Augusto Stoffel]

'M-o' is bound to 'diff-goto-source' in 'diff-mode-map'.  I guess this
binding should be removed, to be in line with the freeing up of 'M-o'
elsewhere.  Otherwise, a global binding to 'M-o' is overridden in diff
buffers.

Note also that there are several other bindings for that command in diff
buffers: 'RET', 'C-c C-c', etc.

(While we're at this, I'll express my opinion that, apart from leaving
'M-o' reserved for the user to customize, 'other-window' would the only
sensible use for that key.)

bug#50104: 28.0.50; 'M-o' is bound in diff-mode-map

[Juri Linkov]

> 'M-o' is bound to 'diff-goto-source' in 'diff-mode-map'.  I guess this
> binding should be removed, to be in line with the freeing up of 'M-o'
> elsewhere.  Otherwise, a global binding to 'M-o' is overridden in diff
> buffers.

The standard key to display a buffer in another window is 'C-o', not 'M-o',
like is used in list-buffers, dired, compilation, grep, occur, etc.,
so maybe diff-mode should use the same.

> Note also that there are several other bindings for that command in diff
> buffers: 'RET', 'C-c C-c', etc.
>
> (While we're at this, I'll express my opinion that, apart from leaving
> 'M-o' reserved for the user to customize, 'other-window' would the only
> sensible use for that key.)

For the long time, the bigger problem was to get rid of remaining 'M-s'
keybindings.  For example, it's impossible to use word search 'M-s M-w'
in log-edit buffers (where 'M-s' is bound to log-edit-comment-search-forward)
and in some other modes.

bug#50104: 28.0.50; 'M-o' is bound in diff-mode-map

[Andreas Schwab]

On Aug 18 2021, Juri Linkov wrote:

> The standard key to display a buffer in another window is 'C-o', not 'M-o',
> like is used in list-buffers, dired, compilation, grep, occur, etc.,
> so maybe diff-mode should use the same.

diff-mode is for editible buffers, so it should not override C-o.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

bug#50104: 28.0.50; 'M-o' is bound in diff-mode-map

[Lars Ingebrigtsen]

Andreas Schwab <schwab@linux-m68k.org> writes:

>> The standard key to display a buffer in another window is 'C-o', not 'M-o',
>> like is used in list-buffers, dired, compilation, grep, occur, etc.,
>> so maybe diff-mode should use the same.
>
> diff-mode is for editible buffers, so it should not override C-o.

Yup.

I grepped through Emacs to see whether other modes also define `M-o'...
and there's a handful that do.  I think it would be pretty annoying to
change these bindings (for users), so I think we should just leave
them as is, even though that means that any new global bindings for
`M-o' are shadowed in those buffers.

I don't think we've guaranteed anything about not using `M-o' for
anything in-tree.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#50104: 28.0.50; 'M-o' is bound in diff-mode-map

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I grepped through Emacs to see whether other modes also define `M-o'...
> and there's a handful that do.  I think it would be pretty annoying to
> change these bindings (for users), so I think we should just leave
> them as is, even though that means that any new global bindings for
> `M-o' are shadowed in those buffers.
>
> I don't think we've guaranteed anything about not using `M-o' for
> anything in-tree.

So I think the conclusion here is that we're not going to change these
`M-o' bindings, and I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no