From: Lars Ingebrigtsen <larsi@gnus.org>
To: Jeremy Friesen <jeremy.n.friesen@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Adding more tags for SHR
Date: Fri, 27 Aug 2021 02:17:59 +0200 [thread overview]
Message-ID: <87fsuvu4eg.fsf@gnus.org> (raw)
In-Reply-To: <CALSSkZtustOJsuMQNxJOR33MFX_-+cfsAwAPQcYa3UpGyoj1Dw@mail.gmail.com> (Jeremy Friesen's message of "Thu, 26 Aug 2021 17:19:12 -0400")
Jeremy Friesen <jeremy.n.friesen@gmail.com> writes:
> Attached is a patch for more rendering options for SHR.
Thanks; looks great!
A couple very minor comments:
> +(defcustom shr-before-q-tag "“"
> + "Before quote used for q-tag.
Perhaps it'd be best to default this to nil and then do something along
the lines of
(shr-insert (or shr-before-q-tag
(if (char-displayable-p ?“) ?“ ?\")))
in -tag-q to ensure that the default is displayable everywhere.
> +(defun shr-tag-time (dom)
> + (when-let* ((datetime (or
Misindented?
This change is larger than what we can apply without getting a copyright
assignment for the FSF.
https://www.gnu.org/licenses/why-assign.en.html
Are you willing to sign such paperwork? If so, here's the paperwork to
get started.
Please email the following information to assign@gnu.org, and we
will send you the assignment form for your past and future changes.
Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES
[What is the name of the program or package you're contributing to?]
Emacs
[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]
[Do you have an employer who might have a basis to claim to own
your changes? Do you attend a school which might make such a claim?]
[For the copyright registration, what country are you a citizen of?]
[What year were you born?]
[Please write your email address here.]
[Please write your postal address here.]
[Which files have you changed so far, and which new files have you written
so far?]
next prev parent reply other threads:[~2021-08-27 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 21:19 Adding more tags for SHR Jeremy Friesen
2021-08-27 0:17 ` Lars Ingebrigtsen [this message]
2021-08-27 1:13 ` Jeremy Friesen
2021-08-27 1:21 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsuvu4eg.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=jeremy.n.friesen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.