From: Augusto Stoffel <arstoffel@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 49822@debbugs.gnu.org
Subject: bug#49822: [PATCH] python-shell-send functions show no output
Date: Fri, 03 Sep 2021 10:02:18 +0200 [thread overview]
Message-ID: <87fsumjddh.fsf_-_@gmail.com> (raw)
In-Reply-To: <87o89hinkv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 28 Aug 2021 17:41:20 +0200")
On Sat, 28 Aug 2021 at 17:41, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Yes, it might be a good idea to raise this topic on emacs-devel and see
> if there's any feedback.
Okay, nobody chimed in on this thread (and I think I forgot to mention
it in emacs-devel), but this patch works well for me so far. So I would
suggest to merge it.
>
> Some minor comments on the patch:
>
>> +(defvar python-shell-eval-setup-code
>> + "\
>> +def __PYTHON_EL_eval(source, filename):
>> + import ast, sys
>> + if sys.version_info[0] == 2:
>> + from __builtin__ import compile, eval, globals
>
> I think it might be a better long-term maintenance solution to put the
> Python code here (and from `python-shell-completion-native-setup') into
> a .py file under etc (for instance in a new "python-mode"
> sub-directory), and then read it in run-time (accessed via
> `data-directory', which points to etc), and cache it in an internal
> variable.
>
> Editing Python that's inside a Lisp string is awkward.
Yes, that makes sense. On the other hand, it would make the entire
setup a bit more complicated, and I'm unsure about some of the details.
I do want to refactor `python-shell-send-file', though, so that at least
it doesn't generate Python code strings on the fly (and at the same time
solve the remaining part of Bug#32042).
next prev parent reply other threads:[~2021-09-03 8:02 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210903122828.16890.65271@vcs0.savannah.gnu.org>
[not found] ` <20210903122829.EAAC220B71@vcs0.savannah.gnu.org>
2021-09-03 23:04 ` master e32c7d2: Change Python eval to send directly instead of using temporary files Stefan Monnier
2021-09-04 9:49 ` bug#49822: " Augusto Stoffel
2021-09-04 13:52 ` Stefan Monnier
2021-09-04 13:52 ` bug#49822: " Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-05 6:13 ` Barton, Mark
2021-09-05 7:46 ` bug#49822: " Augusto Stoffel
2021-09-05 8:10 ` Augusto Stoffel
2021-09-05 17:18 ` bug#49822: " Mark Barton
2021-09-05 17:33 ` Mark Barton
2021-09-05 17:46 ` Augusto Stoffel
2021-09-05 17:46 ` bug#49822: " Augusto Stoffel
2021-09-05 8:10 ` Augusto Stoffel
2021-09-05 6:13 ` Barton, Mark
2021-09-05 7:41 ` bug#32042: " Lars Ingebrigtsen
2021-09-05 7:41 ` Lars Ingebrigtsen
2021-09-05 7:41 ` Lars Ingebrigtsen
2021-09-05 16:36 ` Andreas Schwab
2021-09-05 18:40 ` Augusto Stoffel
2021-09-06 7:43 ` Michael Albinus
2021-09-06 7:43 ` Michael Albinus
2021-09-06 8:40 ` Andreas Schwab
2021-09-06 11:23 ` Michael Albinus
2021-09-06 11:53 ` Andreas Schwab
2021-08-02 14:32 ` bug#49822: 28.0.50; python-shell-send functions show no output dalanicolai
2021-08-02 15:11 ` bug#49822: forgot link (and mentioned wrong user) dalanicolai
2021-08-02 15:17 ` bug#49822: 28.0.50; python-shell-send functions show no output Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-04 7:18 ` Lars Ingebrigtsen
2021-08-05 10:03 ` dalanicolai
2021-08-12 14:57 ` Augusto Stoffel
2021-08-13 11:10 ` Lars Ingebrigtsen
2021-08-13 16:44 ` Andreas Röhler
2021-08-14 9:29 ` Augusto Stoffel
2021-08-15 6:41 ` Andreas Röhler
2021-08-26 8:27 ` Augusto Stoffel
2021-08-26 14:09 ` Lars Ingebrigtsen
2021-08-28 9:28 ` bug#49822: [RFC PATCH] " Augusto Stoffel
2021-08-28 15:41 ` Lars Ingebrigtsen
2021-09-03 8:02 ` Augusto Stoffel [this message]
2021-09-03 12:28 ` bug#49822: [PATCH] " Lars Ingebrigtsen
2021-09-06 22:15 ` bug#49822: master e32c7d2: Change Python eval to send directly instead of using temporary files Andy Moreton
2021-09-07 7:18 ` Andreas Schwab
2021-09-06 12:00 ` Michael Albinus
2021-09-06 16:08 ` Augusto Stoffel
2021-09-06 16:08 ` Augusto Stoffel
2021-09-07 17:37 ` Augusto Stoffel
2021-09-07 17:48 ` Eli Zaretskii
2021-09-07 17:48 ` Eli Zaretskii
2021-09-07 17:59 ` Augusto Stoffel
2021-09-07 18:19 ` Eli Zaretskii
2021-09-07 17:59 ` Augusto Stoffel
2021-09-07 18:13 ` Augusto Stoffel
2021-09-07 18:13 ` Augusto Stoffel
2021-09-07 18:31 ` Eli Zaretskii
2021-09-07 18:31 ` Eli Zaretskii
2021-09-07 19:00 ` Augusto Stoffel
2021-09-07 19:16 ` Eli Zaretskii
2021-09-07 19:16 ` Eli Zaretskii
2021-09-08 7:02 ` Michael Albinus
2021-09-08 7:02 ` Michael Albinus
2021-09-08 3:17 ` Barton, Mark
2021-09-08 5:09 ` Augusto Stoffel
2021-09-08 7:50 ` Lars Ingebrigtsen
2021-09-08 14:05 ` Augusto Stoffel
2021-09-09 13:48 ` Lars Ingebrigtsen
2021-09-08 14:05 ` Augusto Stoffel
2021-09-08 7:50 ` Lars Ingebrigtsen
2021-09-06 11:23 ` Michael Albinus
2021-09-06 8:40 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsumjddh.fsf_-_@gmail.com \
--to=arstoffel@gmail.com \
--cc=49822@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.