From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: miha--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48925: [PATCH] Set `minibuffer-completion-*` variables buffer-locally in a few more places Date: Thu, 11 Nov 2021 17:50:33 +0100 Message-ID: <87fss2hc12.fsf@miha-pc> References: <87fsxstdiy.fsf@miha-pc> <87czn79smi.fsf@gnus.org> <87mtmbgehx.fsf@miha-pc> <83lf1v0w6y.fsf@gnu.org> <871r3m7uzl.fsf@gnus.org> <83h7ci22ve.fsf@gnu.org> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16845"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 48925@debbugs.gnu.org To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 11 17:47:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlDEE-0004Bh-W4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 17:47:11 +0100 Original-Received: from localhost ([::1]:56922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlDED-0003mW-0g for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 11:47:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlDE6-0003mJ-P1 for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 11:47:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58790) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlDE6-0007qt-Gc for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 11:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlDE6-0001P1-4S for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 11:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Nov 2021 16:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48925 X-GNU-PR-Package: emacs Original-Received: via spool by 48925-submit@debbugs.gnu.org id=B48925.16366491855343 (code B ref 48925); Thu, 11 Nov 2021 16:47:02 +0000 Original-Received: (at 48925) by debbugs.gnu.org; 11 Nov 2021 16:46:25 +0000 Original-Received: from localhost ([127.0.0.1]:42103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlDDV-0001O6-0m for submit@debbugs.gnu.org; Thu, 11 Nov 2021 11:46:25 -0500 Original-Received: from kamnitnik.top ([209.250.245.214]:46192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlDDH-0001Nj-2o for 48925@debbugs.gnu.org; Thu, 11 Nov 2021 11:46:23 -0500 Original-Received: from localhost (BSN-77-156-43.static.siol.net [193.77.156.43]) by kamnitnik.top (Postfix) with ESMTPSA id 9A5E99CFAE; Thu, 11 Nov 2021 16:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kamnitnik.top; s=mail; t=1636649169; bh=RhxsdcRoHoVfNcPZIjyWcGQRqqPnu16U6w5M43WEpVI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lMguU6u7/RtEcJmhoEzGztCpvjc5JFBM1+sMwACrfEb1OR78hfXbhq3t47Q9j32uU CI4lYKmxPCcWclh9hSaWcxFkb8xYnhyJ2vHD6jj022GoZykhHKYBmkrYHSw0D77tNV dRhfUJrQzhD+giOiff8bXxeg27yKUqmIF7wrNHNopi09Nmjk7MBvrtrmkmYtSqzNfO CiRy6SHif4OFHlUddgx5RwlR/lamWi2SfXE8+2ytN167dmqf8tGqRQYxsgTU57LuVr hjGD7ILu07a4XZ033q7hak4UEbVrGCspRf8HN4wh+3jzs/n0R+hyEK6gCnBR1lUErM hOWWWxLaJE+bA== In-Reply-To: <83h7ci22ve.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219652 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: Lars Ingebrigtsen >> Cc: , monnier@iro.umontreal.ca, 48925@debbugs.gnu.= org >> Date: Thu, 11 Nov 2021 13:11:10 +0100 >>=20 >> Eli Zaretskii writes: >>=20 >> > Moving read-string to subr.el means the function will be unavailable >> > during loadup until subr.elc is loaded. >>=20 >> That's a worry, so I tried Miha's patch now and did both a "make" and a >> "make bootstrap", and both completed without any problems. > > I didn't say it will be a problem now. But it's a time bomb waiting > to go off. So I'd like to see if we could still do this in C. In that case, my personal opinion is that it's okay to leave it as is and close this bug. The specbinding in `read-string' isn't a very big problem. The only problematic case I can think of is quite specific: the user runs a function that let-binds `minibuffer-completion-table' around a call to `read-from-minibuffer' (this is the old convention, the new convection is to set the completion table buffer locally), and then recursively uses `read-string' during this minibuffer session on a separate frame with `minibuffer-follows-selected-frame' customized to nil. Completion commands will now not work in the outer minibuffer. IMO, it's not really worth trying too hard to figure out a way to fix this very specific issue in C. One simple solution would be to introduce a new optional argument to `read-from-minibuffer', a function that would be run in the minibuffer as an alternative to minibuffer-with-setup-hook. I believe Stefan M. proposed something like this, but this should probably be discussed more thoroughly. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAEBCAAxFiEEmxVnesoT5rQXvVXnswkaGpIVmT8FAmGNSdkTHG1paGFAa2Ft bml0bmlrLnRvcAAKCRCzCRoakhWZP93EEACZGd+bjGXbX8d9NLo41Y5Ew7KuaCPi n8C+2YpM0tSisOcytaxp7GP7xxz7t0OKREGm/ifBuaBIM0naZ/8YWScfQahMLTRv u8ATDa9LOfmDk2iufnYA/OgNMJ8L+BCWCmUB6WHNR/dSQgwKbE97jhfEQL5LlOwW waOXP4WLEYwvChQK6j0tWygByJu5BY3ScIa2/ydlfD6c6YteF1ge6KkZlqDvv0Hi Bt7/P2xKVdip8M0/TxYzS4FifuP3nLCA4nfp9ZGxgF1LkOUOU45k4va12ECYxwML l2cPRf652KyNXYQBtzCdomBpVl0wzJxxcBe22745Y+n/sA3tVv0BBwBP9buYd/2n QrYJbJ1om5DjRozvvdrXI50U9HrobvqU4lileSVo8VvmwkZJhqEnoFQgCQ4OPQeq b5tf2vmcYo+pyuwrBNoPrtBNw5Q2U9CNQLOpfQEO0JcxwB73LxiwXt9OWcwswUFC 5fKoodemNJKdCpAxWYeNXg698lZJl2wLV+RTWaTkNJ2mdNdkd5Ch0xdAmFCe7oZr Ou2TvVVTFf0ruHgbeOTfNv2MrWty1MMnLZrh7tfog5gozlK97cp/TAkfqTMMEjHb BER2fuijLMAPJH9JnA4HDCKeZRAh0/HqV74vMAykqG/Rp2jNkMdC7QDknYzam6mw 8dt4LAzyyzuK8w== =XIbd -----END PGP SIGNATURE----- --=-=-=--