From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.bugs Subject: bug#50572: 28.0.50; [PATCH] fix VC to find the responsible backend with the most specific path. Date: Fri, 12 Nov 2021 16:09:57 +0100 Message-ID: <87fss1quka.fsf@elite.giraud> References: <877dfkxyt4.fsf@elite.giraud> <87cznef8ah.fsf@gnus.org> <86ilx5iaze.fsf@gmail.com> <87pmrdb0zv.fsf@gnus.org> <86mtmgx6gg.fsf@gmail.com> <87fe707b-f2b4-febd-d2ae-acc697b4cee1@yandex.ru> <87zgqgjeaz.fsf@gnus.org> <87cznbt2r1.fsf@elite.giraud> <87h7cn803w.fsf@gnus.org> <878rxzszl8.fsf@elite.giraud> <877ddiuhv7.fsf@gnus.org> <87y25x3e6g.fsf@elite.giraud> <87a6icoqkm.fsf@gnus.org> <87k0hditw7.fsf@elite.giraud> <83a6i9ziiq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36285"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: 50572@debbugs.gnu.org, larsi@gnus.org, andrewjmoreton@gmail.com, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 12 16:23:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlYOc-0009H3-AD for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Nov 2021 16:23:18 +0100 Original-Received: from localhost ([::1]:46258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlYOb-00057B-BY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Nov 2021 10:23:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlYCl-0006Vc-1X for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2021 10:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34181) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlYCk-0007Gg-Ob for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2021 10:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlYCk-0005CZ-KK for bug-gnu-emacs@gnu.org; Fri, 12 Nov 2021 10:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Nov 2021 15:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50572 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50572-submit@debbugs.gnu.org id=B50572.163672980419911 (code B ref 50572); Fri, 12 Nov 2021 15:11:02 +0000 Original-Received: (at 50572) by debbugs.gnu.org; 12 Nov 2021 15:10:04 +0000 Original-Received: from localhost ([127.0.0.1]:45727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlYBn-0005B5-Py for submit@debbugs.gnu.org; Fri, 12 Nov 2021 10:10:03 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:16018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlYBl-0005Aa-AU for 50572@debbugs.gnu.org; Fri, 12 Nov 2021 10:10:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=PPKtzW3yVwavLrEV EHZTUD9V8G0kIBHOkO/an3UA3kE=; h=in-reply-to:date:references:subject: cc:to:from; d=ledu-giraud.fr; b=mRaJUhM0gEAKRWodoR7jbti4GxDhSO1U4IQ7Zq vbF1n33rWToAS6KqpRsKvM1cF9Hz/4t97JAV0N8K4eer7IaMuwLAugjBNb2AjTw7e9Grhz xJWt02yxMssSZgR5Emuovz6FpCKZxpdIsgjdrTcFjocbLQpVoVgsF481nxLpG83BK8fTSa UufXZqV9OPlg0C62st/4QWE3BRwKS3vxNy8ZkXW4VV0FX+FbOlTNxG8i9qdjBX/qXIHCTp uuCUnjaDhhqVVY0JCrekVLcY4B/7Y88mJ5RIkxceVwvanKafFrEcHvidfkkPRVO/O+ZFFc I5tsJFliDrNRyy2NA/0b4RuA== Original-Received: from elite.giraud (82-65-148-221.subs.proxad.net [82.65.148.221]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 08656e5c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 12 Nov 2021 16:09:59 +0100 (CET) In-Reply-To: <83a6i9ziiq.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Nov 2021 14:05:17 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219777 Archived-At: Eli Zaretskii writes: [...] >> diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el >> index 4b56f1b795..b8f0425393 100644 >> --- a/lisp/vc/vc.el >> +++ b/lisp/vc/vc.el >> @@ -945,7 +945,7 @@ vc-backend-for-registration >> (dolist (backend vc-handled-backends) >> (when (not (vc-call-backend backend 'registered file)) >> (let* ((path (vc-call-backend backend 'responsible-p file)) >> - (len (length path))) >> + (len (and path (length (file-name-split path))))) >> (when (and len (> len max)) >> (setq max len bk backend))))) >> (when bk > > Please don't use "path" for anything that is not PATH-style directory > lists. Ok but I have hard time figuring out what would be a correct name here because (vc-call-backend backend 'responsible-p file) returns a path (or nil) if the backend is responsible. Does "path-string" will do? > Also, shouldn't the file name(s) be run through expand-file-name, to > make sure they are absolute? Otherwise comparing the length will not > DTRT. Ok, I'll do this but I'll also need a new name here (in case of a nil returned by vc-call-backend): "expanded-path-string" ? -- Manuel Giraud