From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thuna Newsgroups: gmane.emacs.bugs Subject: bug#53520: [PATCH] tabulated-list gradually truncate image Date: Tue, 25 Jan 2022 17:02:21 +0300 Message-ID: <87fspb3ocy.fsf@gmail.com> References: <87sftc2nel.fsf@gmail.com> <87wniovswv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33736"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53520@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 25 15:46:50 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCN5u-0008c4-Gj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jan 2022 15:46:50 +0100 Original-Received: from localhost ([::1]:43166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCN5t-0003rg-Eo for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jan 2022 09:46:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCMPW-0003oC-Re for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 09:03:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54593) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nCMPW-0003Ok-D7 for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 09:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nCMPW-0008QV-9A for bug-gnu-emacs@gnu.org; Tue, 25 Jan 2022 09:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thuna Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jan 2022 14:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53520 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53520-submit@debbugs.gnu.org id=B53520.164311935532355 (code B ref 53520); Tue, 25 Jan 2022 14:03:02 +0000 Original-Received: (at 53520) by debbugs.gnu.org; 25 Jan 2022 14:02:35 +0000 Original-Received: from localhost ([127.0.0.1]:47495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCMP4-0008Pn-M7 for submit@debbugs.gnu.org; Tue, 25 Jan 2022 09:02:34 -0500 Original-Received: from mail-ed1-f48.google.com ([209.85.208.48]:43820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCMP0-0008Ib-7g for 53520@debbugs.gnu.org; Tue, 25 Jan 2022 09:02:32 -0500 Original-Received: by mail-ed1-f48.google.com with SMTP id w14so10035768edd.10 for <53520@debbugs.gnu.org>; Tue, 25 Jan 2022 06:02:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=CY15TWF8MNExWIqZrs3A6mOa7SIhXXPRy3wVJY6Jn9o=; b=mjmNxoeTFlYlwgXRYgfcSMuDdVCMebf4KDwI8e1/bohlhHm8vb5j6IzLBTQb9lqsDP 8copw3Kdh9dvNmAYy/UP88Bri8CJXA2llT8//hzkg6JFI4sm6I54raM/xmq7QoIVjlFO Rj9f9k18iA7gg1VX+F4P0+gxcx4v508MjaRxAWT2Q8PQ2GNulI9MYbQiAN6aK8r98W8h xruUnjfYyKuUSU5qt0lvSdAat9h8psd5ZiLInuQhrO0FgOnwm5K9bN3I5d0vx3KyN0OU UsxQqHnzQS3DyY2hnk3dnLycUdKyZq6dtDRgJboRF72U/W4BeDvKT3Vifef8MYf/LOfk m1WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=CY15TWF8MNExWIqZrs3A6mOa7SIhXXPRy3wVJY6Jn9o=; b=O3Z5bTxMsk0oRZJawv3PltVE+IMMTTibwU04ljDZW0lntsEfsm4/X0sZ16CGb3YWFJ CM2OY80VdLdAUdQKlqqxwLMJvKVrghFWpJL/Ii7UmmC7VyUwkEaJloSp7yreb3YBfroE hthrzlLZf61XEaNTJZ6Qie7oaR53jHEm4Ov0ctslgTLaCAsLKrT8vZrZoETK6wlXgCKt HOjhSr/H3ybtz5BaHKq1mrKc5U60ge2YlxfPE/dKr2bQxWTgr/FNvZ2adCmhaOlkSDgC UFmGieBFpeY8lhYHIUHXCoWV1wbaERUAFC54DChHOAEl6NvFUa5BdO86BaF2crK+3Bpw LI+w== X-Gm-Message-State: AOAM532lFVREJFOBXfY81OxqA2jTP2g7N+d4r0yq9+j4BKAx0J5ocuo4 9RXVN79pEWaTr1jZ9UCsFfOLTPKH+d0= X-Google-Smtp-Source: ABdhPJw3ND7OEohqGRj2r0r6KIMTraqvw9cwUf77EWYkfGKbV7GlPSDgBxY9tI5RmkMRMr6XgDjJzg== X-Received: by 2002:a17:907:90d5:: with SMTP id gk21mr3385055ejb.297.1643119343833; Tue, 25 Jan 2022 06:02:23 -0800 (PST) Original-Received: from Thuna ([78.161.73.233]) by smtp.gmail.com with ESMTPSA id gg14sm6231256ejb.159.2022.01.25.06.02.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 06:02:22 -0800 (PST) In-Reply-To: <87wniovswv.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225179 Archived-At: > I think it a tabulated-list caller wants to insert images into the > table, they should ensure that the width of the image is appropriate for > the column. Considering the width of a column can be changed arbitrarily by the user is it not expected for tabulated-list to handle images in a way that works for all widths? > And as you say, this only chops off the parts of the image -- I think > it's more likely that a caller would want to set the width with > :max-width or the like. I do not wholly disagree that the current strategy of slicing the image may not be the ideal solution for all situations, however is it not better to handle images even if done poorly (which I would argue is not the case) than it is to not handle them altogether? Other methods of (yet unimplemented) resizing an image include scaling it down and hiding it when it doesn't fit. All of these methods have their use cases and it should be relatively simple to introduce a variable that controls which one is used.