* Re: master b8a96f0556 4/4: Port pre-commit hook to Git 2.35.0 [not found] ` <20220223194141.A2AFEC00894@vcs2.savannah.gnu.org> @ 2022-02-24 8:48 ` Robert Pluim 2022-02-24 18:23 ` Paul Eggert 0 siblings, 1 reply; 6+ messages in thread From: Robert Pluim @ 2022-02-24 8:48 UTC (permalink / raw) To: emacs-devel; +Cc: Paul Eggert >>>>> On Wed, 23 Feb 2022 14:41:40 -0500 (EST), Paul Eggert <eggert@cs.ucla.edu> said: Paul> branch: master Paul> commit b8a96f055624f86fe965a0d1b7b2495b2db80e63 Paul> Author: Paul Eggert <eggert@cs.ucla.edu> Paul> Commit: Paul Eggert <eggert@cs.ucla.edu> Paul> Port pre-commit hook to Git 2.35.0 Paul> * build-aux/git-hooks/pre-commit: Use LC_ALL=C grep -E instead of Paul> sane_egrep (removed in Git 2.35.0). Is it worth putting this in emacs-28? Robert -- ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master b8a96f0556 4/4: Port pre-commit hook to Git 2.35.0 2022-02-24 8:48 ` master b8a96f0556 4/4: Port pre-commit hook to Git 2.35.0 Robert Pluim @ 2022-02-24 18:23 ` Paul Eggert 2022-02-28 15:47 ` Robert Pluim 0 siblings, 1 reply; 6+ messages in thread From: Paul Eggert @ 2022-02-24 18:23 UTC (permalink / raw) To: Robert Pluim, emacs-devel On 2/24/22 00:48, Robert Pluim wrote: > Is it worth putting this in emacs-28? Yes, if people plan to commit to emacs-28 with Git 2.35.0 or later and don't want to see annoying/puzzling diagnostics about "sane_egrep" being missing. (Git 2.35.0 was released last month.) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master b8a96f0556 4/4: Port pre-commit hook to Git 2.35.0 2022-02-24 18:23 ` Paul Eggert @ 2022-02-28 15:47 ` Robert Pluim 2022-02-28 16:49 ` Eli Zaretskii 0 siblings, 1 reply; 6+ messages in thread From: Robert Pluim @ 2022-02-28 15:47 UTC (permalink / raw) To: Paul Eggert; +Cc: emacs-devel [-- Attachment #1: Type: text/plain, Size: 569 bytes --] >>>>> On Thu, 24 Feb 2022 10:23:48 -0800, Paul Eggert <eggert@cs.ucla.edu> said: Paul> On 2/24/22 00:48, Robert Pluim wrote: >> Is it worth putting this in emacs-28? Paul> Yes, if people plan to commit to emacs-28 with Git 2.35.0 or later and Paul> don't want to see annoying/puzzling diagnostics about "sane_egrep" Paul> being missing. (Git 2.35.0 was released last month.) Well, Iʼm about to do that by cherry-picking this to emacs-28, so thatʼs at least one instance :-) Eli, is the following OK for emacs-28? Robert -- [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-Backport-Port-pre-commit-hook-to-Git-2.35.0.patch --] [-- Type: text/x-diff, Size: 1166 bytes --] From c773ebe260c72207f004026560ffe65148a2c26d Mon Sep 17 00:00:00 2001 From: Paul Eggert <eggert@cs.ucla.edu> Date: Wed, 23 Feb 2022 11:29:56 -0800 Subject: [PATCH] Backport: Port pre-commit hook to Git 2.35.0 To: emacs-devel@gnu.org * build-aux/git-hooks/pre-commit: Use LC_ALL=C grep -E instead of sane_egrep (removed in Git 2.35.0). (cherry picked from commit b8a96f055624f86fe965a0d1b7b2495b2db80e63) --- build-aux/git-hooks/pre-commit | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/build-aux/git-hooks/pre-commit b/build-aux/git-hooks/pre-commit index a55004680f..49bf05f2d9 100755 --- a/build-aux/git-hooks/pre-commit +++ b/build-aux/git-hooks/pre-commit @@ -45,7 +45,9 @@ git_diff= # 'git diff' will backslash escape tabs and newlines, so we don't have # to worry about word splitting here. -$git_diff $head | sane_egrep 'ChangeLog|^-|/-|[^-+./_0-9A-Z_a-z]' | while IFS= read -r new_name; do +$git_diff $head | +LC_ALL=C grep -E 'ChangeLog|^-|/-|[^-+./_0-9A-Z_a-z]' | +while IFS= read -r new_name; do case $new_name in -* | */-*) echo "$new_name: File name component begins with '-'." -- 2.35.1.291.gdab1b7905d ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: master b8a96f0556 4/4: Port pre-commit hook to Git 2.35.0 2022-02-28 15:47 ` Robert Pluim @ 2022-02-28 16:49 ` Eli Zaretskii 2022-02-28 16:54 ` Paul Eggert 0 siblings, 1 reply; 6+ messages in thread From: Eli Zaretskii @ 2022-02-28 16:49 UTC (permalink / raw) To: Robert Pluim; +Cc: eggert, emacs-devel > From: Robert Pluim <rpluim@gmail.com> > Date: Mon, 28 Feb 2022 16:47:20 +0100 > Cc: emacs-devel@gnu.org > > >> Is it worth putting this in emacs-28? > > Paul> Yes, if people plan to commit to emacs-28 with Git 2.35.0 or later and > Paul> don't want to see annoying/puzzling diagnostics about "sane_egrep" > Paul> being missing. (Git 2.35.0 was released last month.) > > Well, Iʼm about to do that by cherry-picking this to emacs-28, so > thatʼs at least one instance :-) > > Eli, is the following OK for emacs-28? Yes, I guess. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master b8a96f0556 4/4: Port pre-commit hook to Git 2.35.0 2022-02-28 16:49 ` Eli Zaretskii @ 2022-02-28 16:54 ` Paul Eggert 2022-03-01 9:02 ` Robert Pluim 0 siblings, 1 reply; 6+ messages in thread From: Paul Eggert @ 2022-02-28 16:54 UTC (permalink / raw) To: Eli Zaretskii, Robert Pluim; +Cc: emacs-devel On 2/28/22 08:49, Eli Zaretskii wrote: >> From: Robert Pluim <rpluim@gmail.com> >> Date: Mon, 28 Feb 2022 16:47:20 +0100 >> Cc: emacs-devel@gnu.org >> >> >> Is it worth putting this in emacs-28? >> >> Paul> Yes, if people plan to commit to emacs-28 with Git 2.35.0 or later and >> Paul> don't want to see annoying/puzzling diagnostics about "sane_egrep" >> Paul> being missing. (Git 2.35.0 was released last month.) >> >> Well, Iʼm about to do that by cherry-picking this to emacs-28, so >> thatʼs at least one instance :-) >> >> Eli, is the following OK for emacs-28? > > Yes, I guess. It looks good to me too; thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master b8a96f0556 4/4: Port pre-commit hook to Git 2.35.0 2022-02-28 16:54 ` Paul Eggert @ 2022-03-01 9:02 ` Robert Pluim 0 siblings, 0 replies; 6+ messages in thread From: Robert Pluim @ 2022-03-01 9:02 UTC (permalink / raw) To: Paul Eggert; +Cc: Eli Zaretskii, emacs-devel >>>>> On Mon, 28 Feb 2022 08:54:47 -0800, Paul Eggert <eggert@cs.ucla.edu> said: Paul> It looks good to me too; thanks. Done as b8bc359bbf Robert -- ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-01 9:02 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <164564529649.2580.1114329124469279209@vcs2.savannah.gnu.org> [not found] ` <20220223194141.A2AFEC00894@vcs2.savannah.gnu.org> 2022-02-24 8:48 ` master b8a96f0556 4/4: Port pre-commit hook to Git 2.35.0 Robert Pluim 2022-02-24 18:23 ` Paul Eggert 2022-02-28 15:47 ` Robert Pluim 2022-02-28 16:49 ` Eli Zaretskii 2022-02-28 16:54 ` Paul Eggert 2022-03-01 9:02 ` Robert Pluim
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.