From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] completions-max-height Date: Tue, 08 Mar 2022 07:13:13 +0200 Message-ID: <87fsntvxg6.fsf@protesilaos.com> References: <20220307210740.veiocemir46mmerk.ref@Ergus> <20220307210740.veiocemir46mmerk@Ergus> <87v8wpxvkj.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14499"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.35 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Philip Kaludercic , Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 08 06:14:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nRSAg-0003ZT-St for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Mar 2022 06:14:06 +0100 Original-Received: from localhost ([::1]:45826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRSAf-0008EA-BG for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Mar 2022 00:14:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRSA0-0007ZW-Lg for emacs-devel@gnu.org; Tue, 08 Mar 2022 00:13:24 -0500 Original-Received: from [2001:4b98:dc4:8::227] (port=34729 helo=relay7-d.mail.gandi.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRS9x-00041Z-Uk for emacs-devel@gnu.org; Tue, 08 Mar 2022 00:13:24 -0500 Original-Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id 61CCF20002; Tue, 8 Mar 2022 05:13:14 +0000 (UTC) In-Reply-To: <87v8wpxvkj.fsf@posteo.net> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4b98:dc4:8::227 (failed) Received-SPF: none client-ip=2001:4b98:dc4:8::227; envelope-from=info@protesilaos.com; helo=relay7-d.mail.gandi.net X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286914 Archived-At: On 2022-03-07, 22:10 +0000, Philip Kaludercic wrote: > Ergus writes: > >> Hi: >> >> Do you think that this may be added to vanilla? > > IMO it would be better if this could be generalised to something like > completion-display-buffer-action, so that you can decide where and how > the completion buffer is displayed. Though I am uncertain if this might > have unintended side effects, as the behaviour seems to have been > hard-coded for a while. I agree with Philip. Or go a step further and just let the Completions behave like other buffers so the user can contol its placement and parameters via the display-buffer-alist. -- Protesilaos Stavrou https://protesilaos.com