From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master fbf2ed9a64: ipv6 addresses aren't suspicious Date: Tue, 29 Mar 2022 17:55:48 +0200 Message-ID: <87fsn0sqgr.fsf@gmail.com> References: <164856675431.14395.6880987976231300914@vcs2.savannah.gnu.org> <20220329151234.93102C01684@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9870"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 29 17:57:23 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZEDg-00026p-AA for ged-emacs-devel@m.gmane-mx.org; Tue, 29 Mar 2022 17:57:20 +0200 Original-Received: from localhost ([::1]:35288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZEDf-0003bV-5t for ged-emacs-devel@m.gmane-mx.org; Tue, 29 Mar 2022 11:57:19 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZECH-0001aG-8Q for emacs-devel@gnu.org; Tue, 29 Mar 2022 11:55:54 -0400 Original-Received: from [2a00:1450:4864:20::42a] (port=36428 helo=mail-wr1-x42a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZECF-0004rd-Ow for emacs-devel@gnu.org; Tue, 29 Mar 2022 11:55:52 -0400 Original-Received: by mail-wr1-x42a.google.com with SMTP id u3so25519244wrg.3 for ; Tue, 29 Mar 2022 08:55:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version; bh=Pb1jAVN9rWd7pAULA3lOeEUjimgSaeJqkzK5HDKIr4Q=; b=k7qJC63NpyyX7PCopcd49P5dE9gPUvGEWmMsa3VyY9tReMXcfTiAaIWjvnDcifdbur l8pnAKjs44ND2OkfyRAwBYORup5fRwgglkELJxdwS24QSO+OanCDGs1S4kfbreg1nuhb HoIYy/2kQkQT/+iqj5uUKprl9WGZob75fNXZYnov2kK6DwtEo182aTD2QYTphjV30QEr DhNtCAEvJB6FVOnpXoA7jL8yHRsvTWpH/yYyRhztC+vNl7Nfy+r11r2f+yNeB/BZ7V9X Yropkxh52mS0/gQxxMHXrDYdySOxUe1NWBJlA1n+vdCUCr7sUqKHSo3RoRxJyBUtlOUX SMGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=Pb1jAVN9rWd7pAULA3lOeEUjimgSaeJqkzK5HDKIr4Q=; b=60LWoDmQYkjXt1RwJ+8um5ExGnLhCtknaOMtZZSpncPM7mhdocQAy/RIvsT22P7eM1 v62hmZgLO5Vh5RV+zt8TvZaFa3woX0dbB6BCBHc+EMkHwSP0OcNS3xoV7R8/Wn6WMnUH +1p3btkBr2au+GfqlUMqBYLRfpDlSua3M+As1+mr/K7TpSKQ7kvzsr+MQVq7Xnub8PnD ouoPT3jXPlOJj6vBwyORPfft/XRSRpJVYQlH7xhcMBQa7YYGOPFqBxvFu+Su5JjHTEoW wmTBN8h0yW3Qj14COjVODiSAlE4VjGcC4uVDSX/qp4BcXOkJN6fQDto68yJmxk+Cx3Bn PcLQ== X-Gm-Message-State: AOAM530TEHFA2dNvnsly9kV46anI/pjRdvB4gTrrn93roMVpRYq2xSeU WVne8KjQYzeoREWYmRoOW/qazK26ovI= X-Google-Smtp-Source: ABdhPJwdeo9dsBOTShZfFb3E70EqFLrJIPY4o7m3OFT2Zqj4YnN3AW82+J5fKpTiRLC+yvM3vaaaBg== X-Received: by 2002:adf:f946:0:b0:1f0:62c3:ea2e with SMTP id q6-20020adff946000000b001f062c3ea2emr31615517wrr.348.1648569350050; Tue, 29 Mar 2022 08:55:50 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:33bd:4493:f280:6818]) by smtp.gmail.com with ESMTPSA id v18-20020a5d5912000000b00205a7d0c6a3sm11043639wrd.69.2022.03.29.08.55.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Mar 2022 08:55:49 -0700 (PDT) Gmane-Reply-To-List: yes In-Reply-To: <20220329151234.93102C01684@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Tue, 29 Mar 2022 11:12:34 -0400 (EDT)") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42a (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42a.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287559 Archived-At: >>>>> On Tue, 29 Mar 2022 11:12:34 -0400 (EDT), Lars Ingebrigtsen said: Lars> branch: master Lars> commit fbf2ed9a648d9c0f64519900acf1574d0d74692b Lars> Author: Lars Ingebrigtsen Lars> Commit: Lars Ingebrigtsen Lars> ipv6 addresses aren't suspicious Lars> * lisp/international/textsec.el (textsec--ipvx-address-p): New Lars> function. Lars> (textsec-domain-suspicious-p): Use it to say that ipv6 addresses Lars> aren't suspicious (bug#54624). Lars> --- Lars> lisp/international/textsec.el | 12 ++++++++++++ Lars> test/lisp/international/textsec-tests.el | 11 ++++++++++- Lars> 2 files changed, 22 insertions(+), 1 deletion(-) Lars> +(defun textsec--ipvx-address-p (domain) Lars> + "Return non-nil if DOMAIN is an ipv4 or ipv6 address." Lars> + (or (string-match-p "\\`\\([0-9]\\{1,3\\}\\.?\\)\\{1,4\\}\\'" domain) Lars> + (let ((ipv6 "\\([0-9a-f]\\{0,4\\}:?\\)\\{1,8\\}")) Lars> + ;; With brackets. Lars> + (or (string-match-p (format "\\`\\[%s\\]\\'" ipv6) domain) Lars> + ;; Without. Lars> + (string-match-p (format "\\`%s\\'" ipv6) domain))))) Lars> + (textsec--ipvx-address-p ":1") => 0 but ":1" is not a valid IPv4 nor IPv6 address. Perhaps you could use `network-lookup-address-info' instead. Robert --