all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: 54844@debbugs.gnu.org
Subject: bug#54844: 29.0.50; pgtk: with --daemon, DISPLAY gets set to "wayland-0"
Date: Tue, 12 Apr 2022 09:22:00 +0800	[thread overview]
Message-ID: <87fsmjxfif.fsf@yahoo.com> (raw)
In-Reply-To: <87wnfvtq4g.fsf@melete.silentflame.com> (Sean Whitton's message of "Mon, 11 Apr 2022 11:46:23 -0700")

Sean Whitton <spwhitton@spwhitton.name> writes:

> Thank you for the patch, but unfortunately I can still reproduce the
> problem using my original recipe.

I missed something, sorry, what if you apply this in addition to the
other patch?

diff --git a/src/callproc.c b/src/callproc.c
index 0922e10f01..df673311d6 100644
--- a/src/callproc.c
+++ b/src/callproc.c
@@ -1687,6 +1687,7 @@ getenv_internal (const char *var, ptrdiff_t varlen, char **value,
   /* For DISPLAY try to get the values from the frame or the initial env.  */
   if (strcmp (var, "DISPLAY") == 0)
     {
+#ifndef HAVE_PGTK
       Lisp_Object display
 	= Fframe_parameter (NILP (frame) ? selected_frame : frame, Qdisplay);
       if (STRINGP (display))
@@ -1695,6 +1696,7 @@ getenv_internal (const char *var, ptrdiff_t varlen, char **value,
 	  *valuelen = SBYTES (display);
 	  return 1;
 	}
+#endif
       /* If still not found, Look for DISPLAY in Vinitial_environment.  */
       if (getenv_internal_1 (var, varlen, value, valuelen,
 			     Vinitial_environment))

Thanks.





  reply	other threads:[~2022-04-12  1:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-10 21:50 bug#54844: 29.0.50; pgtk: with --daemon, DISPLAY gets set to "wayland-0" Sean Whitton
2022-04-11  1:03 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-11  1:10   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-11 18:46     ` Sean Whitton
2022-04-12  1:22       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-04-12  5:21         ` Sean Whitton
2022-04-12  5:28           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsmjxfif.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=54844@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=spwhitton@spwhitton.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.