From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Package Requiring a Commit? Date: Thu, 05 May 2022 10:37:47 +0200 Message-ID: <87fsloe5a4.fsf@gnu.org> References: <87fslp7c97.fsf@posteo.net> <87ee18ifpr.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14342"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.13; emacs 29.0.50 Cc: emacs-devel@gnu.org To: Jai Flack Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 05 11:43:42 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmY1N-0003Yw-E9 for ged-emacs-devel@m.gmane-mx.org; Thu, 05 May 2022 11:43:42 +0200 Original-Received: from localhost ([::1]:49910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmY1M-0000i0-2u for ged-emacs-devel@m.gmane-mx.org; Thu, 05 May 2022 05:43:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmX7c-0005Da-HI for emacs-devel@gnu.org; Thu, 05 May 2022 04:46:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46560) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmX7X-0005xi-E1; Thu, 05 May 2022 04:46:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=r8EPXpV5ICDV/tpjy8Iye8lkSK+Xe++qfE/WnL1KtPk=; b=WR9QtiBjebhSFz MvPcc3bo5RrwETATb6OWLGfERt8qiDnIRuanarNNZz93ZjOyWanajXntspsiUn8xDc20+XZFTEDmV wJzVVDK5ptuUGW4M/AXMYXtYnpjcL9XLISBkRaTe2OPLzviu14QU2EAvadng7zij3i/ZzNdR9zT81 LW4zk4LKhGxONv3B3NxRNUzJp8bKKIBdXu8HfRi9rEy7EeNZGe0wmzht3+EbR+pcxHUGo1uhB3lqZ koJVvFZ3n4tvwHxPTLfwE35M++xivTfr/kYse4FHvBGLHjnLBQsN3s4OJAlQ9zm91czuzm+p5bhHu bLUMHzx9to/9AixyFfSQ==; Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:46117) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmX7V-0000OT-8U; Thu, 05 May 2022 04:45:58 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailauth.nyi.internal (Postfix) with ESMTP id C428527C0054; Thu, 5 May 2022 04:45:56 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 05 May 2022 04:45:56 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedugddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepud ejtdehuddvleffjeekteegvdehleehvdeufefhueekkeekhedvgfeggeffvefgnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 5 May 2022 04:45:56 -0400 (EDT) In-reply-to: <87ee18ifpr.fsf@posteo.net> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289236 Archived-At: Jai Flack writes: >> This should work, just use next version: >> >> ;; Package-Requires: ((emacs "29")) >> >> Then people running Emacs which was built recently from master will be >> able to install your package, because they're "already on 29". > > Thanks that solves one of the issues. Is there no good solution to the > other? I can imagine some users building from master for a specific > feature (say, PGTK) and then not updating. For something like "at least as new as commit XXX" Emacs would need to carry its complete commit graph with it in order to check that requirement. So it's best to just require emacs 29. I personally have no big empathy for people running outdated development snapshots [1] but if you do, it shouldn't be too hard to fail gracefully by testing for functions/variables you need using (f)boundp. Bye, Tassilo [1] Simply because during development it may happen that new things are tweaked/renamed many times until finished.