Re: master ef0546ffcd 2/3: Fix signature of `seconds-to-time'

Re: master ef0546ffcd 2/3: Fix signature of `seconds-to-time'

[Stefan Monnier]

>  ;;;###autoload
> -(defalias 'seconds-to-time 'time-convert)
> +(defun seconds-to-time (seconds &rest form)
> +  "Convert SECONDS to a proper time, like `current-time' would.
> +FORM means the same as in `time-convert'."
> +  (time-convert seconds form))

Oh, thanks.  I wonder, tho; shouldn't this just have a `seconds`
argument and no `form`, as was the case until 2018?


        Stefan

Re: master ef0546ffcd 2/3: Fix signature of `seconds-to-time'

[Po Lu]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>  ;;;###autoload
>> -(defalias 'seconds-to-time 'time-convert)
>> +(defun seconds-to-time (seconds &rest form)
>> +  "Convert SECONDS to a proper time, like `current-time' would.
>> +FORM means the same as in `time-convert'."
>> +  (time-convert seconds form))
>
> Oh, thanks.  I wonder, tho; shouldn't this just have a `seconds`
> argument and no `form`, as was the case until 2018?
>
>
>         Stefan

I'm not sure what the right thing to do here is, but feel free to make
such a change should you want to.

Thanks.

Re: master 32ab6d7105 1/3: Improve XI focus handling

[Lars Ingebrigtsen]

This (or an adjacent commit) seems to lead to this warning:

xterm.c: In function ‘xi_handle_focus_change’:
xterm.c:12564:25: warning: ‘source’ may be used uninitialized in this function [-Wmaybe-uninitialized]
12564 |       ie.device = source->name;
      |                   ~~~~~~^~~~~~

(This is with an --enable-checking build on Debian/bookworm, if that
makes a difference).

Re: master 32ab6d7105 1/3: Improve XI focus handling

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> This (or an adjacent commit) seems to lead to this warning:
>
> xterm.c: In function ‘xi_handle_focus_change’:
> xterm.c:12564:25: warning: ‘source’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> 12564 |       ie.device = source->name;
>       |                   ~~~~~~^~~~~~
>
> (This is with an --enable-checking build on Debian/bookworm, if that
> makes a difference).

If new is set, then source has been as well.  So I think this is a false
positive.

Feel free to install a change neutralizing this warning for the time
being.

Re: master 32ab6d7105 1/3: Improve XI focus handling

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> If new is set, then source has been as well.  So I think this is a false
> positive.
>
> Feel free to install a change neutralizing this warning for the time
> being.

Now done, and I agree that the warning from gcc must be wrong.