From: Ihor Radchenko <yantar92@gmail.com>
To: Duy Nguyen <ddnguyen2101@gmail.com>
Cc: Emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] Show org file title in org-clock clocktable
Date: Wed, 17 Aug 2022 17:34:02 +0800 [thread overview]
Message-ID: <87fshv1aet.fsf@localhost> (raw)
In-Reply-To: <CAM=3T04bUZ72m1cnMYg4w_A2=-CVj58HQtTuXXntxJth9URF9A@mail.gmail.com>
Duy Nguyen <ddnguyen2101@gmail.com> writes:
> Thank you once again for your comments Ihor. Please find attached a new
> patch with your comments addressed.
Thanks!
> + (let ((macros (org-macro--collect-macros)))
> + (let ((title (assoc-default "title" macros)))
It is not a good idea to call internal function (with "--" in name) from
a different file. Such functions are a subject of change without notice.
`org-macro-templates' is always initialized when Org mode is active, and
you can rely on its value.
--
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92
next prev parent reply other threads:[~2022-08-17 9:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 21:54 [Patch] Show org file title in org-clock clocktable Duy Nguyen
2022-08-13 8:00 ` Ihor Radchenko
2022-08-13 10:55 ` Duy Nguyen
2022-08-13 11:35 ` Ihor Radchenko
2022-08-15 6:40 ` [PATCH v2] " Duy Nguyen
2022-08-17 9:34 ` Ihor Radchenko [this message]
2022-08-17 18:53 ` [PATCH v3] " Duy Nguyen
2022-08-20 6:14 ` Ihor Radchenko
2022-08-21 12:06 ` Duy Nguyen
2022-08-28 8:11 ` Duy Nguyen
2022-08-28 8:33 ` Duy Nguyen
2022-08-28 11:30 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fshv1aet.fsf@localhost \
--to=yantar92@gmail.com \
--cc=Emacs-orgmode@gnu.org \
--cc=ddnguyen2101@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.