From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Sun, 11 Sep 2022 13:11:51 +0200 Message-ID: <87fsgygo7c.fsf@gnus.org> References: <875yhzmz25.fsf@posteo.net> <875yhzmj50.fsf@gnus.org> <875yhzl3a1.fsf@posteo.net> <87fsh25bso.fsf@gnus.org> <871qsil3jm.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19247"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57639@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 11 13:13:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXKu7-0004nt-Rj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Sep 2022 13:13:35 +0200 Original-Received: from localhost ([::1]:46632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXKu3-0007QX-0U for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Sep 2022 07:13:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXKtb-000793-7Q for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 07:13:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52190) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXKta-0008Mq-Tx for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 07:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oXKta-0002wo-Pz for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 07:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2022 11:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166289472311234 (code B ref 57639); Sun, 11 Sep 2022 11:13:02 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 11 Sep 2022 11:12:03 +0000 Original-Received: from localhost ([127.0.0.1]:40885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXKsc-0002v7-Kl for submit@debbugs.gnu.org; Sun, 11 Sep 2022 07:12:02 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXKsa-0002uY-Ji for 57639@debbugs.gnu.org; Sun, 11 Sep 2022 07:12:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=SaA+r/sKJLZGoUseTxqzWQ2uvSqf7rEQ4I3jeFpmCoY=; b=uTaqA5VYWF112ZyoGxYX3TS3yi X4M5tGcMXGvUolbjfaXVlxEOrzOCKQ61Q4PmT50SfsDyKus1u6vyERguIFH3HynaRjW1QfCKEDGeE uT3u7TFBLt2uypfpJQRDd+iV80/Bm+Qr5Cm9AIhXIufZiM1nIyBbiMsmBtIYniOVNeR0=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXKsS-0003cS-Bc; Sun, 11 Sep 2022 13:11:54 +0200 In-Reply-To: <871qsil3jm.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 11 Sep 2022 08:26:53 +0000") X-Now-Playing: Insides's _Euphoria_: "Relentless" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242146 Archived-At: Philip Kaludercic writes: > So we are thinking about something like a symbol property > `theme-variants' that each theme symbol may have attached. This symbol > could point to a list representing a set of alternatives. Let's say the > set might contain the theme itself (for the sake of convenience), so it > is remq'ed before we check if the set has more than one alternative. If > it does we use a modified `load-theme'-like prompt, otherwise we toggle. > I think it would also make sense to silently remove non-existent themes > automatically, in case a variant theme is not part of the same package. I think that sounds correct, but I'm not 100% sure. =F0=9F=98=80 >> And in addition, this tagging could be used for automatic dark/light OS >> changes, so it's at least three birds with one stone. > > OK, but that is a long-term plan, or do the means already exist for > detecting these kinds of changes? Code exists for both Windows and Macos in the bug tracker somewhere, but haven't been integrated yet because nobody has sat down to make a consistent interface across all the platforms. > Also, how to be distinguish between what is light and dark, and what do > we do when a theme has multiple variants? I'm not sure what you mean -- the proposal is to make the themes say whether they consider themselves to be light or dark. And I don't think a theme would have multiple dark variants.