From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jose A Ortega Ruiz Newsgroups: gmane.emacs.bugs Subject: bug#58103: [PATCH] docview: imenu access to table of contents Date: Tue, 27 Sep 2022 17:18:41 +0100 Message-ID: <87fsgczt7i.fsf@mail.jao.io> References: <87r0zxz85h.fsf@mail.jao.io> <87k05p3uf9.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26075"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58103@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 27 19:14:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odEAD-0006b3-BN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 19:14:33 +0200 Original-Received: from localhost ([::1]:35606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odEAC-0004bq-6c for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 13:14:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odDIU-00021x-Iy for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 12:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57545) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odDIU-000589-Ba for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 12:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odDIU-0003me-6d for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 12:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jose A Ortega Ruiz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Sep 2022 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58103 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58103-submit@debbugs.gnu.org id=B58103.166429553514532 (code B ref 58103); Tue, 27 Sep 2022 16:19:02 +0000 Original-Received: (at 58103) by debbugs.gnu.org; 27 Sep 2022 16:18:55 +0000 Original-Received: from localhost ([127.0.0.1]:56623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odDIN-0003mJ-IA for submit@debbugs.gnu.org; Tue, 27 Sep 2022 12:18:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odDIK-0003m3-HR for 58103@debbugs.gnu.org; Tue, 27 Sep 2022 12:18:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odDIE-00056v-Ld; Tue, 27 Sep 2022 12:18:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Qvput9Jwgm9B/tEXlEKV4OAtIKv46yn0RsEtq0duM28=; b=jZWgfAz79965LYjZOwa0 UiiuKODRdGcGVCVqZJ8r3DGzPqWe+xX3tyOHdEKFkBSLzEHRZQTodEZ37CWEdWU5JJoY9FfrtWG/4 WPrhBuoOeRmmBo06Qkg45TEyZGzUbfMNCIm09wPrvfgtk+DpUL7tXRWGPoFU1/RP9ko4Oh8h6saa/ f9NETOB6jxQKhQYYew7T8WKEXwZwdVFMzx6nab6A2+Ro3FGH9j/YqRSCOKi2k9P/1xt58UVMAcupm i0L7NwdWKfZb1S7yRPZY4xfq3NIScBlPY7Z2gNAIa389tcGuKHKCAO4BZzUD7VKzX1w5ssmXXh5Ex XQaU+cSQqc3tXg==; Original-Received: from cpc103048-sgyl39-2-0-cust502.18-2.cable.virginm.net ([92.233.85.247]:42238 helo=rivendell.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odDID-0007By-FV; Tue, 27 Sep 2022 12:18:46 -0400 Original-Received: from localhost (rivendell.localdomain [local]) by rivendell.localdomain (OpenSMTPD) with ESMTPA id eda174c7; Tue, 27 Sep 2022 16:18:41 +0000 (UTC) In-Reply-To: <87k05p3uf9.fsf@gnus.org> X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243750 Archived-At: On Tue, Sep 27 2022, Lars Ingebrigtsen wrote: > Jose A Ortega Ruiz writes: > >> The patch below provides a quite simple implemetation of an imenu for >> doc-view, using mutool. That means of course that is limited to systems >> where it's installed, and doesn't try to be too smart, but it's been >> working quite well for me.=20 > > Looks good to me; pushed to Emacs 29. excellent, thanks a lot! > (Using `let-alist' is pretty unusual, but I guess it's nice that > somebody does -- there only seems to be two other usages in-tree in > Emacs since this was added in 2014. =F0=9F=99=83) i find it handy when the let body is small, otherwise it can make things harder to read. but i'm not specially attached to it if we prefer more idiomatic ways. cheers, jao