From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#58288: 29.0.50; (flyspell-correct-word-before-point) followed by crashes emacs Date: Wed, 05 Oct 2022 12:29:18 +0200 Message-ID: <87fsg28sxt.fsf@gmail.com> References: <877d1f3kgj.fsf@gnus.org> <83tu4jvkfz.fsf@gnu.org> <87zgeb91ac.fsf@gmail.com> <83mtabvgxw.fsf@gnu.org> <87pmf78vta.fsf@gmail.com> <83fsg3v9fb.fsf@gnu.org> <87k05e8u8w.fsf@gmail.com> <83fsg2twhv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17694"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58288@debbugs.gnu.org, larsi@gnus.org, ajd2195@columbia.edu To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 05 12:30:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1og1fU-0004Qq-S5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Oct 2022 12:30:24 +0200 Original-Received: from localhost ([::1]:59930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1og1fT-0003UJ-Ro for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Oct 2022 06:30:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1og1fA-0003Re-5s for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2022 06:30:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56908) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1og1f8-0007WB-Qj for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2022 06:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1og1f8-0005Qv-HN for bug-gnu-emacs@gnu.org; Wed, 05 Oct 2022 06:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Oct 2022 10:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58288 X-GNU-PR-Package: emacs Original-Received: via spool by 58288-submit@debbugs.gnu.org id=B58288.166496576920819 (code B ref 58288); Wed, 05 Oct 2022 10:30:02 +0000 Original-Received: (at 58288) by debbugs.gnu.org; 5 Oct 2022 10:29:29 +0000 Original-Received: from localhost ([127.0.0.1]:55986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1og1ea-0005Pj-Le for submit@debbugs.gnu.org; Wed, 05 Oct 2022 06:29:28 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:43987) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1og1eY-0005PS-Fu for 58288@debbugs.gnu.org; Wed, 05 Oct 2022 06:29:27 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id n12so5690389wrp.10 for <58288@debbugs.gnu.org>; Wed, 05 Oct 2022 03:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=WZFEcPSPc5hV+yL820HojS8lBFH8UR19Jd01CJiJY5g=; b=R4+UJf5igdviV76lFkwhvIOKNoT7EoLItHN5yNSAoL7EVQ+qfSTY5VHRQGFfkCiqRB DWwug85IsaXHvnSW/UIDnBECRWsFn+BrDV2aO//II/ngKT6dCGNFgDfOtJJD+xsdvwQI 8WxXC0yQH471iMMnXpt4inmTDmHdrazGlR5Y59hrpdsiIySQiXfdHqIii9hn9dNfVwXk 1Wz3Kc4dLwQ88lkFdSchEx15Z5yrU5Vt4oZZwHg9jYbrCG3kzWE6zyj6AS6m7GVg8rcd SLZxdIHM+faJzwxZwKC1TzSZtfljDp5C237gVMBk2z436iJNVBdJ6hbEDxovVpRM0gm7 Pxfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WZFEcPSPc5hV+yL820HojS8lBFH8UR19Jd01CJiJY5g=; b=drcaIN4Ng9AvQImVH9iUvbYpxcJHnCzErh3Lml2Lu8hJqjwHQr3FAxkA4rWDiTJLPE zjp7RVLgE8vRlxJd8pcNpOcOLYCWE1jrNCIyMgii+H5sVU07Hrn1r0JBQrfZC6UCMjDs u003jjsRVhLYK9dEp12FZlNa32BMv6rMmHFVAL+KEIsmof/mqowN1Cmt8Qe+eHw8jsX8 U+6dbM2SBxfPO2HWeAiFFpRNm9xjUPtkMmotGY24mQKd437MR/kFw/I+xNPQ3DUihv+N N0WciI4gAidBu5cotg8s/0PGyZ/K1VEBWrVSr0YKTZ9HZkzXrhHNg6AT28+sF8tevN4u A4lQ== X-Gm-Message-State: ACrzQf2yRG8qNb/LLqnjmXG3yjd5JAVON1Xn/wQIvnuOMGjRxLlp6V/R z/NgipZG8sDp+WvRPtjWbGA= X-Google-Smtp-Source: AMsMyM7RarVmkNgPr6RQuMu9oCGzYgmlMFb5/1eZtUOFUQQ7EbdumhcG+6nT4tJPWW35hpPhYcIPQA== X-Received: by 2002:adf:ea08:0:b0:22e:46e9:2a8a with SMTP id q8-20020adfea08000000b0022e46e92a8amr7283356wrm.636.1664965760461; Wed, 05 Oct 2022 03:29:20 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:37a5:6c3e:78d8:b7fc]) by smtp.gmail.com with ESMTPSA id iv14-20020a05600c548e00b003b4c40378casm1643654wmb.39.2022.10.05.03.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 03:29:19 -0700 (PDT) In-Reply-To: <83fsg2twhv.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Oct 2022 13:06:52 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244505 Archived-At: >>>>> On Wed, 05 Oct 2022 13:06:52 +0300, Eli Zaretskii said: >> void >> save_menu_items (void) >> { >> Lisp_Object saved =3D list4 (menu_items_inuse ? menu_items : Qnil, >> make_fixnum (menu_items_used), >> make_fixnum (menu_items_n_panes), >> make_fixnum (menu_items_submenu_depth)); >> record_unwind_protect (restore_menu_items, saved); >> menu_items_inuse =3D false; >> menu_items =3D Qnil; >> } >>=20 >> This fixes it, but it seems a bit dodgy to me, why has no other >> platform ever run into this? Eli> How come a menu is in use, but menu_items_inuse is zero? `menu_items_inuse' is not zero, it=CA=BCs false. `menu_items_used' is non-zero. I guess something called `unuse_menu_items', and the assumption is then that `menu_items' will not be accessed (but then why save away `menu_items_used' etc? menu.c says: /* Whether the global vars defined here are already in use. Used to detect cases where we try to re-enter this non-reentrant cod= e. */ bool menu_items_inuse; so should we be adding "if (menu_items_inuse)" guards everywhere? Robert --=20