From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#58518: 29.0.50; [PATCH] Turning off compilation-minor-mode removes fontification of other modes Date: Sun, 16 Oct 2022 10:24:51 +0200 Message-ID: <87fsfo2n1o.fsf@gnus.org> References: <87pmeue8s3.fsf@miha-pc> <87mt9x4c4j.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2928"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 58518@debbugs.gnu.org, miha@kamnitnik.top To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 16 10:26:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojyyN-0000Xq-2d for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Oct 2022 10:26:15 +0200 Original-Received: from localhost ([::1]:47664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojyyL-0003PM-E8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Oct 2022 04:26:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojyyA-0003P9-8O for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 04:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44192) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojyyA-0005fu-14 for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 04:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ojyy9-000587-Rw for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 04:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Oct 2022 08:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58518 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58518-submit@debbugs.gnu.org id=B58518.166590870719633 (code B ref 58518); Sun, 16 Oct 2022 08:26:01 +0000 Original-Received: (at 58518) by debbugs.gnu.org; 16 Oct 2022 08:25:07 +0000 Original-Received: from localhost ([127.0.0.1]:43269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojyxG-00056a-Lr for submit@debbugs.gnu.org; Sun, 16 Oct 2022 04:25:06 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:41344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojyxD-00055w-AG for 58518@debbugs.gnu.org; Sun, 16 Oct 2022 04:25:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0ueDCrvvIdj89fyVnkrAE0Sl/6L02CioPdGUrsjqulo=; b=pFm7544O2pXL4JJfjfTJnqgTFg cccxXr94kVRbHRG643rvfFQpq2GKfopuHCd7fTYpwZ5fj6F3a+SM9r4eVhqijS7vNgrCnr95ygNas hk+3AzQOFkEr7xyYdT4qRgaWjqaDO5NlBKj45TTtZm3kW+ydV5a9c7gpi5QI9dfrrGjA=; Original-Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojyx1-00044j-Rv; Sun, 16 Oct 2022 10:24:53 +0200 In-Reply-To: (Stefan Monnier's message of "Sat, 15 Oct 2022 10:45:28 -0400") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAMFBMVEX+/v7r5ufa0dOT eoOIbHeecXKrnJ5NPD5KOEM2JzFJMTprVV4dEx7DtrmAO0X///8iZEbjAAAAAWJLR0QPGLoA2QAA AAd0SU1FB+YKEAcoKHvHDdQAAAEpSURBVDjL1dO/T4NAFMBx/A96XZxLnFxxc70QE+ZObpZcE4Mz rYwuYpnUICBOGvkRF1PSlr6OxpT0TR10MGz+IaLjg+72u35yL3eXPEnaylibMSZXdQgcdHsKNwd2 9EjgEMYKP7cH6ROBfv7e48mz+LwlcDR3uzx5aO2+EcgtYfJ4Kqx7Ak7wccyD1/YeHeWgZWnJtdin sChMAamXDWuwMgQkaBU39FaF2gcs0F4R0Gcu6FgJBQ20DNKrOKZfMr9UfT/jnKsEZqOT0wAqmFCY yF9/Jyjko/G0AK7UADz0cuBaRuEiDJcGcAAKDtqIkDWBHiJAGtdguV4gmMldDdy1UeQYRRReAn+I mh19nxEof+swmTFpS2ptAlGW60aoNqf5dTuMbZz2X/oBFFCMQmahl5wAAAAldEVYdGRhdGU6Y3Jl YXRlADIwMjItMTAtMTZUMDc6NDA6NDArMDA6MDDafE2zAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIy LTEwLTE2VDA3OjQwOjQwKzAwOjAwqyH1DwAAAABJRU5ErkJggg== X-Now-Playing: Pet Shop Boys's _Behaviour_: "Jealousy" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245606 Archived-At: Stefan Monnier writes: > I can't remember anyone measuring the performance impact, but it does > come at a cost since every time we call `lookup_char_property` it takes > significantly more work. > > This is called at every text-property (or overlay) boundary in things > like `next-single-property-change` and similar operations used by the > redisplay. > > The "more work" is the `assq` itself whose time is proportional to the > length of this alist, plus a `plist-get` per alias listed, whenever > the `assq` finds a match (i.e. whenever we're looking for a property > which has aliases). But this would be for the *compilation* buffer only, so perhaps that's fine... > FWIW, in the past I suggested maybe we should introduce a notion of > "property planes". So `compilation` could use one property plane, > `font-lock` could use another and they could just blindly remove all the > properties in their plane without affecting others. Yes, it's implementing planes, only manually. Having real planes would be great. > BTW, another option is to use overlays rather than > text-properties :-) I'd rather not -- things are confusing enough in this area already.