From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Sat, 29 Oct 2022 17:36:18 +0200 Message-ID: <87fsf6k5fx.fsf@betli.tmit.bme.hu> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17567"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: 58790@debbugs.gnu.org, Stefan Kangas , Danny Freeman To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 29 17:43:00 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oonz9-0004J9-CK for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Oct 2022 17:42:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oonyO-0007ro-Ev; Sat, 29 Oct 2022 11:42:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oontP-0003pV-Cy for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 11:37:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oontO-0001Qf-Ty for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 11:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oontO-0004Jb-OA for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 11:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Oct 2022 15:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.166705778916521 (code B ref 58790); Sat, 29 Oct 2022 15:37:02 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 29 Oct 2022 15:36:29 +0000 Original-Received: from localhost ([127.0.0.1]:36373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oonsr-0004IP-2O for submit@debbugs.gnu.org; Sat, 29 Oct 2022 11:36:29 -0400 Original-Received: from mail-ed1-f48.google.com ([209.85.208.48]:47082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oonsq-0004ID-5k for 58790@debbugs.gnu.org; Sat, 29 Oct 2022 11:36:28 -0400 Original-Received: by mail-ed1-f48.google.com with SMTP id u24so2605547edd.13 for <58790@debbugs.gnu.org>; Sat, 29 Oct 2022 08:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8K0r07jJ6n0JR/cLu2aCL5eYhNo4/GzoEzNzfZWS7Gs=; b=PWU5gl/ukknrDFpQhQBWg0XLtxO0V+TBsNpE5fsSc6Gky4HKZQ0rpIF+hNwnMBjFue 3KK7UbKEHPyWw8sbvThgso/eyxEsBZBP9JotaHGUpxltAHXmlTdWtW8gthVyVjR+WOzh /D1hQMRbNFzT2kO3UjlQ4a6Z1GRJZf962vHpGHyrju7zEGD+vGComOowuScrAkYRrDXj TJKwPqUeWpKbyVq7E/HbVqsGlNrcwnjG/Lh5lyVIRbJq3imz3qVb+Y1KYfSINe+A5rKC ++MOxhsUUGaip+583ueeq7Iy/gQneFkzprBl9sJovwLyz1Oxbr3T8rYp0OyHUIhdcHaf 1zLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8K0r07jJ6n0JR/cLu2aCL5eYhNo4/GzoEzNzfZWS7Gs=; b=0iL+i7V31GmLDfsGDZGUa47psLVm+NtvopaQAeBLyQlwsfTCmFuXp618JWimjiZShJ 1M1U8XnuJlK9muKC16GuWgklfR9tkM2IQjntsZitGxr2uHMGeey3yiKVK9Yg32fEI7Cp Yhq2mW9WpZd3ZgR958H4/+eZUhCqYuXGYg4tPNDVKV1OeHj73KclKhQZqFT9mm7BXX5r 9wrzLT6+6XN0I3xAAVItZrYEwIW/NJxXE2T96iZiGmJfbk+kK0plJHyPs1hmW2qHWbdD N3CFAr2DOKS1diz82zhr+Aro/1bPEYyanX5shtLtnEDU5TkFX35WRnJxIHfmQwLFKxK6 q57w== X-Gm-Message-State: ACrzQf0u4OALFdAasHNED2grHE8iiZAugwF320RZQa4BGtQ9rUGkYl0D F7xNR+YMjsazZExUhTer+eU= X-Google-Smtp-Source: AMsMyM7C2IXry6x3zNlB/BYS7JxXoH7kJGS9ABbyZahhnvAp41OdTY2l3Uwfa5RWjbSb1CpxJzWOSw== X-Received: by 2002:a05:6402:2319:b0:45c:4231:de18 with SMTP id l25-20020a056402231900b0045c4231de18mr4804388eda.383.1667057782053; Sat, 29 Oct 2022 08:36:22 -0700 (PDT) Original-Received: from betli.gmail.com (catv-86-101-66-128.catv.fixed.vodafone.hu. [86.101.66.128]) by smtp.gmail.com with ESMTPSA id vl14-20020a170907b60e00b007803083a36asm790108ejc.115.2022.10.29.08.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Oct 2022 08:36:21 -0700 (PDT) In-Reply-To: (Danny Freeman via's message of "Tue, 25 Oct 2022 17:44:22 -0400") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUMBwgHAgMFAAGPjY7/ //80MDHq6eqJt3pKAAABr0lEQVQ4jX2UzZKDIAzHqR177q7TPbtx2HMr6guQcrbY9txZ0fd/hA0f onXazcEJ/CD8E4Js8/HS9mwjXtqeMRxHXJkakTEm4b4GPVQW8PU8ov4fQCqeThlF60MBWdo1IXzd 2nEEZE7CEAZLwI0N/gJAhTj7ESQAX4gPgO8lyI+cvgViSVPlNomAj2M9gW40eg7VWY3cATjUcyiO Z+i03cFruGLYoUR7VyU3HihdmCEVhoDN65FXkpbSxkomOzsTQN/gySaodGb9Gdi1oSRXP46gdBWh LcUKJNdeGCWac74GKakmne0aHCFvyqJPYLsCFAVlhRTvGdzMdLHqtgRyUulyXIAH7CYQ3AB0Nody JQhAkq/qtOnbjhxdzYDkXPxlH5y4WdUAeUcX1NVJ6GR7UQEYPGWoAnA36OQNn5lRRp38vHTAp9Br LoTmvlPPDoRCKzpjG1SXT89AaT5l456BamJuMcs+NIOMzJ/s5dI6yUVcrARlruwOebfdv6gunTn4 ww3+QjGBEn5suVyLHoSGvAqREuDLN+iqZ+VcFg+HBbsJUU9+FZthbez9T+bdb+kPv2Ls6ct3hTkA AAAASUVORK5CYII= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246542 Archived-At: > The problem occurs when using `xref-find-defintions` while eglot is > managing a clojure buffer with clojure-lsp. If the symbol that > xref-find-definitions is activated on is defined in a jar file, > clojure-lsp by default will provide a location with a response like > the following > > (:jsonrpc "2.0" :id 14 :result > (:uri > "zipfile:///Users/andreperictavares/.m2/repository/org/clojure/tools.namespace/0.3.1/tools.namespace-0.3.1.jar::clojure/tools/namespace/find.clj" > ... )) > Can you, please, consider merging something like github#854? https://github.com/joaotavora/eglot/pull/854 Currently, Eglot assumes that the uri-scheme is always "file". I think Eglot should at least warn the user if this assumption is false instead of silently failing as it currently does. Thanks.