From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#56514: 29.0.50; Improve ERC's URI scheme integration for irc:// links Date: Wed, 16 Nov 2022 06:22:59 -0800 Message-ID: <87fsejnflo.fsf__42890.3594541893$1668608658$gmane$org@neverwas.me> References: <87pmiabvd5.fsf@neverwas.me> <87iljl4meb.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23594"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 56514@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 16 15:24:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovJKj-0005v9-Lm for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Nov 2022 15:24:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovJKd-0002mC-6w; Wed, 16 Nov 2022 09:24:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovJKc-0002m2-L1 for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 09:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovJKc-0001h0-Cq for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 09:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ovJKc-0001cr-8T for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 09:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Nov 2022 14:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56514 X-GNU-PR-Package: emacs Original-Received: via spool by 56514-submit@debbugs.gnu.org id=B56514.16686085966196 (code B ref 56514); Wed, 16 Nov 2022 14:24:02 +0000 Original-Received: (at 56514) by debbugs.gnu.org; 16 Nov 2022 14:23:16 +0000 Original-Received: from localhost ([127.0.0.1]:56472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovJJs-0001br-4N for submit@debbugs.gnu.org; Wed, 16 Nov 2022 09:23:16 -0500 Original-Received: from mail-108-mta29.mxroute.com ([136.175.108.29]:44299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovJJo-0001bc-E8 for 56514@debbugs.gnu.org; Wed, 16 Nov 2022 09:23:14 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta29.mxroute.com (ZoneMTA) with ESMTPSA id 18480d261db0006e99.001 for <56514@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 16 Nov 2022 14:23:02 +0000 X-Zone-Loop: d44aac10d51893b4ce8498251289686027aa475bbbee X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PwWY8YycMr4CZ59QKXZVSWrkR5tA5rSjLqw8LfMjR3I=; b=A0yp0pUFnHnYtNpdghMAdNEM/5 A02kH+6djZ/GnRWafWr4d29CH5Z4TvY6KKUwduZh+kSjXZ2LwKbCiCHJnH/daYSn+m68U8fvE49ai o4pyGQnH2/QPV5TYEzWjcHNtwSJ8QreH6WRR2xfxjRgZqVvxrst5iCPDBn5r8+AXF6MGGler2BHpK jiruZyIUnIPefATFZ9H3pcmw9+SAgM1NDvUR4Mp6N45H0NVsgQZ8+0kknHkRE/ASIGi3nK/QSr/6Z pVYJbgAn6rGaMDSEAfqz8/FyZWz71gbwvl2MFqwBg6068WIDrqCDtsaBze76/i+BBBnpMR2IkFqZj X6hmu7ng==; In-Reply-To: <87iljl4meb.fsf@neverwas.me> (J. P.'s message of "Fri, 11 Nov 2022 06:05:16 -0800") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248017 Archived-At: Quick note: > diff --git a/lisp/erc/erc-compat.el b/lisp/erc/erc-compat.el > index 03bd8f1352..340d90ba96 100644 > --- a/lisp/erc/erc-compat.el > +++ b/lisp/erc/erc-compat.el > @@ -32,6 +32,7 @@ > ;;; Code: > [...] > + > +(when (< emacs-major-version 29) > + (unless (assoc "\\`irc6?s?://" browse-url-default-handlers) > + (push '("\\`irc6?s?://" . erc-compat--29-browse-url-irc) > + browse-url-default-handlers))) This won't work on 27, so we'll probably have to do something like (cond ((fboundp 'browse-url-irc)) ; 29 ((boundp 'browse-url-default-handlers) ; 28 (cl-pushnew '("\\`irc6?s?://" . erc-compat--29-browse-url-irc) browse-url-default-handlers)) ((boundp 'browse-url-browser-function) ; 27 (require 'browse-url) (let ((existing browse-url-browser-function)) (setq browse-url-browser-function (if (functionp existing) (lambda (u &rest r) (apply (if (string-match-p "\\`irc6?s?://" u) #'erc-compat--29-browse-url-irc existing) u r)) (cons '("\\`irc6?s?://" . erc-compat--29-browse-url-irc) existing)))))) > + > (provide 'erc-compat)