From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59904: 29.0.60; js-ts-mode does not fontify method-call to object-instances using font-lock-function-name Date: Thu, 08 Dec 2022 16:02:26 +0100 Message-ID: <87fsdqc519.fsf@thornhill.no> References: <2657cf47-c2af-eeba-265f-3249b9f38e4c@secure.kjonigsen.net> <88850c60-60ad-8713-dba2-f9f42016f219@secure.kjonigsen.net> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27513"; mail-complaints-to="usenet@ciao.gmane.io" To: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , Yuan Fu , 59904@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 08 16:03:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3IQf-0006vp-PG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Dec 2022 16:03:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3IQW-0008Ip-Ls; Thu, 08 Dec 2022 10:03:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3IQQ-0008Gq-MH for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 10:03:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3IQQ-0006do-3J for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 10:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3IQP-0003sz-V8 for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 10:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2022 15:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59904 X-GNU-PR-Package: emacs Original-Received: via spool by 59904-submit@debbugs.gnu.org id=B59904.167051175114930 (code B ref 59904); Thu, 08 Dec 2022 15:03:01 +0000 Original-Received: (at 59904) by debbugs.gnu.org; 8 Dec 2022 15:02:31 +0000 Original-Received: from localhost ([127.0.0.1]:57288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3IPv-0003sk-CL for submit@debbugs.gnu.org; Thu, 08 Dec 2022 10:02:31 -0500 Original-Received: from out-177.mta0.migadu.com ([91.218.175.177]:26276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3IPt-0003se-Kg for 59904@debbugs.gnu.org; Thu, 08 Dec 2022 10:02:30 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670511747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QxcfxdWV/pd+N3L5zfJjJFfg0t3D79RaXoprkxG8GcY=; b=ctbxPD5t4sSKjh2tom+YTGq0tqpAJlfwoN9GC0oyH+1isH3tUfmOyBbZGXFS5MXIEeaH0a w2VE6gO47rdOG+1QLBIg3UMnC7ZEpPzWQq4W9WNtT+9Dix1UhN3zG/l2YimVA15MdXsDcb kQui88DSc5PQ/VMHvrZ/7kpV+0YfVJx3xO1DiQNx0rmQ1yaUUBZpVwY5/+FcD4NG3YfJTb U876Wt/fv8Z7b4qWn8OcDWT3jgA7wGVxRAujc3cP9Zteas4u8vy5dVi3TOylhvoS1DDSN+ DHaf2tuZEbQ85ZpvWPVERgc1+hfYyuUaU7MdfBGYdZHgon43H8ZTElSDlOIS8Q== In-Reply-To: <88850c60-60ad-8713-dba2-f9f42016f219@secure.kjonigsen.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250303 Archived-At: Jostein Kj=C3=B8nigsen writes: > Looking into the code, a minimal code-repro looks like this: > > someObject.someMethod(); > > Activating treesit-explore-mode on that, yields the following tree: > > (expression_statement > =C2=A0(call_expression > =C2=A0 function: (member_expression object: (identifier) . property:=20 > (property_identifier)) > =C2=A0 arguments: (arguments ( ))) > =C2=A0;) > > Now looking in js.el I see the following which looks like it's trying to= =20 > fontify this, but for some reason it's not working: > > =C2=A0=C2=A0=C2=A0=C2=A0 (call_expression > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 function: [(identifier) @font-lock-functi= on-name-face > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 (member_expression > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 property: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (property_identifier) @font-lock-function-na= me-face)]) > > I'm guessing this fontification is being overridden further down (just=20 > like for csharp-ts-mode). From what I can tell, reversing the order of=20 > declarations seems to fix this for me. > Yeah this is probably correct. Looks good to me. Yuan, want to apply? :-) Theo