Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Mon, 12 Jun 2023 19:40:24 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Cc: michael.albinus@gmx.de,  emacs-devel@gnu.org
    >> Date: Mon, 12 Jun 2023 17:57:00 +0200
    >> 
    >> The minimal fix would be:
    >> 
    >> diff --git a/lisp/window.el b/lisp/window.el
    >> index 78b0787abdb..16f16a75418 100644
    >> --- a/lisp/window.el
    >> +++ b/lisp/window.el
    >> @@ -8776,7 +8776,7 @@ display-comint-buffer-action
    >> :group 'windows
    >> :group 'comint)
    >> 
    >> -(defcustom display-tex-shell-buffer-action 'display-buffer-in-previous-window
    >> +(defcustom display-tex-shell-buffer-action '(display-buffer-in-previous-window)
    >> "`display-buffer' action for displaying TeX shell buffers."
    >> :type display-buffer--action-custom-type
    >> :risky t

    Eli> Fine by me, please install.

Done, although we should consider having that action have
'(inhibit-same-window . t)' in it. Maybe on master.

    >> -(defcustom display-tex-shell-buffer-action 'display-buffer-in-previous-window
    >> +(defcustom display-tex-shell-buffer-action display-buffer--in-previous-window-action
    >> "`display-buffer' action for displaying TeX shell buffers."
    >> :type display-buffer--action-custom-type
    >> :risky t

    Eli> Why do we need an extra variable here?

We donʼt, it just looks nicer than stuffing a multi-line constant in
the default value field.

Robert
--