From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master a30781399b3: * subr-x (eval-command-interactive-spec): New function. Date: Wed, 14 Jun 2023 11:14:08 +0100 Message-ID: <87fs6u5p1r.fsf@melete.silentflame.com> References: <168595059426.2523.2109338263713299231@vcs2.savannah.gnu.org> <20230605073635.19060C00613@vcs2.savannah.gnu.org> <875y80g7p8.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10248"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 14 12:15:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9NX6-0002OR-Ca for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Jun 2023 12:15:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9NW7-0000MP-IE; Wed, 14 Jun 2023 06:14:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9NW4-0000Lt-S2 for emacs-devel@gnu.org; Wed, 14 Jun 2023 06:14:17 -0400 Original-Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9NW3-0007ny-15 for emacs-devel@gnu.org; Wed, 14 Jun 2023 06:14:16 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id B59D1320094F; Wed, 14 Jun 2023 06:14:11 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 14 Jun 2023 06:14:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1686737651; x= 1686824051; bh=RmYTn2SXXPudf40+qH5FiRsErRqz5WGoIRH8Bl/hHJo=; b=q 4d883T0CfIEw+RCJLGOQRyddpT2xVAZrTIcUf61kCg2KPItNc8nlcY4PITqg9uRV u9rhhaJk8wNqLd6dOl2Nsk1zLY6V8S0nLHMZZfX0C+0V8nCzyRSVdXDQAEOlQSiG Tq/Xna+nLPFcfQ9rpEUcx7C7ULIlNIzw1n2bk7XAu1rK/DJAigOjkVNeikz6PS+m bQQVi+VIlqH6kcZkCvcrDk2d200EuU7Ult3l0FXoKX2+5xIXSXpQlHbUX/hFLFMh b0ETm0+kjyM9SWlngQIvFMMJUZVoBu9d0ynCXTG/NAP6YBG2JzCF9mufxNrn8GW+ uF/gHld6QuzqnB1mio5sQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1686737651; x=1686824051; bh=RmYTn2SXXPudf 40+qH5FiRsErRqz5WGoIRH8Bl/hHJo=; b=jQX6oTqryT8ZiEZAROOyqytnVYm3V tEcBgvFrZXb5tqQ5o1nkhQCm2swfp6MKuBEq/RNrXPlR/pY11uqv/TV9zsOwZJ4O 6T+N1SbPk3ZwVUMVniM0QWNjM0Wc2Hu6u5BLnfl20kUos4iLXnA2XLn7r30kfGH7 dhBiVY4mCuZXEHmV5+/Mo+K3gqB0UG49QHNZ9/71XiUlR1QwQheRsWTUtfEsaAMR XqpsCQ2i2YeFcKywnZy3kraZR9nMgYfbNcv6IW/NxWUwBfIJtUNtFLGDrMvbWhII gSUM5TZxgdp79SLeRrPdl+skrBPisgRtWKDJ/taEXae5eahdc5+KPJz6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedvtddgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Jun 2023 06:14:10 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 3A5187E4ABE; Wed, 14 Jun 2023 11:14:08 +0100 (BST) In-Reply-To: (Stefan Monnier's message of "Fri, 09 Jun 2023 10:39:50 -0400") Received-SPF: pass client-ip=64.147.123.19; envelope-from=spwhitton@spwhitton.name; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306792 Archived-At: Hello, On Fri 09 Jun 2023 at 10:39AM -04, Stefan Monnier wrote: > AFAICT the functionality of `advice-eval-interactive-spec` is not used > often at all, so having a specialized version for the specific case when > it's applied to (cadr (interactive-form command)) seems hard to justify. > > Can you point to (potential) users? Here is something I have: (defun spw/run-or-restore-gud (arg) (interactive "P") (if (or arg (not (and (bound-and-true-p gud-comint-buffer) (get-buffer-process gud-comint-buffer)))) ;; Start a new debugging session even if one already exists. ;; Killing `gud-comint-buffer' is the documented way to quit an ;; existing session. (let* ((cmd (cl-case major-mode (c-mode 'gdb) (cperl-mode 'perldb) (python-mode 'pdb) (t (intern (completing-read "GUD command: " '(gdb perldb pdb) nil t))))) (args (eval-command-interactive-spec cmd))) (when (buffer-live-p gud-comint-buffer) (when-let ((proc (get-buffer-process gud-comint-buffer))) (set-process-query-on-exit-flag proc nil)) (kill-buffer gud-comint-buffer)) (gdb-wait-for-pending (lambda () (apply cmd args)))) ;; Restore the session. (cl-case (buffer-local-value 'gud-minor-mode gud-comint-buffer) (gdbmi (gdb-restore-windows) ;; Try to ensure prompt is at the bottom of its window. (recenter (window-body-height))) (t (pop-to-buffer gud-comint-buffer))))) I initially tried implementing this using :around advice, but found that worked less well in some respect that I can now not remember. But I definitely tried it :) -- Sean Whitton