From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master b34f9a44393: Apply remote-file-name-access-timeout in desktop.el and recentf.el Date: Tue, 04 Jul 2023 17:41:36 +0200 Message-ID: <87fs638z0v.fsf@gmail.com> References: <168847723857.12043.8020935461264507935@vcs2.savannah.gnu.org> <20230704132719.3251EC11DCA@vcs2.savannah.gnu.org> <87jzvf92yw.fsf@gmail.com> <87sfa3n3fg.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12210"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 04 17:42:39 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGiAo-0002zA-Oi for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Jul 2023 17:42:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGi9w-0007ou-Rd; Tue, 04 Jul 2023 11:41:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGi9u-0007oc-QV for emacs-devel@gnu.org; Tue, 04 Jul 2023 11:41:42 -0400 Original-Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGi9t-0005W2-A4 for emacs-devel@gnu.org; Tue, 04 Jul 2023 11:41:42 -0400 Original-Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-314313f127fso3218794f8f.1 for ; Tue, 04 Jul 2023 08:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688485298; x=1691077298; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=IGxMGqBS7DA/1v4iugWFmoNkbVBA/RuI7ZbHhkKxdJY=; b=E8l/nePAXfe6PGn/SW47uYYE0G+HOF1FfvdYaUR0H26qYJas67AMss8RRY2/XEyEbt 1Virw1FK6/dMV8KM8XcGFH+f7K86dR1ha3pJwcrea5iKzbH4zof7ShjTJ7+CySz6u1qT pt7QhCBgiMShrrhUh4NZbuKhvPkA1WIoan/KHH2IPTCU0QzDWucaZ0jyIoPlEty/VENu TKSHbw6EaVqQmpHw/w5YGjTxDD6zwUV2GfBs5KUXBi780hGiA5D9Q70kbdx73ljy/Jlu 5EtG5ZLNKDsWyke/hKmmUyXXybYxvJ6II6pVzqCWwfHY3fRG0IyLigXAnEVhWRLsM9Eb XAAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688485298; x=1691077298; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IGxMGqBS7DA/1v4iugWFmoNkbVBA/RuI7ZbHhkKxdJY=; b=GC0GQfwwWOtjpDl8C5Vo8xf7NJdfxefFM5A5OEroITXjFP/TiYUpeob+cZX6s6eN2b VEDX2JNeigyAGp+be+hkB+Fa6z1LGfiEQwZjixcXD9+u/GOSYtru51ebsRkXx46MkUSa SG0VV1ILsBccsWjmBwAc/OklpeZ+Abbq3WutVPFf4ocrrugP6DDUuzjx5ZED0zXomHLY PFBAbsbUcAlq9hPLoqrHPt6WZTXtjK73UXJJ1OBpIJx+/sKq30K0CHh0pz5Fn5mc+p57 q5z2ptoNGLAAGxBgWkBX8OTzjrxvta7KgO4TFru1UW2oMW61wKJV9ck40ofTu2kHCTen hrDA== X-Gm-Message-State: ABy/qLYupBeRD14IaVi2/hb6hAJgxnOypGfQnF/z8hJQVACeudzbN6Jq SufVIytvFjMb+p0BI4lzBcntJNyVHt0= X-Google-Smtp-Source: APBJJlEGluaMKiv8h8YTJ4kl842G16BTtjRJc44iTeBJwpcc3MqjnwRUqo307bAh11jsbD+ss+5n9w== X-Received: by 2002:a5d:51c7:0:b0:313:e8f9:803 with SMTP id n7-20020a5d51c7000000b00313e8f90803mr10365647wrv.3.1688485297943; Tue, 04 Jul 2023 08:41:37 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:b9a3:c52:1db9:50d6]) by smtp.gmail.com with ESMTPSA id c23-20020a05600c0ad700b003fbc9371193sm12253521wmr.13.2023.07.04.08.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 08:41:37 -0700 (PDT) In-Reply-To: <87sfa3n3fg.fsf@gmx.de> (Michael Albinus's message of "Tue, 04 Jul 2023 16:42:43 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=rpluim@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307422 Archived-At: >>>>> On Tue, 04 Jul 2023 16:42:43 +0200, Michael Albinus said: Michael> But this is theory. If a connection is already established, a = small Michael> value of even 1 second would suffice. OTOH, if you need the in= itial Michael> connection phase (f.e. during Emacs startup), with a slow conn= ection to Michael> the remote host, 60 seconds might be too short. And think about Michael> multi-hops, where the initial connection phase could last long= er. Michael> That's why I've decided for the nil value, which is also the e= quivalent Michael> to the current behavior - no timeout. But this is not set in s= tone, if Michael> people believe another value is godd, then let's try it. I=CA=BCm all for retaining backwards compatibility, but when the behaviour we=CA=BCre retaining is 'hang forever', I think we should consider putting in a default timeout. If it turns out to be too short, for some people, then they can adjust their local value, no? Michael> Btw, I've thought also about supporting connection-local value= s for Michael> remote-file-name-access-timeout. For a fast connection you set= it to 10 Michael> seconds, for another connection you use a larger value. Not im= plemented Michael> yet, I don't know whether users want such a fine-grained custo= mization. YAGNI. I=CA=BCd wait until people ask for it. >> (I also see you use `natnump' for >> `remote-file-name-access-timeout'. Is 0 a sane value to allow, I thi= nk >> it would cause immediate timeout?) Michael> Yes, an immediate timeout. OK. I don=CA=BCt see the utility of that, but it=CA=BCs your code :-) Robert --=20