From: Robert Pluim <rpluim@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: master b34f9a44393: Apply remote-file-name-access-timeout in desktop.el and recentf.el
Date: Tue, 04 Jul 2023 17:41:36 +0200 [thread overview]
Message-ID: <87fs638z0v.fsf@gmail.com> (raw)
In-Reply-To: <87sfa3n3fg.fsf@gmx.de> (Michael Albinus's message of "Tue, 04 Jul 2023 16:42:43 +0200")
>>>>> On Tue, 04 Jul 2023 16:42:43 +0200, Michael Albinus <michael.albinus@gmx.de> said:
Michael> But this is theory. If a connection is already established, a small
Michael> value of even 1 second would suffice. OTOH, if you need the initial
Michael> connection phase (f.e. during Emacs startup), with a slow connection to
Michael> the remote host, 60 seconds might be too short. And think about
Michael> multi-hops, where the initial connection phase could last longer.
Michael> That's why I've decided for the nil value, which is also the equivalent
Michael> to the current behavior - no timeout. But this is not set in stone, if
Michael> people believe another value is godd, then let's try it.
Iʼm all for retaining backwards compatibility, but when the behaviour
weʼre retaining is 'hang forever', I think we should consider putting
in a default timeout. If it turns out to be too short, for some
people, then they can adjust their local value, no?
Michael> Btw, I've thought also about supporting connection-local values for
Michael> remote-file-name-access-timeout. For a fast connection you set it to 10
Michael> seconds, for another connection you use a larger value. Not implemented
Michael> yet, I don't know whether users want such a fine-grained customization.
YAGNI. Iʼd wait until people ask for it.
>> (I also see you use `natnump' for
>> `remote-file-name-access-timeout'. Is 0 a sane value to allow, I think
>> it would cause immediate timeout?)
Michael> Yes, an immediate timeout.
OK. I donʼt see the utility of that, but itʼs your code :-)
Robert
--
next prev parent reply other threads:[~2023-07-04 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <168847723857.12043.8020935461264507935@vcs2.savannah.gnu.org>
[not found] ` <20230704132719.3251EC11DCA@vcs2.savannah.gnu.org>
2023-07-04 14:16 ` master b34f9a44393: Apply remote-file-name-access-timeout in desktop.el and recentf.el Robert Pluim
2023-07-04 14:42 ` Michael Albinus
2023-07-04 15:41 ` Robert Pluim [this message]
2023-07-04 16:29 ` Eli Zaretskii
2023-07-04 17:28 ` Robert Pluim
2023-07-04 16:40 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs638z0v.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.