From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: package-autosuggest Date: Thu, 31 Aug 2023 05:38:14 +0000 Message-ID: <87fs3zsreh.fsf@posteo.net> References: <87il9kksqz.fsf@dfreeman.email> <3d5ef276-ce6b-9ff0-0c60-1da6b887b365@gutov.dev> <1070e416-2a13-49e0-90d4-fbc526cd461c@app.fastmail.com> <83ttskia84.fsf@gnu.org> <97c96b72-ebba-4853-98d2-86e3ba8bbc05@app.fastmail.com> <83sf84i9ix.fsf@gnu.org> <837cpfhzdm.fsf@gnu.org> <83zg2agjp8.fsf@gnu.org> <87ttshk3ns.fsf@posteo.net> <83il8whjig.fsf@gnu.org> <87fs40oiie.fsf@posteo.net> <838r9shgtz.fsf@gnu.org> <871qfkogy7.fsf@posteo.net> <835y4whd0m.fsf@gnu.org> <87r0nks55d.fsf_-_@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29021"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , stefankangas@gmail.com, yandros@gmail.com, bozhidar@batsov.dev, dmitry@gutov.dev, rms@gnu.org, danny@dfreeman.email, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 31 07:39:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbaOn-0007Ip-Kw for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Aug 2023 07:39:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbaNs-00061F-EH; Thu, 31 Aug 2023 01:38:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbaNr-000617-Bj for emacs-devel@gnu.org; Thu, 31 Aug 2023 01:38:23 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbaNo-0003hR-9x for emacs-devel@gnu.org; Thu, 31 Aug 2023 01:38:23 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D2017240028 for ; Thu, 31 Aug 2023 07:38:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693460297; bh=/ZShpFohrINtSvlwa0JX7W1pjEWhDbQ3RaI8mLL03Oo=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=DlrisdJz4UG89aE2Ld5zlv4nLQo+omzU9bwUIgjzcx3QtTl3Y6t82jah4C3EMR1my YtdwPLboKSH2MDKgKfzuyIKbkVAnNxkyhKmncoFTiFPsykUg5px+1GiyHhh5J3/Pjc J15yOJNb0lvlzjdn3T4BhBi5YvfVcoDwfP32b22O09eZ+tixSivrJx1s6WIiF5+1Hs /SAXgnMvdKFLOuLwF+yKduaYAQoTNh2nMyZwaB2kuS18US4ff+qNWbfI2o8UO0XGzR VfDlT6gaSUUklvYoGDL3i8s27aK6fLBl+JTZ83V+PaXIk2pMbr5JwSFlzB4xGgoeJ1 +R3BZs28MZa2w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rbqh83Qv7z6tsf; Thu, 31 Aug 2023 07:38:16 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Wed, 30 Aug 2023 19:13:48 -0400") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309589 Archived-At: Stefan Monnier writes: >> +(defun package--suggestion-applies-p (pkg-sug) >> + "Check if a suggestion PKG-SUG is applicable to the current buffer." >> + (pcase pkg-sug >> + (`(,(pred package-installed-p) . _) nil) > > I think we should strive to minimize the dependency on `package.el` (as > well as the performance impact) so we should try and use something like > `fboundp` here instead (testing "the function" provided by the package > when it's installed). Would you argue it would be better to implement this feature outside of package.el? And by function we mean something like the major mode of a package, right? > > Stefan