From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting Date: Sat, 23 Sep 2023 12:43:40 +0000 Message-ID: <87fs35vz43.fsf@posteo.net> References: <87bke85hsb.fsf@gmail.com> <87a5tobby9.fsf@debian-hx90.lan> <871qf0atqs.fsf@debian-hx90.lan> <878r97ooxs.fsf@posteo.net> <87a5tf3714.fsf@debian-hx90.lan> <87r0mrwkyp.fsf@posteo.net> <875y4331m2.fsf@debian-hx90.lan> <87cyyavcoh.fsf@posteo.net> <87fs3528l2.fsf@debian-hx90.lan> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40130"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65882-done@debbugs.gnu.org, Ryan Yeske , Leo Liu , Manphiz To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 23 14:44:01 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qk1zM-000AIe-Ns for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Sep 2023 14:44:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qk1zG-0006gn-KQ; Sat, 23 Sep 2023 08:43:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qk1zD-0006gf-71 for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 08:43:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qk1zC-0007NZ-TV for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 08:43:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qk1zO-0004dO-1q for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 08:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Sep 2023 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65882 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65882-done@debbugs.gnu.org id=D65882.169547304117809 (code D ref 65882); Sat, 23 Sep 2023 12:44:02 +0000 Original-Received: (at 65882-done) by debbugs.gnu.org; 23 Sep 2023 12:44:01 +0000 Original-Received: from localhost ([127.0.0.1]:37950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk1zN-0004d0-8I for submit@debbugs.gnu.org; Sat, 23 Sep 2023 08:44:01 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:59085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qk1zK-0004cg-Q9 for 65882-done@debbugs.gnu.org; Sat, 23 Sep 2023 08:43:59 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5F2A6240104 for <65882-done@debbugs.gnu.org>; Sat, 23 Sep 2023 14:43:41 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rt82N3MVbz9rxK; Sat, 23 Sep 2023 14:43:40 +0200 (CEST) In-Reply-To: (Stefan Kangas's message of "Sat, 23 Sep 2023 04:41:08 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271165 Archived-At: Stefan Kangas writes: > Manphiz writes: > >>> I don't necessarily object, but is it a regression? >> >> The reconnecting and rejoining channels feature is broken in certain >> situation, and this patch fixes that. Some other users claimed this >> works for them, so I would say this may be considered a regression. >> >>> Is the change safe? >> >> According to the logic of the code, this patch enables doing work that >> (I believe) should have been done and not changing anything else, so I >> would say it is safe. >> >>> If the answer to either of those questions is "no", I think master is >>> the safer choice. >> >> I would say the answers are both yes, but of course that's just my >> opinion and the decision is up to you :) > > Thanks. If Philip agrees, I see no reason why this can't be installed > on emacs-29. I am fine with it as well, so I'll cherry-pick the branch from master onto emacs-29.