From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manphiz Newsgroups: gmane.emacs.bugs Subject: bug#65882: 29.1; rcirc doesn't rejoin channels automatically on reconnecting Date: Fri, 22 Sep 2023 14:37:13 -0700 Message-ID: <87fs3528l2.fsf@debian-hx90.lan> References: <87bke85hsb.fsf@gmail.com> <87a5tobby9.fsf@debian-hx90.lan> <871qf0atqs.fsf@debian-hx90.lan> <878r97ooxs.fsf@posteo.net> <87a5tf3714.fsf@debian-hx90.lan> <87r0mrwkyp.fsf@posteo.net> <875y4331m2.fsf@debian-hx90.lan> <87cyyavcoh.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35365"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65882-done@debbugs.gnu.org, Philip Kaludercic , Ryan Yeske , Leo Liu To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 22 23:38:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjnqn-00090N-KL for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Sep 2023 23:38:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjnqT-0004GP-5s; Fri, 22 Sep 2023 17:37:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjnqS-0004GH-Bd for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 17:37:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjnqS-0003ZZ-3v for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 17:37:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjnqb-0005RZ-L0 for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 17:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manphiz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2023 21:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65882 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65882-done@debbugs.gnu.org id=D65882.169541865720884 (code D ref 65882); Fri, 22 Sep 2023 21:38:01 +0000 Original-Received: (at 65882-done) by debbugs.gnu.org; 22 Sep 2023 21:37:37 +0000 Original-Received: from localhost ([127.0.0.1]:37357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjnqC-0005Qm-H5 for submit@debbugs.gnu.org; Fri, 22 Sep 2023 17:37:36 -0400 Original-Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:55599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjnq8-0005QV-6J for 65882-done@debbugs.gnu.org; Fri, 22 Sep 2023 17:37:35 -0400 Original-Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1c59c40b840so26944885ad.3 for <65882-done@debbugs.gnu.org>; Fri, 22 Sep 2023 14:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695418635; x=1696023435; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=pmYCHaSWWZW8y7H+7vh7lXG/MSIz8FMe65xnEvJaye8=; b=SG4HetHZIMiebWRmNkV1m87saLlYE8DFLgVTUvoGrltjhvR+vQ0QIrn66b8kexzqus j6vS2tVLo301s+b0Id79fx6vlH07dr+Jlm6af6MFaGMJwlqgBj28DwO9MSvU3WJfofGZ z8SNF/9qA/+CW4UyML1ErhlRfHj90Y3XQXYEhz0hr2df5fePEhd6q+Fz2YgXTndlFB5q M0x96edYQT/duTOX1NV/40ntub05eq7u8sf8CNqEw8KauXzLWq9Pil5O1hz6nEyPtSHn 8cIE3Jc97dAqzNg89Xo+gXTP0pzyUTeaD/vxHqkgZheFHY8JBtryQD9tLmalauLnoyrs 2YYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695418635; x=1696023435; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pmYCHaSWWZW8y7H+7vh7lXG/MSIz8FMe65xnEvJaye8=; b=U1cuilHg3C+Q+tyenI/gfBXHXzM3IfDukKND8mnhlsGjM5G6WfyRKVV5WE8PomBqVd 2HG57v1A/BwcDpRAQq5iIbQ0cIDapGqEq7PCYgKG1eQ+LFOT2jN0cb/zk4dqW/IutKIT mTlsbjkSlNshk/7kMZujStWMtuw5JfnalTMtLSkzn6wsphe6myi+xhQobEAq4EYftjmw k0PMkBWnntMIDndXzMeqPk0EXmd/Uid+AfmClpOxV0wXrfAnys8fNHQmjgwfXVh0EUIJ dBUC1vn31GXGfS98VAKh8Xr9xYQ48A33S8qOcyyjeaCh8wz3fth/LL2AY8WxIx8373Fx WesQ== X-Gm-Message-State: AOJu0YxJ/oi7R0My/+P7LC5ohlI83u2n9TvgzbXkh3Cny5pT/EdJSX0M jsrCcIrSzceGPOw8/43JJXw= X-Google-Smtp-Source: AGHT+IH03JpyrLC4PBX3djuCi0Ek4zFSE/tc6rZSF+mZJXLUZpy4arp05RRknS967OZd7EIlWnYfIg== X-Received: by 2002:a17:902:8e88:b0:1c5:d747:a124 with SMTP id bg8-20020a1709028e8800b001c5d747a124mr671975plb.9.1695418634940; Fri, 22 Sep 2023 14:37:14 -0700 (PDT) Original-Received: from debian-hx90 (2603-8000-a400-0cdc-2043-dd53-a2d0-2a42.res6.spectrum.com. [2603:8000:a400:cdc:2043:dd53:a2d0:2a42]) by smtp.gmail.com with ESMTPSA id a12-20020a170902ee8c00b001c5c370d4desm3981914pld.246.2023.09.22.14.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 14:37:14 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Fri, 22 Sep 2023 01:46:14 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271126 Archived-At: Stefan Kangas writes: > Philip Kaludercic writes: > >>> Additionally, is it OK to backport this to 29 branch or even 28 branch? >> >> I don't know if bugs are backported onto emacs-28, the branch seems to >> be stale. > > We don't plan to make any more releases of Emacs 28, so we don't bother > with backporting fixes there. > >> The emacs-29 branch might be viable, but I don't want to decide that >> myself. If Stefan is fine with that, I can take care of it. > > I don't necessarily object, but is it a regression? The reconnecting and rejoining channels feature is broken in certain situation, and this patch fixes that. Some other users claimed this works for them, so I would say this may be considered a regression. > Is the change safe? According to the logic of the code, this patch enables doing work that (I believe) should have been done and not changing anything else, so I would say it is safe. > If the answer to either of those questions is "no", I think master is > the safer choice. > I would say the answers are both yes, but of course that's just my opinion and the decision is up to you :) >>> Or is there any automatic backport process for release branches? >> >> Not that I know of. > > The process is indeed manual. -- Manphiz