From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67462: 30.0.50; prog-fill-reindent-defun does not respect buffer-local fill-paragraph-function Date: Thu, 30 Nov 2023 21:40:19 +0100 Message-ID: <87fs0n0ybw.fsf@sappc2.fritz.box> References: <87zfz09q9d.fsf@sappc2.fritz.box> <87wmu49lgv.fsf@sappc2.fritz.box> <83a5qz9ysx.fsf@gnu.org> <87wmu3gdrz.fsf@sappc2.fritz.box> <83il5m9aqz.fsf@gnu.org> <87jzq1bn4a.fsf@sappc2.fritz.box> <83sf4o7n06.fsf@gnu.org> <87cyvsxn8u.fsf@sappc2.fritz.box> <83jzpz68yb.fsf@gnu.org> Reply-To: Jens Schmidt Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9165"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: 67462@debbugs.gnu.org To: Eli Zaretskii , dmitry@gutov.dev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 30 21:41:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r8nqY-0002Bb-3i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Nov 2023 21:41:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8nqI-0004CR-45; Thu, 30 Nov 2023 15:41:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8nqC-000433-Vx for bug-gnu-emacs@gnu.org; Thu, 30 Nov 2023 15:40:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8nqA-0008FX-Ai for bug-gnu-emacs@gnu.org; Thu, 30 Nov 2023 15:40:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r8nqI-0001o3-Aa for bug-gnu-emacs@gnu.org; Thu, 30 Nov 2023 15:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jens Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Nov 2023 20:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67462 X-GNU-PR-Package: emacs Original-Received: via spool by 67462-submit@debbugs.gnu.org id=B67462.17013768516914 (code B ref 67462); Thu, 30 Nov 2023 20:41:02 +0000 Original-Received: (at 67462) by debbugs.gnu.org; 30 Nov 2023 20:40:51 +0000 Original-Received: from localhost ([127.0.0.1]:54550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8nq7-0001nS-8F for submit@debbugs.gnu.org; Thu, 30 Nov 2023 15:40:51 -0500 Original-Received: from mr5.vodafonemail.de ([145.253.228.165]:39958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8nq4-0001nD-Iz for 67462@debbugs.gnu.org; Thu, 30 Nov 2023 15:40:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1701376834; bh=+h4L0bTvQ9bOs/hvGAdY5mdlJMQI488ZKM0NwZbITCs=; h=From:To:Subject:References:Date:In-Reply-To:Message-ID:User-Agent: Content-Type:From; b=1ExIIFpL7t5UsRK97yTuJ/qw9gZW9JB2DBFMM27E/Ufvw4ExEiK0B7OJ/ZWjip8wO YFNsbTfP9m5HWbDIqMYZ6bAu1uMXojK0zM10dj/6LiLOgDkUM0yIU3EtlNaXbAFAL3 GVJmXyuKqq6zrXqESKOCwqo4IVHQoL5vNDZK46WQ= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr5.vodafonemail.de (Postfix) with ESMTPS id 4Sh7PG18Ybz1y26; Thu, 30 Nov 2023 20:40:33 +0000 (UTC) Original-Received: from sappc2 (port-83-236-37-230.dynamic.as20676.net [83.236.37.230]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Sh7P338XmzHnfq; Thu, 30 Nov 2023 20:40:20 +0000 (UTC) In-Reply-To: <83jzpz68yb.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 30 Nov 2023 08:39:40 +0200") X-purgate-type: clean X-purgate: clean X-purgate-size: 1185 X-purgate-ID: 155817::1701376829-76FF8693-3820F504/0/0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275294 Archived-At: Eli Zaretskii writes: >> From: Jens Schmidt >> Cc: 67462@debbugs.gnu.org, dmitry@gutov.dev >> Date: Wed, 29 Nov 2023 22:28:49 +0100 >> >> No, indent-region does a good job and there is nothing to fix here. But >> starting with Emacs 30 it does that job (also) on M-q, where previously >> other functionality may have been bound. >> >> To see the difference, please try executing in Emacs 29 vs master on >> Emacs's own, configured Makefile: >> >> ./src/emacs -Q Makefile --eval '(search-forward "SUBDIR_MAKEFILES_IN")' >> M-q > > So the problem is that the new code does its job, just with different > results than the mode-specific fill-paragraph-function did in Emacs 29 > and before? Yes. > If so, perhaps we should offer a user option to let users choose which > method to use, because some might prefer the new behavior? I'd be fine with that, and also with making the new behavior the default. A reference to that user option would also nicely complete the NEWS entry, which IMO currently is a bit weak in mentioning the possible consequences of the new feature. Dmitry, what do you think?