From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#66394: 29.1; Make register-read-with-preview more useful Date: Sun, 03 Dec 2023 14:35:37 +0000 Message-ID: <87fs0jtkue.fsf@posteo.net> References: <87il7ib6cu.fsf@posteo.net> <87ttqgpjiz.fsf@posteo.net> <87wmvbibpr.fsf@web.de> <877cnb2n63.fsf@posteo.net> <8734xyc8z0.fsf@web.de> <87zg05rewi.fsf@posteo.net> <87ttqcg8gw.fsf@web.de> <87h6mcr8ol.fsf@posteo.net> <87r0l73029.fsf@web.de> <877cmdx8ud.fsf@posteo.net> <87sf50s1gh.fsf@posteo.net> <83o7ficesp.fsf@gnu.org> <878r6leh9d.fsf@posteo.net> <83il5pbnmh.fsf@gnu.org> <87zfz1cz7s.fsf@posteo.net> <83bkbc7j1o.fsf@gnu.org> <8734wov2wv.fsf@posteo.net> <83v89j6arv.fsf@gnu.org> <87cyvpf8y6.fsf@posteo.net> <83plzp82mb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18365"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, 66394@debbugs.gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 03 15:37:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r9nat-0004al-Q0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Dec 2023 15:37:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r9naZ-0004cB-5M; Sun, 03 Dec 2023 09:36:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9naW-0004bg-SB for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 09:36:52 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r9naW-00050s-Jv for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 09:36:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r9nag-00027x-1p for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 09:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Dec 2023 14:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66394 X-GNU-PR-Package: emacs Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.17016141658107 (code B ref 66394); Sun, 03 Dec 2023 14:37:02 +0000 Original-Received: (at 66394) by debbugs.gnu.org; 3 Dec 2023 14:36:05 +0000 Original-Received: from localhost ([127.0.0.1]:59299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9nZl-00026g-5H for submit@debbugs.gnu.org; Sun, 03 Dec 2023 09:36:05 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:48455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9nZg-00026F-8l for 66394@debbugs.gnu.org; Sun, 03 Dec 2023 09:36:03 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id AF900240101 for <66394@debbugs.gnu.org>; Sun, 3 Dec 2023 15:35:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1701614143; bh=DllXmnpZkIHlFeITtwaZcqHwkiAiDFH+gNXjKJYQ1ow=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Autocrypt:OpenPGP: From; b=ExOR/x+Bv4XSi30Df+BSU3HuDhjNJRd8oTECZj9cUoHmEYgsOtox6IC9DSbBFrjge mu14retOuYXqZ09JrPybFuuETTXwHbitabBYBGacZLYvx9MU2xUtiu/RWZe1OSnn00 YKWrnNNjpAaXym9ouwMP5f21TPduuIGtWvJUMTPRSCOnw+hyAXWXX6J4j/x1OYCAIM m0G3J9UZaJc8c9jwiV7Np7yVId2xDmvWZbhX2WJ2kQHSUdA3EuxD7VuRYSVngPaQx8 tXyKPqnht9aSsMxoNSoyic1xO9q/jRc2iWBjnu/aQeO75eqYMj/ZgwmbmLtincEUS3 Tv+g/5AxJ8fVg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Sjq8s0ryWz6tmv; Sun, 3 Dec 2023 15:35:40 +0100 (CET) In-Reply-To: <83plzp82mb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Dec 2023 09:50:20 +0200 (1 day, 6 hours, 42 minutes ago)") Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaA OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275419 Archived-At: --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello Eli, Eli Zaretskii writes: >> From: Thierry Volpiatto >> Cc: monnier@iro.umontreal.ca, michael_heerdegen@web.de, >> stefankangas@gmail.com, 66394@debbugs.gnu.org >> Date: Sat, 02 Dec 2023 05:51:45 +0000 >>=20 >> Eli Zaretskii writes: >>=20 >> > Anyway, I trust you to do what is needed here, I just want the test >> > suite to keep running successfully, and I don't have time to work on >> > this myself. TIA. >>=20 >> Here again the patchs (0002 with a little modification). >> Let me know if I can commit them. > > Please install on the master branch, and thanks. Here another change related to the discussion in previous posts. If no objections I will merge it in next days. Thanks. =2D-=20 Thierry --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Exit-with-no-confirmation-RET-when-register-use-prev.patch Content-Transfer-Encoding: quoted-printable From=20ff8f43a39e2cee1f71629194d44c7459f2b90d79 Mon Sep 17 00:00:00 2001 From: Thierry Volpiatto Date: Sun, 3 Dec 2023 15:21:50 +0100 Subject: [PATCH] Exit with no confirmation (RET) when register-use-preview is non nil and . This is done by exiting minibuffer when selected register is empty or when just jumping or inserting. * lisp/register.el (register-read-with-preview): Do it. =2D-- lisp/register.el | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/lisp/register.el b/lisp/register.el index 46ec38821e5..a38b531dfc9 100644 =2D-- a/lisp/register.el +++ b/lisp/register.el @@ -385,12 +385,16 @@ display such a window regardless." (minibuffer-message "Register `%s' is empty" pat)))))) (unless (string=3D pat "") =2D (if (member pat strs) =2D (with-selected-window (minibuffer-wind= ow) =2D (minibuffer-message msg pat)) =2D (with-selected-window (minibuffer-window) =2D (minibuffer-message =2D "Register `%s' is empty" pat))))))))) + (with-selected-window (minibuffer-window) + (if (and (member pat strs) (memq act '(set= modify))) + (with-selected-window (minibuffer-wind= ow) + (minibuffer-message msg pat)) + ;; An empty register or an existing + ;; one but the action is insert or + ;; jump, don't ask for confirmation + ;; and exit immediately (bug#66394). + (setq result pat) + (exit-minibuffer))))))))) (setq result (read-from-minibuffer prompt nil map nil nil (register-preview-get-de= faults act)))) (cl-assert (and result (not (string=3D result ""))) =2D-=20 2.34.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmVskjoTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvkxoEDAChi58yVRc2pe09GHvseT5KbFl5gPuZ wYe+QmXL1HlYPgLsOLJuQHSOgSTnkLjjyLJ37MxO1q+suLbJTw80h7ly8loJJyEu RGUqYfTRqcw6I3LzkKU2uhPsiUIrY78UaWkDBGsMlbLhezLwHbAvzICDGozIqMX2 OKd6+iXKsWoD6NIbT89bPwoiX9hPdPckaoxMGaFCc3QJt7WExhWE31P7CvdRSrhR KWniz0N0bdVfxADI3Q/bJXf22pp6so/nPkhS8c5JPU4xUrDyjOqc4791wlNdbIL1 N+FWCclzx+3YK9zq5a7a4rGLxKh2Bg2twrtD5nX2WED11v2mZLR5IrgZ9rQcJE5z NLRvvZG5uaNwG665FwggX7oeio16g1mucpKyceV8T0oazfDDkFRWLs8NIGdP2kyn yCqIkQrZdXt/9jYHS5nul0mUSCZxVbwOdyo8t1qy2gw+H+BbD5zJOKGoPvVwHcpc +HpMh8qOnaYiwXl4pwYDje5KevLa+QsNWRk= =vaYr -----END PGP SIGNATURE----- --==-=-=--