From: Ihor Radchenko <yantar92@posteo.net>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: Bastien <bzg@gnu.org>, emacs-orgmode@gnu.org
Subject: [PATCH] Change the default value of org-attach-store-link-p to 'attached
Date: Sat, 20 Jan 2024 15:21:38 +0000 [thread overview]
Message-ID: <87frys58u5.fsf@localhost> (raw)
In-Reply-To: <878sdrm1em.fsf@localhost>
[-- Attachment #1: Type: text/plain, Size: 254 bytes --]
Ihor Radchenko <yantar92@gmail.com> writes:
>> Feel free to propose a patch for this and the suggested switch, we can
>> apply it after Org 9.4.
>
> I will add it to my todo list. This should be lower priority than org-fold.el
See the attached patch.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-attach-store-link-p-Change-default-value-to-atta.patch --]
[-- Type: text/x-patch, Size: 1845 bytes --]
From 175937da259fe0b29057d69055bf3469aa1a8679 Mon Sep 17 00:00:00 2001
Message-ID: <175937da259fe0b29057d69055bf3469aa1a8679.1705764051.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Sat, 20 Jan 2024 16:20:20 +0100
Subject: [PATCH] org-attach-store-link-p: Change default value to 'attached
* lisp/org-attach.el (org-attach-store-link-p): Change the default
value.
* etc/ORG-NEWS (The default value of ~org-attach-store-link-p~ is now
~attached~): Announce the change.
---
etc/ORG-NEWS | 5 +++++
lisp/org-attach.el | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index 847ddf614..ea456c67b 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -371,6 +371,11 @@ The change is breaking when ~org-use-property-inheritance~ is set to ~t~.
The =TEST= parameter is better served by Emacs debugging tools.
** New and changed options
+*** The default value of ~org-attach-store-link-p~ is now ~attached~
+
+Now, after attaching a file, =[[attach:...]]= link to the attached file
+is stored. It can later be inserted using =M-x org-insert-link=.
+
*** New option ~org-fast-tag-selection-maximum-tags~
You can now limit the total number of tags displayed in the fast tag
diff --git a/lisp/org-attach.el b/lisp/org-attach.el
index 58bfcf9ba..81ce9a73c 100644
--- a/lisp/org-attach.el
+++ b/lisp/org-attach.el
@@ -142,7 +142,7 @@ (defcustom org-attach-use-inheritance 'selective
(const :tag "Inherit parent node attachments" t)
(const :tag "Respect org-use-property-inheritance" selective)))
-(defcustom org-attach-store-link-p nil
+(defcustom org-attach-store-link-p 'attached
"Non-nil means store a link to a file when attaching it.
When t, store the link to original file location.
When `file', store link to the attached file location.
--
2.43.0
[-- Attachment #3: Type: text/plain, Size: 224 bytes --]
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2024-01-20 15:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 4:19 Default value and docstring of org-attach-store-link-p Ihor Radchenko
2020-09-03 10:33 ` Bastien
2020-09-03 13:32 ` Ihor Radchenko
2024-01-20 15:21 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frys58u5.fsf@localhost \
--to=yantar92@posteo.net \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.