From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68805: 29.2; Tramp: out-of-band copy-file fails when tramp-copy-keep-date is nil Date: Thu, 01 Feb 2024 14:29:12 +0100 Message-ID: <87frycgvo7.fsf@gmx.de> References: <59B29F53-DEE4-4DDD-BC68-8BB16652633E@toadstyle.org> Reply-To: Michael Albinus Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29962"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 68805@debbugs.gnu.org To: Sean Devlin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 01 14:30:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVX8u-0007Vy-6u for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Feb 2024 14:30:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVX8b-0007nv-TX; Thu, 01 Feb 2024 08:29:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVX8a-0007ni-EI for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 08:29:52 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVX8a-0006dv-6N for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 08:29:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rVX8k-0002vl-9e for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 08:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Feb 2024 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68805 X-GNU-PR-Package: emacs Original-Received: via spool by 68805-submit@debbugs.gnu.org id=B68805.170679417411199 (code B ref 68805); Thu, 01 Feb 2024 13:30:02 +0000 Original-Received: (at 68805) by debbugs.gnu.org; 1 Feb 2024 13:29:34 +0000 Original-Received: from localhost ([127.0.0.1]:40599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVX8H-0002uY-Mu for submit@debbugs.gnu.org; Thu, 01 Feb 2024 08:29:33 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:58997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVX8E-0002uK-5W for 68805@debbugs.gnu.org; Thu, 01 Feb 2024 08:29:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1706794153; x=1707398953; i=michael.albinus@gmx.de; bh=3Qio+b53kat0kSxKgGEphTIB5KmaVApBrmTPIv92XLg=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=KRSNG1mrp2VTV02B+1F6Nij6C86wdc3UDWdsZq6+VbrzJAtDd0EKms1ABXDiGXki OfJKC4Fdv/XnUT8H11EEJnJWQbQsgjgPMswcDhDtgHaA07jyw0PYMe9x6Dj5+pofL yXQ5xTDRHN6DDNQvno75AviXzIYyPpJD1rvMFNuEwx+ssfH1tLuvsuw+g1/MAEtq6 Ws6K2HSm0BA8fBmISje2OU1b9n9VOZinvtChBCdd37QDQf23/53NG+6oA0nAv40uh 4HyLkXxxLJmqAK0f1e4tTdRAvvMZY+wuk3hXoKRvav0WgZHBzFhNU1N8KCDAlVdOQ Flgdwi+TTwKGMnlMRQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mf0BG-1qp1Zj1oOA-00gXZs; Thu, 01 Feb 2024 14:29:13 +0100 In-Reply-To: <59B29F53-DEE4-4DDD-BC68-8BB16652633E@toadstyle.org> (Sean Devlin's message of "Mon, 29 Jan 2024 17:26:41 -0500") X-Provags-ID: V03:K1:JlnGcyBmJWSqy3+OwHrXk1VCjvWWRXmJ1myMxnBKeICa7BCBWSr EJSHRa+ggC1J5Z/UQtbgzEFq+Gg3VZU7160waZ9tzZUmehwOIhUGNo73PKA3Pc2ov3Erhux aYUxPuAbsE2KgJZ1uRPcF1WxX/ld5idH1xMMoEj763nS3DPckuyGzaqgE/70eUY7Xq9udwr 4WfQdyLobP5+tXWtbmq5A== UI-OutboundReport: notjunk:1;M01:P0:Ajq9l0sy520=;2jhj1lE3TkIWzWUhvDSLwO7tQWT BM7pxFDUdOFjtKiGi4IH8QMfYZ22RlVVKWXmKsxgSBX5Q/4EgxVR5ejZBOmwmfnunM4wFH+sV ZAZlBHqihOkJ1mwteSVfNHFTRZ+o9bTf6KSFs/SbqM0pJ07d+7ixkEgk8XZ5rhDYJw5G0HuNg SBHPG9YNEM1gSNb6DgnBoovZ/AUgCrHGxsfoDsZ0orWgV74y3rUs+v26B/qdqc3qtqVidp4ZD Z2uJOB7Zgr77iV6Y5k1pjHr3b7++uPdlP422pV5MBpHi9M/HLELw1+ReENMulLwj3IDBf6TJB Z+KsVJKy5lH1ZfPuAVWXXKABioFvXcWcibGUibvXRlx6sY7YI07tekTdliqclT7O4Rf8iASk6 5z3CNLj1numUKOAZcA4boNS26UyZ97Z8XZWNxZrHM3xEdSYHKbdR9OHjfVyVLNggCY9MmMrMm V1gEqD1TKkKL1KHJs3FhjreqFKNusM1fufc0yQGs/U1DF9rHQVEIzVqIO+T9qDh6fBG861Ub6 ibVJyWcuqZSDoOZLQltfIED3vd1d0obwH3EPN0YEBeZOUPOXhzTzVXPzZzRUyFf6XGNerkde7 h9OshQdKve8Fq9iPmEYT6RqAJ6amnjSmQn7Zl2mJcZm2L19v6H10YaJk7jNolQ9OFSPbpmsPK Vdsjglo57dM1TTX2glYz0EkttMfQ+zm0ZleSim9mntIRxsCmAbMVcIAEEk0YUKQWi4tQlx7yu 5XO0iQBVNWpXBlK5HZ/FeWsEs9Dz/S/RXS8V3W2s87SR9sGqYeV3472pZiUWzQ8/AjNLLoCO X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279289 Archived-At: --=-=-= Content-Type: text/plain Sean Devlin writes: > Hi folks, Hi Sean, > I think the issue is due to caching. Before copying, Tramp checks to see > if the file exists, and it does not. After the transfer, Tramp tries to > check again because the keep-date argument was set, tramp-copy-keep-date > is nil or unset, and Tramp wants to set the file time manually. Instead > of actually doing this file existence check, Tramp instead gets the > property from cache that was set just prior to the file transfer. It > then raises a file-missing error. Thanks for the report and the analysis. It is correct. Could you please check, whether this patch fixes it: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Transfer-Encoding: quoted-printable diff --git a/lisp/tramp-sh.el b/lisp/tramp-sh.el index 1301cd63..50a33cc3 100644 =2D-- a/lisp/tramp-sh.el +++ b/lisp/tramp-sh.el @@ -2521,6 +2521,10 @@ The method used must be an out-of-band method." ;; cached password). (tramp-cleanup-connection v 'keep-debug 'keep-password)))) + ;; The cached file properties might be wrong if NEWNAME didn't + ;; exist. Flush them. + (tramp-flush-file-properties v (tramp-file-local-name newname)) + ;; Handle KEEP-DATE argument. (when (and keep-date (not copy-keep-date)) (tramp-compat-set-file-times --=-=-= Content-Type: text/plain > Thanks, > > Sean Best regards, Michael. --=-=-=--