From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?J=C3=B6rg?= Bornemann Newsgroups: gmane.emacs.bugs Subject: bug#69087: [PATCH] ; Resolve a FIXME in rst.el Date: Mon, 12 Feb 2024 22:10:26 +0100 Message-ID: <87frxxmlrx.fsf@jbornemann.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15082"; mail-complaints-to="usenet@ciao.gmane.io" To: 69087@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 12 22:26:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZdoU-0003eK-2j for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Feb 2024 22:26:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZdoC-0007xB-My; Mon, 12 Feb 2024 16:25:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZdo9-0007wr-UY for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 16:25:45 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZdo9-00018o-M0 for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 16:25:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZdoQ-00085X-Ev for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 16:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?J=C3=B6rg?= Bornemann Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2024 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 69087 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170777310330813 (code B ref -1); Mon, 12 Feb 2024 21:26:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Feb 2024 21:25:03 +0000 Original-Received: from localhost ([127.0.0.1]:60481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZdnQ-00080S-Rm for submit@debbugs.gnu.org; Mon, 12 Feb 2024 16:25:03 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:49720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZdZq-0006ud-JW for submit@debbugs.gnu.org; Mon, 12 Feb 2024 16:10:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZdZS-0003F5-NR for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 16:10:34 -0500 Original-Received: from ms-10.1blu.de ([178.254.4.101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZdZP-0006l2-QX for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 16:10:34 -0500 Original-Received: from [79.242.79.138] (helo=barf.jbornemann.de) by ms-10.1blu.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rZdZK-007UAp-Rp for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 22:10:26 +0100 X-Con-Id: 36794 X-Con-U: 0-foss X-Originating-IP: 79.242.79.138 Received-SPF: pass client-ip=178.254.4.101; envelope-from=foss@jbornemann.de; helo=ms-10.1blu.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 12 Feb 2024 16:24:59 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279931 Archived-At: --=-=-= Content-Type: text/plain Tags: patch This patch resolves a trivial FIXME in rst.el. In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-01-18 built on barf Repository revision: ef01b634d219bcceda17dcd61024c7a12173b88c Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12201009 System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --prefix /usr/local --with-x-toolkit=gtk3 --with-xwidgets --with-imagemagick --with-json --with-tree-sitter --with-small-ja-dic --with-native-compilation' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Resolve-a-FIXME-in-rst.el.patch >From d4cc0fe4ddfe016e76516370d742a67c29b66690 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Bornemann?= Date: Mon, 12 Feb 2024 21:56:42 +0100 Subject: [PATCH] ; Resolve a FIXME in rst.el * lisp/textmodes/rst.el (rst-define-key): Use :documentation for the dynamically created docstrings of deprecated bindings. --- lisp/textmodes/rst.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/textmodes/rst.el b/lisp/textmodes/rst.el index 2cd78943883..5fbff4ba888 100644 --- a/lisp/textmodes/rst.el +++ b/lisp/textmodes/rst.el @@ -1147,14 +1147,14 @@ rst-define-key (unless (fboundp forwarder-function) (defalias forwarder-function (lambda () + (:documentation + (format "Deprecated binding for %s, use \\[%s] instead." + def def)) (interactive) (call-interactively def) (message "[Deprecated use of key %s; use key %s instead]" (key-description (this-command-keys)) - (key-description key))) - ;; FIXME: In Emacs-25 we could use (:documentation ...) instead. - (format "Deprecated binding for %s, use \\[%s] instead." - def def))) + (key-description key))))) (dolist (dep-key deprecated) (define-key keymap dep-key forwarder-function))))) -- 2.39.2 --=-=-=--