From: Nicolas Graner <nicolas@graner.name>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 70338@debbugs.gnu.org
Subject: bug#70338: message-fcc-externalize-attachments has no effect
Date: Mon, 22 Apr 2024 06:19:30 +0200 [thread overview]
Message-ID: <87frve9gh9.fsf@graner.name> (raw)
In-Reply-To: <878r17h839.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Sat, 20 Apr 2024 17:28:58 -0700)
Yes, your patch works for me.
Great, thanks!
Nicolas
Eric Abrahamsen <eric@ericabrahamsen.net> wrote on 2024-04-20 17:28:
> On 04/20/24 19:29 PM, Nicolas Graner wrote:
>> Eric Abrahamsen <eric@ericabrahamsen.net> wrote on 2024-04-20 08:36:
>>> So far I don't see that this option would actually do anything in an FCC
>>> context. `message-fcc-externalize-attachments' is only used in
>>> `message-do-fcc`, where its value is let-bound to
>>> `mml-externalize-attachments'.
>>>
>>> But `mml-externalize-attachments' is only consulted in
>>> `gnus-inews-do-gcc', which already doesn't sound very promising. That
>>> function first let-binds `mml-externalize-attachments' to nil, before
>>> doing its own setting, so any dynamic value is getting overridden
>>> anyway.
>>>
>>> I tried starting with `gnus-gcc-externalize-attachments' and sending a
>>> message with an attachment, just to see how it's supposed to work.
>>> Nothing seemed to happen.
>>>
>>> Can you tell me what the desired effect is supposed to be? Does the
>>> "gcc" version of this option work for you?
>>>
>>> Eric
>>
>> When you attach a file to a mail message you are writing, only an anchor
>> with the file name is inserted in the message buffer. When the message
>> is sent, the anchor is replaced with the actual MIME-encoded contents of
>> the attached file. The copy of the message that is written to the FCC
>> file also includes the MIME-encoded attached file.
>>
>> I was expecting that externalization would mean that the copy in the FCC
>> file would only include an anchor rather than the attachment, which
>> would be extremely useful. I must admit this was only a guess (wishful
>> thinking?) since the documentation is not explicit at all.
>
> Oh, that sounds very useful, I've often wanted that.
>
>> I don't use gnus. To test the gnus version of the variable, I guess I
>> would need access to a free, public NNTP server, which I don't know
>> where to find. Can you help?
>
> I think most of us use news.gmane.io
>
> I tested the GCC version again (now that I know what it's supposed to
> do), and it did work -- the version of the message in my Sent folder had
> a mime part of "message/external-body".
>
> Long story short, the encoded body of the message is cached during
> sending, and the cached version is re-used during GCC/FCC handling. If
> the user has requested the externalization of attachments, the GCC
> version of the code knows to use that as a flag to dump the cache and
> re-generate it with externalized attachments; the FCC code doesn't do
> the equivalent.
>
> I've pushed a change that fixes this issue in my testing -- are you
> using Emacs master? If not, I've attached the commit here, I hope you'll
> be able to test it.
>
> Thanks,
> Eric
next prev parent reply other threads:[~2024-04-22 4:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 12:39 bug#70338: message-fcc-externalize-attachments has no effect Nicolas Graner
2024-04-18 10:11 ` Eli Zaretskii
2024-04-20 15:36 ` Eric Abrahamsen
2024-04-20 16:20 ` Eli Zaretskii
2024-04-20 16:22 ` Eric Abrahamsen
2024-04-20 17:29 ` Nicolas Graner
2024-04-21 0:28 ` Eric Abrahamsen
2024-04-22 4:19 ` Nicolas Graner [this message]
2024-04-22 4:27 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frve9gh9.fsf@graner.name \
--to=nicolas@graner.name \
--cc=70338@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.