From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Steven Allen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70927: Acknowledgement (30.0.50; track-changes assertion when shutting down eglot) Date: Wed, 15 May 2024 13:51:07 -0700 Message-ID: <87frui6bpg.fsf@stebalien.com> References: <871q65xsi6.fsf@stebalien.com> <87y18dwdri.fsf@stebalien.com> Reply-To: Steven Allen Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6790"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70927@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 15 22:52:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s7Lbw-0001VF-4k for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 May 2024 22:52:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7LbX-0003Em-Fz; Wed, 15 May 2024 16:52:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7LbU-0003EE-8m for bug-gnu-emacs@gnu.org; Wed, 15 May 2024 16:52:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7LbT-0006jI-W3 for bug-gnu-emacs@gnu.org; Wed, 15 May 2024 16:52:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s7LbV-0007VK-LO for bug-gnu-emacs@gnu.org; Wed, 15 May 2024 16:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 May 2024 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70927 X-GNU-PR-Package: emacs Original-Received: via spool by 70927-submit@debbugs.gnu.org id=B70927.171580628428840 (code B ref 70927); Wed, 15 May 2024 20:52:01 +0000 Original-Received: (at 70927) by debbugs.gnu.org; 15 May 2024 20:51:24 +0000 Original-Received: from localhost ([127.0.0.1]:44392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7Las-0007V6-IM for submit@debbugs.gnu.org; Wed, 15 May 2024 16:51:24 -0400 Original-Received: from fout5-smtp.messagingengine.com ([103.168.172.148]:56883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7Lao-0007Ux-Qk for 70927@debbugs.gnu.org; Wed, 15 May 2024 16:51:21 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.nyi.internal (Postfix) with ESMTP id 71028138113A; Wed, 15 May 2024 16:51:11 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 15 May 2024 16:51:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1715806271; x= 1715892671; bh=Mr/H3LNAvfZ/1124ByT7ZodWKmhrXBEyJciAmnqcuac=; b=Z JfPNNp7beKm9U4x/F/JPDZpJkkvl9M6kqUhXtVjsnjGv6oxnAqVTPyds5goEpGbp beykVJXxEObrlYW7yuStNSFRloSHTxy26GQbZpINfPM8NBvHOV9qRXy2uO7YMToQ PTFO5K50K5Q6ozNUQTB3spbVM/I+gTFi88em0F8aUL1ESd++QNVbnZNEmXJkVENG dPXyqD+cqa3RHmpWKEZ1lP+0xmDhTKak3ZS+wHTLTZ5i7u4TS4YaqqW5KqJs97Nv Md8yLgP2IiR/2YbipJPjeJSkmY4paSS5X2a6x7TpaxfwAW7r3cQLLCQDOWD5sztx Q3ARaNxAuwZciHANyCOVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1715806271; x=1715892671; bh=Mr/H3LNAvfZ/1124ByT7ZodWKmhr XBEyJciAmnqcuac=; b=gYdT0ISiQrNUlNWqlGFyRdSSRVYgunstkaqFTatImrOC G6Ob892Nh51nzEWJ5SkQ5Bf/cnkYDTiKvI7RaOt8vGhrbFR42Md29YrVjVLDpEtD NOmreJft918yTz0T/XxpiysYAPVgnQwuRl+suPUi+R7boWom47xLV7SnixBJyEH+ uvKeuS0xnSzT0t9hsB0U+MCqIgQ4W3V8XhgVQDO2vmHsboQrapCmpO70RQiJAWGh C7GK5kROSd89kLAbGtm5XiPwS4v8b5b/VvAOjBXwgy/NoYxRg7gSDjn+yDwLOKXY k5WpMdr0Z19T4/HaP+hr1MhgDDslXUWbtkt1Oy3w7g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdegkedgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepufhtvghv vghnucetlhhlvghnuceoshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmqeenucggtf frrghtthgvrhhnpedvkeehkeegleehheeggfduleektefhhffgueffteekgedtvdefuddu tddtjeejvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomh X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 May 2024 16:51:10 -0400 (EDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285122 Archived-At: Stefan Monnier writes: > Indeed. I pushed the patch below to `master` instead which should also > fix the problem. Please confirm that it fixes it for you as well. > Maybe `eglot-shutdown` shouldn't end up calling > `eglot--signal-textDocument/didChange` at all, but that's a long > standing behavior AFAICT, so I'll leave it for some other time. The fix works for me. Thanks!