From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: master fa4203300fd: Merge remote-tracking branch 'origin/feature/which-key-in-core' Date: Mon, 24 Jun 2024 20:23:32 +0000 Message-ID: <87frt22ipn.fsf@posteo.net> References: <171873998859.23986.6867742580209068033@vcs2.savannah.gnu.org> <20240618194635.AC606C1FB66@vcs2.savannah.gnu.org> <87sex2qh25.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35556"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 24 22:24:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLqEe-00090r-QM for ged-emacs-devel@m.gmane-mx.org; Mon, 24 Jun 2024 22:24:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLqE1-00068H-Tj; Mon, 24 Jun 2024 16:23:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLqE0-000682-21 for emacs-devel@gnu.org; Mon, 24 Jun 2024 16:23:40 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLqDx-0004PQ-Qy for emacs-devel@gnu.org; Mon, 24 Jun 2024 16:23:39 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 80761240101 for ; Mon, 24 Jun 2024 22:23:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1719260614; bh=m9ft/D8zHMVQ+1aQzx1m8KD+S3cWCh6BwbDh7vJ6bbw=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=UVHSYbtCA/s4hFkf51iAxsvbHO99rUtyxbuBGz3en1u433HFPNHe3GmeF+LDneVkV Mo3mWbIpUjz7j0Kt2luI4mAq+eUh+jknd3fMLZp9OeV6ZQLjF21trdnSXs3Xhy4CQR l8vci7wSEYR0OSGVXJscWy7B3HEq6eL6Kcsjt/wYYpVSqF300l7K2NJqwazifjOiUS qtYECR1jJ3AS8OxLbIcH76P6GE7W1Jb+w15ZzILakwCVFHI734cBgmICPXAudlspvm rC+e30mXjVqHzxUg6E+mGw0e1IFXMvH7JT3vUK9Nc9tZsBjVk26+zEW6P0gwC2MvvN Y9uB3aHwDD6KQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W7KD43vzRz6tlh; Mon, 24 Jun 2024 22:23:32 +0200 (CEST) In-Reply-To: <87sex2qh25.fsf@gmx.de> (Michael Albinus's message of "Mon, 24 Jun 2024 21:25:22 +0200") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320619 Archived-At: --=-=-= Content-Type: text/plain Michael Albinus writes: > Philip Kaludercic writes: > >> branch: master >> commit fa4203300fde6820a017bf1089652fb95759d68c >> Merge: a7dff8c53dd cc0a3a5f65b >> Author: Philip Kaludercic >> Commit: Philip Kaludercic >> >> Merge remote-tracking branch 'origin/feature/which-key-in-core' >> --- >> etc/NEWS | 7 + >> lisp/which-key.el | 2814 ++++++++++++++++++++++++++++++++++++++++++ >> test/lisp/which-key-tests.el | 267 ++++ >> 3 files changed, 3088 insertions(+) > > Seen in the emacs-30 branch: > > # make -C test test-custom-opts > ... > The following options might have problems: > variable: which-key-separator > value: nil > type: (string) > variable: which-key-ellipsis > value: nil > type: (string) > ... > FAILED 1/1 check-for-wrong-custom-opts (39.873179 sec) at misc/test-custom-opts.el:33 > > Ran 1 tests, 0 results as expected, 1 unexpected (2024-06-24 21:14:57+0200, 40.332174 sec) > > 1 unexpected results: > FAILED check-for-wrong-custom-opts This should fix the issue: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-which-key.el-which-key-dont-use-unicode-Add-ini.patch >From c707ba33a4c3b1de7cb7e8c35736e48ced81a0e0 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Mon, 24 Jun 2024 22:15:25 +0200 Subject: [PATCH] ; * lisp/which-key.el (which-key-dont-use-unicode): Add :initialize This fixes the change from 768e92b9, which accidentally would call 'custom-reevaluate-setting' on user options before they were registered, initialising their default value to nil. When the 'defcustom' expressions were evaluated later on, they were not properly initialised as their variables were already bound to some value (nil). https://lists.gnu.org/archive/html/emacs-devel/2024-06/msg00825.html --- lisp/which-key.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/which-key.el b/lisp/which-key.el index 91007ce4ada..8b78bfb2576 100644 --- a/lisp/which-key.el +++ b/lisp/which-key.el @@ -133,6 +133,7 @@ which-key-dont-use-unicode (mapc #'custom-reevaluate-setting '(which-key-separator which-key-ellipsis))) + :initialize #'custom-initialize-changed :type 'boolean :package-version "1.0" :version "30.1") -- 2.45.2 --=-=-= Content-Type: text/plain -- Philip Kaludercic on peregrine --=-=-=--