From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: MPS: dangling markers Date: Fri, 28 Jun 2024 16:37:41 +0000 Message-ID: <87frsx81m2.fsf@localhost> References: <87v81u85hv.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21656"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , emacs-devel@gnu.org, Eli Zaretskii , eller.helmut@gmail.com To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 28 18:36:58 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNEan-0005Lt-NB for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Jun 2024 18:36:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNEa4-0004Ff-Lz; Fri, 28 Jun 2024 12:36:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNEa2-0004FT-S6 for emacs-devel@gnu.org; Fri, 28 Jun 2024 12:36:10 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNEZz-0003u4-TJ for emacs-devel@gnu.org; Fri, 28 Jun 2024 12:36:09 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A64F9240027 for ; Fri, 28 Jun 2024 18:36:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1719592564; bh=La3K7u7am86IixLRve5oCDssRoktsqaxJtaXnizO5m8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=UkzdmBxPXWZM5DwrJ4PSsB6nMrgEF3cVnddujH87yhIlSg2FdTlBjnG+9dpp0Puaa mRoeh4krjAZ6gJx6geuyxJ0x72fpC2k4+QBzawkrQXY12eVf1kiV0dV+ItNqYZ4OwY XBmNPuRS43cN05Fzb9Bb6XPF46KLdrVpRVEC0UQ6HyevUueDLKnwoJ2DFMhtfq/kLX 0XUJY06AWBhmki99NGkMCF8SLPdoAL3ZgysXcyOmFmYgxg4WLC46Z+/iASkcpH/ppA dzoPxBv6k83TRWA9VX74rI7ofPTFwRMSJ5wzFK/O7Hk2f7pG2BFP1Wmt/AoajC4B8N T3GhP+WWWsdrQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W9gzl0N9Sz6twp; Fri, 28 Jun 2024 18:36:03 +0200 (CEST) In-Reply-To: Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320824 Archived-At: Gerd M=C3=B6llmann writes: >> AFAIK, markers are the only one that can be reachable (i.e. we may >> spend time looking at them) yet GC-able, because the buffers' `markers` >> slot contains a linked-list of all markers that's treated specially by >> the GC (basically, the list is "weak" so markers get removed from this >> list during GC if the marker is reachable only from the list). > > Exactly. I looked closer into the version of buf_charpos_to_bytepos in scratch/igc, and I notice that # define DO_MARKERS(b, m) \ for (struct marker_it it_ =3D marker_it_init (b); marker_it_valid (&it_);= \ marker_it_next (&it_)) \ for (struct Lisp_Marker *m =3D marker_it_marker (&it_); m; m =3D NULL) is a double loop, which is different from version of master (master has a single for loop). Inside the loop body, we have /* If we are down to a range of 50 chars, don't bother checking any other markers; scan the intervening chars directly now. */ if (best_above - charpos < distance || charpos - best_below < distance) break; which will break out only from the inner loop, continuing traversal over the full marker list. (I cannot test it for the time being because the latest scratch/igc does not compile for me) --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at