all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Tassilo Horn <tsdh@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>, 72241@debbugs.gnu.org
Subject: bug#72241: 31.0.50; [PATCH] Use a dedicated buffer for `doc-view-open-text'
Date: Tue, 23 Jul 2024 14:00:03 +0200	[thread overview]
Message-ID: <87frs0b9oc.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <87ttggl7dk.fsf@gnu.org> (Tassilo Horn's message of "Tue, 23 Jul 2024 12:39:35 +0200")

Tassilo Horn <tsdh@gnu.org> writes:

[...]

>> Maybe while here, we should clarify how DocView cycles through those 3
>> view: display, edit and text.  Or maybe, there is no 3-states cycling
>> and the "text contents" view is just considered a "side" view.  WDYT?
>
> Here's a state machine describing the current behavior.
>
>     display <-- C-c C-c --> edit
>     \     ^
>      \     \
>  C-c C-t  C-c C-c
>        \     \
>         `> text

I think the current behavior is more like this (I suck at ASCII art):

    display <-- C-c C-c --> edit
    \                      ^
     \                  /--
 C-c C-t            C-c C-c
       \        /--
        `> text

Your state machine is what my patch gives you.

[...]

> However, that now one can switch between foo.pdf and foo.pdf/text
> independently, there is no guarantee that C-c C-c in the foo.pdf/text
> buffer will return to foo.pdf in "display" state.  One could have
> toggled to edit state there or even killed the foo.pdf buffer, so
> there's nothing to return to.

Yes, you're right.  In the latter case (the foo.pdf buffer was killed
otherwise), a C-c C-c in the foo.pdf/text buffer just kill it, go to
another buffer and the document is not open anywhere in any form.  Maybe
it is a not so bad behavior.

> So I'd say: right now it is a state machine with 3 states but with
> Manuel's patch the current "text" state becomes an auxiliary view.

Yes.  So I'm going to try to fix my patch with your remarks (maybe fix
the info also) and come up with a NEWS entry.  Thanks.
-- 
Manuel Giraud





  reply	other threads:[~2024-07-23 12:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22  8:26 bug#72241: 31.0.50; [PATCH] Use a dedicated buffer for `doc-view-open-text' Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-22 18:11 ` Tassilo Horn
2024-07-22 18:29   ` Eli Zaretskii
2024-07-22 18:39     ` Tassilo Horn
2024-07-22 18:48       ` Eli Zaretskii
2024-07-23  8:10       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-23 10:39         ` Tassilo Horn
2024-07-23 12:00           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-07-23 12:16             ` Tassilo Horn
2024-07-23 13:45               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-23 14:32               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-25  6:25                 ` Tassilo Horn
2024-07-23  7:55   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frs0b9oc.fsf@ledu-giraud.fr \
    --to=bug-gnu-emacs@gnu.org \
    --cc=72241@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=manuel@ledu-giraud.fr \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.