From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Suhail Singh Newsgroups: gmane.emacs.devel Subject: Re: Reconsider defaults for use-package-vc-prefer-newest Date: Wed, 25 Sep 2024 16:48:41 -0400 Message-ID: <87frpnbgt2.fsf@gmail.com> References: <87wmj7dftf.fsf@posteo.net> <87setvxyt6.fsf@gmail.com> <87jzf7o13b.fsf@posteo.net> <87msk3jr0u.fsf@gmail.com> <87setum5do.fsf@posteo.net> <87msk1520e.fsf@gmail.com> <87settknf1.fsf@posteo.net> <87tte8akwa.fsf@gmail.com> <878qvjaep6.fsf@posteo.net> <87cykvwixn.fsf@gmail.com> <87ikukrl77.fsf@posteo.net> <871q17dasa.fsf@gmail.com> <8734lnsdcn.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26779"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Suhail Singh , Martin =?utf-8?Q?Edstr=C3=B6?= =?utf-8?Q?m?= , "emacs-devel" , Tony Zorman To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 26 06:50:04 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1stgS4-0006kE-HS for ged-emacs-devel@m.gmane-mx.org; Thu, 26 Sep 2024 06:50:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stgRe-0003rW-Aa; Thu, 26 Sep 2024 00:49:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stYwH-0005aG-RT for emacs-devel@gnu.org; Wed, 25 Sep 2024 16:48:46 -0400 Original-Received: from mail-qv1-xf43.google.com ([2607:f8b0:4864:20::f43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1stYwG-0006ab-0z for emacs-devel@gnu.org; Wed, 25 Sep 2024 16:48:45 -0400 Original-Received: by mail-qv1-xf43.google.com with SMTP id 6a1803df08f44-6cb3062d9a6so786626d6.0 for ; Wed, 25 Sep 2024 13:48:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727297322; x=1727902122; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=K+QHFQuVlLueOYRIb+W42qJrc9tMF3xTLTfwfJpJzuU=; b=I2VaxBz258FGlTeS/QJYB2ouxKlAjyTdqoCnKe6ZWxNvHonGQf22YPvtFb3+ihL6b4 tUUlwWTVtr/USGO1CG189t0iMzGZGv0qFaf6051nQKpzJ1t6/4xLkbGkBSKQpK/USCs5 RmB0o6MrrJB7vfHhHGbikUfZSHRB7H4cERGatvNnnlnU8dOWs74Rcy7PaGhbU46uukaF 1I98npRSHCg0/Csngk1Wfbg21wOQ83tpfmlxo2GKUQKHEPEffjQzH2VzZWomGMN4UVL5 5mVuwS01Y6PsPirmaJ9GPkeIxhQm0RDO88eunvSfgScCOJDBgDjdVNlcCyPfGiGSSjAP 4wDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727297322; x=1727902122; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K+QHFQuVlLueOYRIb+W42qJrc9tMF3xTLTfwfJpJzuU=; b=SmTw4Qj9eHHC3s9Evq5k3Ix/1yC9HyKoinW5UocAF3n26+23Uau5ps4TBiBXYXmusD rSM/qCl984Ty4TRmDzy2mA6Oe9MokgAXB3ptUfQW8/verfzyLWvewRTSFb4Xtw0XoTjk kJH0sG0TD4cc9r1yiq0TPP1XRPM+GKpSJp4wYQtKsGw9vcXqWadts8gMXq59L8HVQcbq TRPzEY/9fployk/jHT4lKb3e/KBxiBXPW4aY5FkVQYNziydF6KPtwXgTdiq+RMP4EjJK R+7sWMGJHHPRs+9PdFbi3VUrvvS9fHL6/gvQZbiX8NuXTBf29aLmu6RFL8WjfYXntUqY f1hg== X-Forwarded-Encrypted: i=1; AJvYcCUpnyEws0FCCLeKo1t3wwHY1PQFQRIa6OxeXWlXAMgwPRGhOlAM7K++vWMAoVmdOTNwk1Zf6b8himFAAQ==@gnu.org X-Gm-Message-State: AOJu0Yx8+XTh1NZ0j9OylIJDGBEF+W5cAkHJW8D2Dvwc0chtTeNkvMyV UuyzEaFmLSbDCR5NbUEKbIBAs9+34bWaQrT8MHlva16eH/2fAdfl X-Google-Smtp-Source: AGHT+IETCgWR2inPrEEB6bZfME008YoK3tp1sEM3yfftY3ipYoT4hXyDFqEVaurH/1VRgdysnOl9Yw== X-Received: by 2002:a05:6214:5404:b0:6c7:c5b5:a78d with SMTP id 6a1803df08f44-6cb1dd3e615mr51076196d6.18.1727297322549; Wed, 25 Sep 2024 13:48:42 -0700 (PDT) Original-Received: from gnus (bras-base-mtrlpq0776w-grc-23-65-94-70-53.dsl.bell.ca. [65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb31882c44sm75496d6.138.2024.09.25.13.48.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 13:48:42 -0700 (PDT) In-Reply-To: <8734lnsdcn.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 25 Sep 2024 20:11:20 +0000") Received-SPF: pass client-ip=2607:f8b0:4864:20::f43; envelope-from=suhailsingh247@gmail.com; helo=mail-qv1-xf43.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 26 Sep 2024 00:49:37 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324093 Archived-At: Philip Kaludercic writes: >> Which are the two packages being considered? > > IIRC the local package you have installed, the package on NonGNU ELPA, > the package on MELPA Stable and the package on MELPA Unstable. Since MELPA Unstable adds time-based versioning which is incompatible with NonGNU and MELPA Stable, it can simply be ignored. I.e., *only* when NonGNU (or much less likely, but for completeness GNU) ELPA and MELPA Stable version numbers match do we care about checking to verify if the commits match as well. >> From my perspective, the following is the desired behaviour: whenever >> package.el has evidence that the same purported package version is being >> served via different commits in the various remote archives (that the >> user has enabled) the user is made aware. If the package versions >> aren't the same, then no "COMMIT MISMATCH" should be shown. > > Yeah, that was my intention as well. Hm I didn't see the check to ensure that the package versions were identical in the last patch, but perhaps that was happening implicitly somehow. >> I.e., the situation of interest is when versions match, but commits >> don't. If it helps, "NON-UNIQUE COMMIT" might be more accurate, but I >> don't have a strong opinion on the wording. > > NON-UNIQUE COMMIT seems more vague to me? Yeah, I don't have a strong opinion on how we phrase it as long as the intended intent is "the version number of this package matches the version number available from another source, however the commits don't match". > And VC packages seem like a bit of an headache in this case, as Yeah, if you want to exclude VC packages I have no objection. Presumably if someone is using :vc checkout they are already paying attention to the commits. > Right, I'll try to test this myself before sending you more patches ^^ All good; appreciate your time on this :) >> Thanks for sharing the reference, but why is this not in the default >> branch (which is the only one linked from ) to >> begin with? Alternatively, if the elpa-admin variant is considered the >> canonical version, why doesn't the link from >> point to >> >> instead? > > No reason really, I'll try to update it soon. Thank you. -- Suhail