From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Fabio Natali via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74218: [PATCH] Ask confirmation before sending region to search engine. Date: Thu, 07 Nov 2024 11:29:37 +0000 Message-ID: <87fro3gu3i.fsf@fabionatali.com> References: <20241106005544.26516-1-me@fabionatali.com> <86pln8sfqe.fsf@gnu.org> <87ikt0gz7b.fsf@fabionatali.com> <86bjyrqvb0.fsf@gnu.org> <877c9fmn7b.fsf@gmail.com> <867c9fqpx0.fsf@gnu.org> <87v7wzl30n.fsf@gmail.com> <86zfmbpam0.fsf@gnu.org> Reply-To: Fabio Natali Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24705"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74218@debbugs.gnu.org, me@eshelyaron.com, stefankangas@gmail.com To: Eli Zaretskii , Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 07 12:30:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t90ib-0006Bl-Q6 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Nov 2024 12:30:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t90iG-00041u-Qb; Thu, 07 Nov 2024 06:30:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t90iD-0003t0-FS for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2024 06:30:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t90iB-0005zJ-HX for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2024 06:30:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=e0nVqp01KvjxmdUVJgZlIgaNBdmZZ3XoYi0FV+crvvM=; b=Etq8TOSVOwTnpQd1NWVNS4RA0tk7Ehz8usgoIcDNPqoakRun0fG/k3rzrImcaCGIKPGCWbTJpQAa0Hw9M5lFvzmRXSqRpMZCTm9vbQsqTpcsIgFrqjC+abAow34FQdyUdgqJNNB8pbotYJ1MDzgymYdjjfVJGqSVcnGS2czR3K3yo+UbfKzOC5PJ3XIxlTMEzXB7f44F7kEZAhq9jJKL6t1ZG2ML8WsRHsKPeE5Bb1z+4sScjHpkHDQsCQYTbEMTiHu8/8+BZNyClB20Lxa7Ygl3XuoDgIoPgb1lZmpjID7aFCXKhFBreAIhBqqqeBYjDlDscbJK4my3xNmUTzpofA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t90iA-0002Ts-E5 for bug-gnu-emacs@gnu.org; Thu, 07 Nov 2024 06:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Fabio Natali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Nov 2024 11:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74218-submit@debbugs.gnu.org id=B74218.17309789909494 (code B ref 74218); Thu, 07 Nov 2024 11:30:02 +0000 Original-Received: (at 74218) by debbugs.gnu.org; 7 Nov 2024 11:29:50 +0000 Original-Received: from localhost ([127.0.0.1]:47397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t90hy-0002T4-7m for submit@debbugs.gnu.org; Thu, 07 Nov 2024 06:29:50 -0500 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t90hv-0002Sq-FG for 74218@debbugs.gnu.org; Thu, 07 Nov 2024 06:29:48 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id CD518C000B; Thu, 7 Nov 2024 11:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1730978981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e0nVqp01KvjxmdUVJgZlIgaNBdmZZ3XoYi0FV+crvvM=; b=V3m6bkd3CUKdVMFSuf09tqG1FMvYF7v2UQ8X84fe2RAONbNcye/9Kt9L+3IhXrIV4lB02r /Ler25j4Ut00rYX/88Y6MPfyK/795ZGGh3wK+x4ea8nIugqMXjuQspIxlJ7BZC79hcQhd+ vxgxicj/T85N1tUY2MUcOIokKk1G9tjKO4LTaUhcB3mGWp4r98QCBq6Tlheoon3nCBeHqO ZApQnDTJElo7z5iMCFwUcV0TqXW5M5O7ybU6mek0KrpTWeiJiAUhBtNFrA+iqoukLPQi0g EG3Ry3/qF6r3/Yz6EkfPH8ZEIopYZQqE+FBruTcNR37BIBJTfUbyR77nWj69qA== In-Reply-To: <86zfmbpam0.fsf@gnu.org> X-GND-Sasl: me@fabionatali.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295017 Archived-At: On 2024-11-07, 13:05 +0200, Eli Zaretskii wrote: > My take on it is that the user might not realize that the region is > very large and includes parts she didn't intend to send. IOW, a > cockpit error. It's not only that. Commands can be typed by mistake. The fact that the command's docstring warns about its effects is not enough. By default, 'eww-search-words' is bound to 'M-s M-w'. The probability of accidentally mistyping that combination is not at all negligible. I did discover the command's beheaviour via view-lossage after mistyping 'M-s M-w', for example. One might argue that, no matter how long, all sequences of keys and commands could be mistyped, but that'd be a bit misleading. I think that adding a warning and a yes-or-no confirmation request would make 'eww-search-words' sufficiently safe, that's the assumption behind my patch. As I said above, I don't think that the sensitivity of a block of text is a function of its length. Case in point, a password, an address, any piece of Personally Identifiable Information. Users can always override the default and might decide to customise 'eww-search-words' as they like - but I still think it's important to provide a safe default, something safer than what we have today. Just my 2 cents. Thanks for giving this patch attention. Have a lovely day, cheers, Fabio. -- Fabio Natali https://fabionatali.com