From: Juri Linkov <juri@linkov.net>
To: Yuan Fu <casouri@gmail.com>
Cc: Kohei Tsuruta <seventhepg@gmail.com>,
Eli Zaretskii <eliz@gnu.org>,
75422@debbugs.gnu.org
Subject: bug#75422: 30.0.93; [PATCH] forward-sexp and backward-sexp jump outside of comments in tsx-ts-mode
Date: Wed, 08 Jan 2025 09:44:48 +0200 [thread overview]
Message-ID: <87frltlpfz.fsf@mail.linkov.net> (raw)
In-Reply-To: <07F33B09-D0C4-4C6A-8F80-10E2173D92FF@gmail.com> (Yuan Fu's message of "Tue, 7 Jan 2025 18:29:25 -0800")
>>> diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el
>>> index 4a38d1da596..0ffcb144771 100644
>>> --- a/lisp/progmodes/typescript-ts-mode.el
>>> +++ b/lisp/progmodes/typescript-ts-mode.el
>>> @@ -564,7 +564,9 @@ tsx-ts-mode
>>> (sentence ,(regexp-opt
>>> (append typescript-ts-mode--sentence-nodes
>>> '("jsx_element"
>>> - "jsx_self_closing_element")))))))
>>> + "jsx_self_closing_element"))))
>>> + (text ,(regexp-opt '("comment"
>>> + "template_string"))))))
>
> I think it’s fine. Though it’s for Eli to decide.
Eli, is it ok to push this patch to emacs-30?
It fills the omission that the thing 'text' is defined
only for 'typescript', but not for its counterpart 'tsx'.
BTW, in master we need to clean up typescript-ts-base-mode
that defines only 'typescript', but not 'tsx', i.e. we need
to create better inheritance for 'treesit-thing-settings'.
next prev parent reply other threads:[~2025-01-08 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 16:02 bug#75422: 30.0.93; [PATCH] forward-sexp and backward-sexp jump outside of comments in tsx-ts-mode Kohei Tsuruta
2025-01-07 17:44 ` Juri Linkov
2025-01-08 2:29 ` Yuan Fu
2025-01-08 7:44 ` Juri Linkov [this message]
2025-01-08 13:12 ` Eli Zaretskii
2025-01-09 7:51 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frltlpfz.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=75422@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=seventhepg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.